Skip to content

Commit f02347a

Browse files
authored
Merge pull request #396 from apache/cleanupWarnings
Cleanup warnings
2 parents 850d0b5 + 05fd993 commit f02347a

170 files changed

Lines changed: 20 additions & 188 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

src/main/java/org/apache/datasketches/cpc/CompressionCharacterization.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
* @author Lee Rhodes
4343
* @author Kevin Lang
4444
*/
45-
@SuppressWarnings("javadoc")
4645
public class CompressionCharacterization {
4746
private String hfmt;
4847
private String dfmt;

src/main/java/org/apache/datasketches/cpc/MergingValidation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
* @author Lee Rhodes
3838
* @author Kevin Lang
3939
*/
40-
@SuppressWarnings("javadoc")
4140
public class MergingValidation {
4241
private String hfmt;
4342
private String dfmt;

src/main/java/org/apache/datasketches/cpc/QuickMergingValidation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
* @author Lee Rhodes
3838
* @author Kevin Lang
3939
*/
40-
@SuppressWarnings("javadoc")
4140
public class QuickMergingValidation {
4241
private String hfmt;
4342
private String dfmt;

src/main/java/org/apache/datasketches/cpc/StreamingValidation.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
* @author Lee Rhodes
3636
* @author Kevin Lang
3737
*/
38-
@SuppressWarnings("javadoc")
3938
public class StreamingValidation {
4039
private String hfmt;
4140
private String dfmt;

src/main/java/org/apache/datasketches/frequencies/ItemsSketch.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,6 @@ public void reset() {
482482
* @param serDe an instance of ArrayOfItemsSerDe
483483
* @return a byte array representation of this sketch
484484
*/
485-
@SuppressWarnings("null")
486485
public byte[] toByteArray(final ArrayOfItemsSerDe<T> serDe) {
487486
final int preLongs;
488487
final int outBytes;

src/main/java/org/apache/datasketches/hash/XxHash.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,13 @@
2424
/**
2525
* The XxHash is a fast, non-cryptographic, 64-bit hash function that has
2626
* excellent avalanche and 2-way bit independence properties.
27-
*
28-
* <p>This class wraps the
27+
*
28+
* <p>This class wraps the
2929
* <a href="https://github.com/apache/datasketches-memory/blob/master/datasketches-memory-java8/src/main/java/org/apache/datasketches/memory/XxHash.java">Memory Component XxHash</a>
3030
* implementation.
3131
*
3232
* @author Lee Rhodes
3333
*/
34-
@SuppressWarnings("javadoc")
3534
public class XxHash {
3635

3736
/**

src/main/java/org/apache/datasketches/hll/TgtHllType.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
5252
* @author Lee Rhodes
5353
*/
54-
@SuppressWarnings("javadoc")
5554
public enum TgtHllType { HLL_4, HLL_6, HLL_8;
5655

5756
private static final TgtHllType values[] = values();

src/main/java/org/apache/datasketches/quantiles/DoublesUnionImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ public void reset() {
145145
}
146146

147147
//@formatter:off
148-
@SuppressWarnings("null")
149148
static UpdateDoublesSketch updateLogic(final int myMaxK, final UpdateDoublesSketch myQS,
150149
final DoublesSketch other) {
151150
int sw1 = ((myQS == null) ? 0 : myQS.isEmpty() ? 4 : 8);

src/main/java/org/apache/datasketches/quantiles/ItemsSketch.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,6 @@ public boolean isEmpty() {
532532
/**
533533
* @return true if this sketch is off-heap
534534
*/
535-
@SuppressWarnings("static-method")
536535
public boolean isDirect() {
537536
return false;
538537
}

src/main/java/org/apache/datasketches/quantiles/ItemsUnion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ public byte[] toByteArray(final ArrayOfItemsSerDe<T> serDe) {
254254
}
255255

256256
//@formatter:off
257-
@SuppressWarnings({"null", "unchecked"})
257+
@SuppressWarnings("unchecked")
258258
static <T> ItemsSketch<T> updateLogic(final int myMaxK, final Comparator<? super T> comparator,
259259
final ItemsSketch<T> myQS, final ItemsSketch<T> other) {
260260
int sw1 = ((myQS == null) ? 0 : myQS.isEmpty() ? 4 : 8);

0 commit comments

Comments
 (0)