Skip to content

Commit 22c7908

Browse files
authored
Merge pull request #257 from apache/better_test_coverage
More comprehensive tests.
2 parents f6a7c58 + e0faea2 commit 22c7908

File tree

9 files changed

+515
-517
lines changed

9 files changed

+515
-517
lines changed

src/main/java/org/apache/datasketches/memory/internal/NativeWritableBufferImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ final class NativeWritableBufferImpl extends WritableBufferImpl {
4141

4242
//Pass-through ctor
4343
NativeWritableBufferImpl(
44-
final Arena arena,
4544
final MemorySegment seg,
4645
final int typeId,
47-
final MemoryRequestServer memReqSvr) {
46+
final MemoryRequestServer memReqSvr,
47+
final Arena arena) {
4848
super(seg, typeId, memReqSvr, arena);
4949
}
5050

src/main/java/org/apache/datasketches/memory/internal/ResourceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ static final WritableBuffer selectBuffer(
220220
final MemoryRequestServer memReqSvr2 = (byteBufferType || mapType) ? null : memReqSvr;
221221
final WritableBuffer wbuf;
222222
if (nativeBOType) {
223-
wbuf = new NativeWritableBufferImpl(null, segment, type, memReqSvr2);
223+
wbuf = new NativeWritableBufferImpl(segment, type, memReqSvr2, null);
224224
} else { //non-native BO
225225
wbuf = new NonNativeWritableBufferImpl(segment, type, memReqSvr2, null);
226226
}

src/main/java/org/apache/datasketches/memory/internal/WritableBufferImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static WritableBuffer wrapByteBuffer(
9090
type |= NONNATIVE_BO;
9191
wbuf = new NonNativeWritableBufferImpl(seg, type, memReqSvr, null);
9292
} else {
93-
wbuf = new NativeWritableBufferImpl(null, seg, type, memReqSvr);
93+
wbuf = new NativeWritableBufferImpl(seg, type, memReqSvr, null);
9494
}
9595
wbuf.setStartPositionEnd(0, byteBuffer.position(), byteBuffer.limit());
9696
return wbuf;

0 commit comments

Comments
 (0)