Skip to content

Commit e9f998a

Browse files
authored
Merge pull request #260 from apache/hash_bug
Hash bug
2 parents 1b9e702 + 1902d17 commit e9f998a

File tree

3 files changed

+432
-4
lines changed

3 files changed

+432
-4
lines changed

src/main/java/org/apache/datasketches/memory/internal/MurmurHash3v4.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ public static long[] hash(final MemorySegment seg, final long offsetBytes, final
243243
}
244244

245245
case 13: {
246-
k2 ^= (seg.get(ValueLayout.JAVA_BYTE, cumOff + 12) & 0xFFFFL) << 32;
246+
k2 ^= (seg.get(ValueLayout.JAVA_BYTE, cumOff + 12) & 0xFFL) << 32;
247247
}
248248
//$FALL-THROUGH$
249249
case 12: {

src/test/java/org/apache/datasketches/memory/internal/MurmurHash3v3Test.java renamed to src/test/java/org/apache/datasketches/memory/internal/MurmurHash3v4Test.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,17 @@
2020
package org.apache.datasketches.memory.internal;
2121

2222
import static java.nio.charset.StandardCharsets.UTF_8;
23-
import static org.apache.datasketches.memory.MurmurHash3.*;
23+
import static org.apache.datasketches.memory.MurmurHash3.hash;
2424
import static org.testng.Assert.assertTrue;
2525
import static org.testng.Assert.fail;
2626

2727
import java.lang.foreign.Arena;
2828
import java.lang.foreign.MemorySegment;
2929
import java.nio.ByteOrder;
3030

31-
import org.apache.datasketches.memory.Resource;
3231
import org.apache.datasketches.memory.Memory;
3332
import org.apache.datasketches.memory.MemoryRequestServer;
33+
import org.apache.datasketches.memory.Resource;
3434
import org.apache.datasketches.memory.WritableMemory;
3535
import org.testng.Assert;
3636
import org.testng.annotations.Test;
@@ -41,7 +41,7 @@
4141
*
4242
* @author Lee Rhodes
4343
*/
44-
public class MurmurHash3v3Test {
44+
public class MurmurHash3v4Test {
4545
private static final MemoryRequestServer memReqSvr = Resource.defaultMemReqSvr;
4646

4747
@Test

0 commit comments

Comments
 (0)