Skip to content

Commit 6862fe7

Browse files
authored
Removed unused StateEventHandleFailure (#16052)
1 parent 56ecec7 commit 6862fe7

File tree

3 files changed

+1
-43
lines changed

3 files changed

+1
-43
lines changed

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/StateEventHandleFailure.java

-33
This file was deleted.

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/event/StateEventHandler.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,9 @@ public interface StateEventHandler {
2828
* @param stateEvent given state event.
2929
* @throws StateEventHandleException this exception means it can be recovered.
3030
* @throws StateEventHandleError this exception means it cannot be recovered, so the event need to drop.
31-
* @throws StateEventHandleException this means it can be recovered.
3231
*/
3332
boolean handleStateEvent(WorkflowExecuteRunnable workflowExecuteRunnable,
34-
StateEvent stateEvent) throws StateEventHandleException, StateEventHandleError, StateEventHandleFailure;
33+
StateEvent stateEvent) throws StateEventHandleException, StateEventHandleError;
3534

3635
StateEventType getEventType();
3736
}

dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java

-8
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
import org.apache.dolphinscheduler.server.master.event.StateEvent;
6666
import org.apache.dolphinscheduler.server.master.event.StateEventHandleError;
6767
import org.apache.dolphinscheduler.server.master.event.StateEventHandleException;
68-
import org.apache.dolphinscheduler.server.master.event.StateEventHandleFailure;
6968
import org.apache.dolphinscheduler.server.master.event.StateEventHandler;
7069
import org.apache.dolphinscheduler.server.master.event.StateEventHandlerManager;
7170
import org.apache.dolphinscheduler.server.master.event.TaskStateEvent;
@@ -298,13 +297,6 @@ public void handleEvents() {
298297
stateEvent,
299298
stateEventHandleException);
300299
ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
301-
} catch (StateEventHandleFailure stateEventHandleFailure) {
302-
log.error("State event handle failed, will move event to the tail: {}",
303-
stateEvent,
304-
stateEventHandleFailure);
305-
this.stateEvents.remove(stateEvent);
306-
this.stateEvents.offer(stateEvent);
307-
ThreadUtils.sleep(Constants.SLEEP_TIME_MILLIS);
308300
} catch (Exception e) {
309301
// we catch the exception here, since if the state event handle failed, the state event will still
310302
// keep

0 commit comments

Comments
 (0)