Skip to content

Commit b9b3648

Browse files
author
wangxj3
committed
Merge remote-tracking branch 'upstream/3.2.2-prepare' into 3.2.2-release
2 parents 0c917de + 1e3bbfc commit b9b3648

File tree

2 files changed

+10
-10
lines changed
  • dolphinscheduler-task-plugin/dolphinscheduler-task-java/src

2 files changed

+10
-10
lines changed

Diff for: dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaTask.java

-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
package org.apache.dolphinscheduler.plugin.task.java;
1919

20-
import static org.apache.dolphinscheduler.common.constants.Constants.FOLDER_SEPARATOR;
2120
import static org.apache.dolphinscheduler.plugin.task.java.JavaConstants.JAVA_HOME_VAR;
2221
import static org.apache.dolphinscheduler.plugin.task.java.JavaConstants.PUBLIC_CLASS_NAME_REGEX;
2322

@@ -187,7 +186,6 @@ protected String buildJarCommand() {
187186
.append("java").append(" ")
188187
.append(buildResourcePath()).append(" ")
189188
.append("-jar").append(" ")
190-
.append(taskRequest.getExecutePath()).append(FOLDER_SEPARATOR)
191189
.append(mainJarAbsolutePathInLocal).append(" ")
192190
.append(javaParameters.getMainArgs().trim()).append(" ")
193191
.append(javaParameters.getJvmArgs().trim());

Diff for: dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/test/java/org/apache/dolphinscheduler/plugin/task/java/JavaTaskTest.java

+10-8
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public void buildJarCommand() {
8585
JavaTask javaTask = runJarType();
8686
assertThat(javaTask.buildJarCommand())
8787
.isEqualTo(
88-
"${JAVA_HOME}/bin/java -classpath .:/tmp/dolphinscheduler/test/executepath:opt/share/jar/resource2.jar -jar /tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar -host 127.0.0.1 -port 8080 -xms:50m");
88+
"${JAVA_HOME}/bin/java -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar -jar /tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar -host 127.0.0.1 -port 8080 -xms:50m");
8989
}
9090

9191
/**
@@ -107,7 +107,7 @@ public void buildJavaCompileCommand() throws IOException {
107107
}
108108
assertThat(javaTask.buildJavaCompileCommand(sourceCode))
109109
.isEqualTo(
110-
"${JAVA_HOME}/bin/javac -classpath .:/tmp/dolphinscheduler/test/executepath:opt/share/jar/resource2.jar /tmp/dolphinscheduler/test/executepath/JavaTaskTest.java");
110+
"${JAVA_HOME}/bin/javac -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar /tmp/dolphinscheduler/test/executepath/JavaTaskTest.java");
111111
} finally {
112112
Path path = Paths.get(fileName);
113113
if (Files.exists(path)) {
@@ -137,7 +137,7 @@ public void buildJavaCommand() throws Exception {
137137
}
138138
assertThat(javaTask.buildJavaCommand())
139139
.isEqualTo(
140-
"${JAVA_HOME}/bin/javac -classpath .:/tmp/dolphinscheduler/test/executepath:opt/share/jar/resource2.jar /tmp/dolphinscheduler/test/executepath/JavaTaskTest.java;${JAVA_HOME}/bin/java -classpath .:/tmp/dolphinscheduler/test/executepath:opt/share/jar/resource2.jar JavaTaskTest -host 127.0.0.1 -port 8080 -xms:50m");
140+
"${JAVA_HOME}/bin/javac -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar /tmp/dolphinscheduler/test/executepath/JavaTaskTest.java;${JAVA_HOME}/bin/java -classpath .:/tmp/dolphinscheduler/test/executepath:/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar JavaTaskTest -host 127.0.0.1 -port 8080 -xms:50m");
141141
}
142142

143143
/**
@@ -254,15 +254,16 @@ public JavaTask runJavaType() {
254254
taskExecutionContext.setTaskAppId("runJavaType");
255255
ResourceContext.ResourceItem resourceItem1 = new ResourceContext.ResourceItem();
256256
resourceItem1.setResourceAbsolutePathInStorage("/opt/share/jar/resource2.jar");
257-
resourceItem1.setResourceAbsolutePathInLocal("opt/share/jar/resource2.jar");
257+
resourceItem1
258+
.setResourceAbsolutePathInLocal("/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar");
258259

259260
ResourceContext.ResourceItem resourceItem2 = new ResourceContext.ResourceItem();
260261
resourceItem2.setResourceAbsolutePathInStorage("/opt/share/jar/main.jar");
261-
resourceItem2.setResourceAbsolutePathInLocal("opt/share/jar/main.jar");
262+
resourceItem2.setResourceAbsolutePathInLocal("/tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar");
262263

263264
ResourceContext.ResourceItem resourceItem3 = new ResourceContext.ResourceItem();
264265
resourceItem3.setResourceAbsolutePathInStorage("/JavaTaskTest.java");
265-
resourceItem3.setResourceAbsolutePathInLocal("JavaTaskTest.java");
266+
resourceItem3.setResourceAbsolutePathInLocal("/tmp/dolphinscheduler/test/executepath/JavaTaskTest.java");
266267

267268
ResourceContext resourceContext = new ResourceContext();
268269
resourceContext.addResourceItem(resourceItem1);
@@ -286,11 +287,12 @@ private JavaTask runJarType() {
286287
taskExecutionContext.setTaskAppId("runJavaType");
287288
ResourceContext.ResourceItem resourceItem1 = new ResourceContext.ResourceItem();
288289
resourceItem1.setResourceAbsolutePathInStorage("/opt/share/jar/resource2.jar");
289-
resourceItem1.setResourceAbsolutePathInLocal("opt/share/jar/resource2.jar");
290+
resourceItem1
291+
.setResourceAbsolutePathInLocal("/tmp/dolphinscheduler/test/executepath/opt/share/jar/resource2.jar");
290292

291293
ResourceContext.ResourceItem resourceItem2 = new ResourceContext.ResourceItem();
292294
resourceItem2.setResourceAbsolutePathInStorage("/opt/share/jar/main.jar");
293-
resourceItem2.setResourceAbsolutePathInLocal("opt/share/jar/main.jar");
295+
resourceItem2.setResourceAbsolutePathInLocal("/tmp/dolphinscheduler/test/executepath/opt/share/jar/main.jar");
294296

295297
ResourceContext resourceContext = new ResourceContext();
296298
resourceContext.addResourceItem(resourceItem1);

0 commit comments

Comments
 (0)