[Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. #15139

qifanlili · 2023-11-08T06:59:35Z

Purpose of the pull request

This pull request support using JDBC registry plugin in standalone mode. close #15103

Brief change log

Same configuration as the Zookeeper/JDBC plugin. Type gives the user the option to use any type as a registry
Add README.mdl

Verify this pull request

This pull request is already covered by existing tests, such as (please describe tests).

qifanlili · 2023-11-08T07:24:24Z

@ruanwenjun I don't know how to add labels, I'm a bit confused. Can you help me ?

ruanwenjun · 2023-11-08T09:41:26Z

@ruanwenjun I don't know how to add labels, I'm a bit confused. Can you help me ?

You don't have permission to add label.

qifanlili · 2023-11-08T09:54:26Z

@ruanwenjun I don't know how to add labels, I'm a bit confused. Can you help me ?

You don't have permission to add label.

@ruanwenjun Thank you so much! But I see that the check here is still not passed. Do you have to review it before it's approved?

SbloodyS · 2023-11-08T10:07:38Z

...nscheduler-standalone-server/src/main/java/org/apache/dolphinscheduler/StandaloneServer.java

+        }
+    }
+
+}


Please add a blank line here.

Please add a blank line here.

Thanks for the tip！ I haven't made a habit of using “mvn spotless: apply”

SbloodyS · 2023-11-08T10:08:16Z

...nscheduler-standalone-server/src/main/java/org/apache/dolphinscheduler/StandaloneServer.java

    public static void main(String[] args) throws Exception {
        try {
-            // We cannot use try-with-resources to close "TestingServer", since SpringApplication.run() will not block


Why remove this?

Why remove this?

I'm sorry I missed that. My idea is to move it to the “dolphinscheduler-standalone-server/src/main/java/org/apache/dolphinscheduler/registry/ZookeeperStandaloneRegistry.java”

...e-server/src/main/java/org/apache/dolphinscheduler/registry/ZookeeperStandaloneRegistry.java

…in standalone mode.(apache#15139)

codecov-commenter · 2023-11-08T11:31:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6175f3) 38.23% compared to head (1a240f1) 38.18%.
Report is 9 commits behind head on dev.

❗ Current head 1a240f1 differs from pull request most recent head 627427e. Consider uploading reports for the commit 627427e to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15139      +/-   ##
============================================
- Coverage     38.23%   38.18%   -0.06%     
+ Complexity     4695     4679      -16     
============================================
  Files          1285     1285              
  Lines         45453    45453              
  Branches       4951     4951              
============================================
- Hits          17381    17358      -23     
- Misses        26181    26203      +22     
- Partials       1891     1892       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…in standalone mode.(apache#15139) fix: Add a nested comment explaining why this method is empty.

ruanwenjun · 2023-11-08T15:24:32Z

...rc/main/java/org/apache/dolphinscheduler/plugin/registry/jdbc/JdbcRegistryConfiguration.java

@@ -34,7 +34,7 @@
 @ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "jdbc")
 public class JdbcRegistryConfiguration {

-    @Bean
+    @Bean("sqlSessionFactory")


It's not a good idea add name 'sqlSessionFactory' for this bean, since this will cause the JdbcRegistry use the same sql session factory with the business.

It's not a good idea add name 'sqlSessionFactory' for this bean, since this will cause the JdbcRegistry use the same sql session factory with the business.

Thank you for reminding me of this. I write this because I find that When I using JDBCRegistry plugin,
if I don't explicitly declare 'sqlSessionFactory' , an exception will be thrown at startup:
dolphinscheduler-standalone.log

I think it might be because of 'DaoConfiguration. java 'references it

Is this a known problem?

@ruanwenjun can you help me? What can I do to improve this feature?

I didn't meet this problem, it can work well when I use JDBC registry

ruanwenjun · 2023-11-08T15:28:03Z

...dalone-server/src/main/java/org/apache/dolphinscheduler/registry/JdbcStandaloneRegistry.java

+@Component
+public class JdbcStandaloneRegistry implements StandaloneRegistry {
+
+    @Override
+    public void init() {
+        // The JDBC plugin will take effect via @ConditionalOnProperty.
+    }
+
+    @Override
+    public boolean supports(String registryType) {
+        return "jdbc".equalsIgnoreCase(registryType);
+    }
+}


Can we remove this? I hope we can only add a StandaloneZookeeperRegistry, in this class, we will start a TestingServer, and user can still use zookeeper registry to connect their own zk cluster or use JDBC to connect their own db.

Can we remove this? I hope we can only add a StandaloneZookeeperRegistry, in this class, we will start a TestingServer, and user can still use zookeeper registry to connect their own zk cluster or use JDBC to connect their own db.

Sure!

…in standalone mode.(apache#15139) fix: remove JdbcStandaloneRegistry

sonarqubecloud · 2023-11-21T07:06:43Z

SonarCloud Quality Gate failed.

3 Bugs
0 Vulnerabilities
1 Security Hotspot
236 Code Smells

65.7% Coverage
1.6% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-actions · 2024-03-21T00:20:30Z

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

github-actions · 2024-03-29T00:19:55Z

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

qifanlili requested review from caishunfeng and ruanwenjun as code owners November 8, 2023 06:59

github-actions bot added the backend label Nov 8, 2023

qifanlili changed the title ~~[Feature][Standalone]Support using JDBC registry plugin in standalone mode. #15103~~ [Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. Nov 8, 2023

qifanlili marked this pull request as draft November 8, 2023 07:09

ruanwenjun added the feature new feature label Nov 8, 2023

ruanwenjun assigned qifanlili Nov 8, 2023

qifanlili marked this pull request as ready for review November 8, 2023 09:51

SbloodyS added first time contributor First-time contributor 3.3.0 labels Nov 8, 2023

SbloodyS added this to the 3.3.0 milestone Nov 8, 2023

SbloodyS reviewed Nov 8, 2023

View reviewed changes

github-advanced-security bot found potential problems Nov 8, 2023

View reviewed changes

...e-server/src/main/java/org/apache/dolphinscheduler/registry/ZookeeperStandaloneRegistry.java Fixed Show resolved Hide resolved

qifanlili added a commit to qifanlili/dolphinscheduler that referenced this pull request Nov 8, 2023

[Feature-apache#15103][Standalone]Support using JDBC registry plugin …

8777830

…in standalone mode.(apache#15139)

[Feature-apache#15103][Standalone]Support using JDBC registry plugin …

b93ae76

…in standalone mode.(apache#15139)

qifanlili force-pushed the dev branch from 8777830 to b93ae76 Compare November 8, 2023 11:09

[Feature-apache#15103][Standalone]Support using JDBC registry plugin …

baa3e0b

…in standalone mode.(apache#15139) fix: Add a nested comment explaining why this method is empty.

ruanwenjun reviewed Nov 8, 2023

View reviewed changes

qifanlili added 3 commits November 9, 2023 11:46

[Feature-apache#15103][Standalone]Support using JDBC registry plugin …

0506b9e

…in standalone mode.(apache#15139) fix: remove JdbcStandaloneRegistry

Merge branch 'apache:dev' into dev

d7bf4f1

Merge branch 'apache:dev' into dev

627427e

github-actions bot added the Stale label Mar 21, 2024

github-actions bot closed this Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. #15139

[Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. #15139

qifanlili commented Nov 8, 2023 •

edited by SbloodyS

Loading

qifanlili commented Nov 8, 2023 •

edited

Loading

ruanwenjun commented Nov 8, 2023

qifanlili commented Nov 8, 2023 •

edited

Loading

SbloodyS Nov 8, 2023

qifanlili Nov 8, 2023

SbloodyS Nov 8, 2023

qifanlili Nov 8, 2023

codecov-commenter commented Nov 8, 2023 •

edited

Loading

ruanwenjun Nov 8, 2023

qifanlili Nov 9, 2023 •

edited

Loading

qifanlili Nov 17, 2023

ruanwenjun Nov 21, 2023

ruanwenjun Nov 8, 2023

qifanlili Nov 9, 2023

sonarqubecloud bot commented Nov 21, 2023

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 29, 2024

+                      }
+                  }
+              }

[Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. #15139

[Feature-#15103][Standalone]Support using JDBC registry plugin in standalone mode. #15139

Conversation

qifanlili commented Nov 8, 2023 • edited by SbloodyS Loading

Purpose of the pull request

Brief change log

Verify this pull request

qifanlili commented Nov 8, 2023 • edited Loading

ruanwenjun commented Nov 8, 2023

qifanlili commented Nov 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Nov 8, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

qifanlili Nov 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 21, 2023

github-actions bot commented Mar 21, 2024

github-actions bot commented Mar 29, 2024

qifanlili commented Nov 8, 2023 •

edited by SbloodyS

Loading

qifanlili commented Nov 8, 2023 •

edited

Loading

qifanlili commented Nov 8, 2023 •

edited

Loading

codecov-commenter commented Nov 8, 2023 •

edited

Loading

qifanlili Nov 9, 2023 •

edited

Loading