Search before asking
Description
In current configuration insecure version of protocol LDAP is used by default and there is no option to switch to secured LDAPS.
This causes problem while deploying DORIS in environments where only LDAPS is available as no authentication is possible.
To prevent such situation I'll introduce the change that will support existing behavior by default, but will allow to switch to LDAPS if needed.
Solution
The proposed solution is to introduce into configuration new non-mandatory property ldap_use_ssl with default value false.
The default value or explicitly specified false will support existing behavior and use LDAP to create connection string.
But if true will be specified - the LDAPS protocol will be used for connection.
The logic to prepare string with URL connection will be moved to separate method to avoid duplication and allow unit testing of introduced feature.
Are you willing to submit PR?
Code of Conduct