Skip to content

Commit 835a2b9

Browse files
committed
[fix](be) Use string values in auto partition name test
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: The auto partition name unit test stored string literals as const char pointers in AnyType. The test utility reads VARCHAR cells as std::string, which caused std::bad_any_cast before function execution. Use explicit std::string values for all inputs and expected outputs. ### Release note None ### Check List (For Author) - Test: Unit Test - function_string_test.function_auto_partition_name_case_insensitive_test - Behavior changed: No - Does this need documentation: No
1 parent c97d27d commit 835a2b9

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

be/test/exprs/function/function_string_test.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ TEST(function_string_test, function_auto_partition_name_case_insensitive_test) {
8585
const InputTypeSet list_input_types = {Consted {PrimitiveType::TYPE_VARCHAR},
8686
Consted {PrimitiveType::TYPE_VARCHAR}};
8787
const DataSet list_data_set = {
88-
{{"LIST", "edc_server2"}, "pedc5fserver211"},
89-
{{"LiSt", "edc_server2"}, "pedc5fserver211"},
88+
{{std::string("LIST"), std::string("edc_server2")}, std::string("pedc5fserver211")},
89+
{{std::string("LiSt"), std::string("edc_server2")}, std::string("pedc5fserver211")},
9090
};
9191
for (const auto& data : list_data_set) {
9292
ASSERT_TRUE(check_function<DataTypeString>("auto_partition_name", list_input_types, {data})
@@ -97,8 +97,10 @@ TEST(function_string_test, function_auto_partition_name_case_insensitive_test) {
9797
Consted {PrimitiveType::TYPE_VARCHAR},
9898
Consted {PrimitiveType::TYPE_VARCHAR}};
9999
const DataSet range_data_set = {
100-
{{"RANGE", "MONTH", "2022-12-12 19:20:30"}, "p20221201000000"},
101-
{{"rAnGe", "dAy", "2022-12-12 19:20:30"}, "p20221212000000"},
100+
{{std::string("RANGE"), std::string("MONTH"), std::string("2022-12-12 19:20:30")},
101+
std::string("p20221201000000")},
102+
{{std::string("rAnGe"), std::string("dAy"), std::string("2022-12-12 19:20:30")},
103+
std::string("p20221212000000")},
102104
};
103105
for (const auto& data : range_data_set) {
104106
ASSERT_TRUE(check_function<DataTypeString>("auto_partition_name", range_input_types, {data})

0 commit comments

Comments
 (0)