[Feature](literal)Support TimeV2Literal #47319
Open
+1,397
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32300 ms |
TPC-DS: Total hot run time: 195154 ms |
ClickBench: Total hot run time: 30.98 s |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 32669 ms |
TPC-DS: Total hot run time: 184397 ms |
ClickBench: Total hot run time: 30.49 s |
zclllyybb
reviewed
Jan 24, 2025
zclllyybb
reviewed
Jan 24, 2025
|
run buildall |
|
TeamCity be ut coverage result: |
|
run buildall |
TPC-H: Total hot run time: 32315 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192714 ms |
ClickBench: Total hot run time: 30.85 s |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 32492 ms |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31606 ms |
TPC-DS: Total hot run time: 189985 ms |
ClickBench: Total hot run time: 30.9 s |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31306 ms |
TPC-DS: Total hot run time: 183551 ms |
ClickBench: Total hot run time: 30.84 s |
|
TeamCity be ut coverage result: |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31361 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 190451 ms |
ClickBench: Total hot run time: 30.95 s |
morrySnow
reviewed
Mar 4, 2025
|
|
||
| public TimeV2Literal(double value) throws AnalysisException { | ||
| super(); | ||
| if (value > (double) MAX_TIME.getValue() || value < -(double) MAX_TIME.getValue()) { |
There was a problem hiding this comment.
why not use MIN_TIME when check lowest bound? does this mean, we accept -(838, 01,01, 0)? it is lower than MIN_TIME
There was a problem hiding this comment.
MAX_TIME and MIN_TIME just store every part min max value
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| protected static boolean checkRange(double hour, long minute, long second, long microsecond) { | ||
| return hour > 838 || minute > 59 || second > 59 || hour < 0 || minute < 0 || second < 0 |
There was a problem hiding this comment.
same problem as ctor. maybe the MIN_TIME's corrent value is -838, 59, 59, 999999, 6 ?
There was a problem hiding this comment.
but, if caller input negative as argument'TimeLiteral(-1,-1,-1,-1,-1)', the checkRange will not work corrently, because if we call getValue() it return false. minute > MAXTIME.minute(59) || minute < MINTIME.minute(59) always return true(except 59) , perhaps the variable name should be changed to make it more consistent with usage
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java
Outdated
Show resolved
Hide resolved
| protected boolean negative; | ||
|
|
||
| public TimeV2Literal(String s) { | ||
| this(TimeV2Type.of(0), s); |
There was a problem hiding this comment.
why ctor with string always has 0 as scale? how about 01:01:01.123456?
There was a problem hiding this comment.
because if the sql isselect cast("01:01:01.123456" as time) will call this function directly, the sql means scale is 0, unless it use as time(scale) this situation will call another function
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/TimeV2Literal.java
Outdated
Show resolved
Hide resolved
| public class TimeV2LiteralTest { | ||
|
|
||
| @Test | ||
| public void testTimeLiteralCreate() { |
There was a problem hiding this comment.
add out of bound test to ensure check is working as well
|
run buildall |
|
run buildall |
|
TeamCity cloud ut coverage result: |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)