Skip to content

[Feature](literal)Support TimeV2Literal #47319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Jun 3, 2025
Merged

[Feature](literal)Support TimeV2Literal #47319

merged 55 commits into from
Jun 3, 2025

Conversation

koarz
Copy link
Contributor

@koarz koarz commented Jan 22, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

explain select cast('12:30:30' as time);

before:

 PLAN FRAGMENT 0                   
   OUTPUT EXPRS:                   
     cast('12:30:30' as time)[#0]  
   PARTITION: UNPARTITIONED        
                                   
   HAS_COLO_PLAN_NODE: false       
                                   
   VRESULT SINK                    
      MYSQL_PROTOCAL               
                                   
   0:VUNION(28)                    
      constant exprs:              
          CAST('12:30:30' AS time) 

after:

PLAN FRAGMENT 0
  OUTPUT EXPRS:
    12:30:30[#0]
  PARTITION: UNPARTITIONED

  HAS_COLO_PLAN_NODE: false

  VRESULT SINK
     MYSQL_PROTOCAL

  0:VUNION(30)
     constant exprs: 
         "12:30:30"

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Jan 22, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32300 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1f40fb9cf6fb7f759cc4bc0668f6ff76f2e61429, data reload: false

------ Round 1 ----------------------------------
q1	17624	5579	5363	5363
q2	2069	321	192	192
q3	10455	1241	747	747
q4	10214	981	522	522
q5	7612	2382	2170	2170
q6	197	171	136	136
q7	906	753	602	602
q8	9250	1384	1164	1164
q9	5159	4945	4927	4927
q10	6820	2332	1900	1900
q11	483	281	260	260
q12	338	367	209	209
q13	17778	3681	3045	3045
q14	239	231	214	214
q15	524	482	459	459
q16	620	619	572	572
q17	561	871	322	322
q18	7075	6617	6448	6448
q19	1633	965	540	540
q20	312	321	190	190
q21	2979	2168	2011	2011
q22	372	343	307	307
Total cold run time: 103220 ms
Total hot run time: 32300 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5528	5626	5537	5537
q2	242	334	235	235
q3	2255	2694	2351	2351
q4	1422	1862	1367	1367
q5	4334	4772	4627	4627
q6	164	162	127	127
q7	2087	1960	1860	1860
q8	2665	2811	2680	2680
q9	7384	7233	7293	7233
q10	3022	3289	2773	2773
q11	572	508	484	484
q12	647	755	557	557
q13	3514	3928	3257	3257
q14	281	302	280	280
q15	522	471	485	471
q16	666	696	650	650
q17	1228	1747	1315	1315
q18	7818	7623	7391	7391
q19	803	1020	1117	1020
q20	2032	2044	1939	1939
q21	5770	5164	4956	4956
q22	609	612	576	576
Total cold run time: 53565 ms
Total hot run time: 51686 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195154 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1f40fb9cf6fb7f759cc4bc0668f6ff76f2e61429, data reload: false

query1	1311	973	940	940
query2	6323	2065	2012	2012
query3	10959	4618	4472	4472
query4	60748	31352	23004	23004
query5	5605	623	478	478
query6	439	202	188	188
query7	5567	518	310	310
query8	323	237	221	221
query9	8217	2669	2700	2669
query10	452	311	262	262
query11	17492	15475	15648	15475
query12	163	108	108	108
query13	1440	549	423	423
query14	11075	7350	6697	6697
query15	214	201	197	197
query16	7214	685	492	492
query17	1109	736	573	573
query18	1853	407	310	310
query19	200	190	160	160
query20	116	124	117	117
query21	212	123	104	104
query22	4541	4758	4439	4439
query23	34136	33321	33494	33321
query24	5568	2358	2375	2358
query25	513	517	440	440
query26	648	295	165	165
query27	1612	516	336	336
query28	4230	2506	2482	2482
query29	560	587	421	421
query30	220	189	156	156
query31	937	925	874	874
query32	67	58	58	58
query33	429	361	308	308
query34	771	862	529	529
query35	831	826	756	756
query36	1016	1059	964	964
query37	130	115	80	80
query38	4391	4356	4341	4341
query39	1484	1448	1446	1446
query40	220	123	105	105
query41	52	49	54	49
query42	118	106	99	99
query43	518	540	502	502
query44	1364	837	836	836
query45	182	179	170	170
query46	923	1079	670	670
query47	1872	1939	1822	1822
query48	401	425	356	356
query49	713	523	400	400
query50	716	700	407	407
query51	7141	7110	7057	7057
query52	106	100	95	95
query53	238	262	195	195
query54	501	519	441	441
query55	85	77	78	77
query56	278	286	277	277
query57	1278	1217	1101	1101
query58	240	237	248	237
query59	3188	3237	2979	2979
query60	285	268	252	252
query61	121	119	118	118
query62	732	708	640	640
query63	229	196	192	192
query64	1320	1025	670	670
query65	3283	3150	3158	3150
query66	762	391	305	305
query67	15885	15598	15461	15461
query68	4130	857	533	533
query69	490	301	264	264
query70	1206	1138	1159	1138
query71	412	356	264	264
query72	6028	3881	3968	3881
query73	700	778	378	378
query74	10656	8840	8915	8840
query75	3259	3162	2676	2676
query76	3273	1202	810	810
query77	489	366	285	285
query78	10158	10281	9400	9400
query79	2749	828	612	612
query80	1682	549	530	530
query81	564	276	233	233
query82	347	149	127	127
query83	267	173	149	149
query84	288	105	74	74
query85	783	345	305	305
query86	420	325	288	288
query87	4368	4456	4463	4456
query88	3357	2246	2184	2184
query89	411	322	295	295
query90	1542	199	196	196
query91	135	142	117	117
query92	63	59	55	55
query93	1821	876	540	540
query94	697	386	296	296
query95	346	275	258	258
query96	489	633	285	285
query97	2819	2883	2781	2781
query98	231	197	199	197
query99	1290	1364	1358	1358
Total cold run time: 311337 ms
Total hot run time: 195154 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.98 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1f40fb9cf6fb7f759cc4bc0668f6ff76f2e61429, data reload: false

query1	0.03	0.03	0.03
query2	0.09	0.04	0.05
query3	0.23	0.06	0.05
query4	1.64	0.08	0.08
query5	0.42	0.39	0.39
query6	1.16	0.67	0.67
query7	0.02	0.02	0.02
query8	0.05	0.04	0.05
query9	0.56	0.49	0.49
query10	0.56	0.56	0.56
query11	0.16	0.12	0.11
query12	0.16	0.13	0.14
query13	0.60	0.60	0.60
query14	2.82	2.83	2.75
query15	0.91	0.83	0.84
query16	0.37	0.38	0.38
query17	1.08	1.06	1.05
query18	0.19	0.18	0.20
query19	1.92	1.88	2.07
query20	0.02	0.01	0.01
query21	15.36	0.98	0.65
query22	0.79	0.79	0.71
query23	14.97	1.43	0.69
query24	2.27	0.39	0.22
query25	0.14	0.08	0.08
query26	0.28	0.19	0.17
query27	0.08	0.08	0.08
query28	13.46	1.24	0.56
query29	12.69	4.08	3.39
query30	0.24	0.08	0.06
query31	2.83	0.61	0.39
query32	3.22	0.59	0.47
query33	3.00	3.00	3.03
query34	16.63	5.19	4.57
query35	4.57	4.55	4.56
query36	0.82	0.47	0.48
query37	0.20	0.17	0.16
query38	0.16	0.16	0.15
query39	0.05	0.04	0.04
query40	0.17	0.13	0.13
query41	0.10	0.06	0.06
query42	0.07	0.05	0.06
query43	0.05	0.05	0.04
Total cold run time: 105.14 s
Total hot run time: 30.98 s

@koarz
Copy link
Contributor Author

koarz commented Jan 22, 2025

run p0

1 similar comment
@koarz
Copy link
Contributor Author

koarz commented Jan 23, 2025

run p0

@koarz
Copy link
Contributor Author

koarz commented Jan 23, 2025

run buildall

@koarz
Copy link
Contributor Author

koarz commented Jan 23, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32669 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 518d3307e8b03429c3449c21d91515816e537daa, data reload: false

------ Round 1 ----------------------------------
q1	17951	5545	5434	5434
q2	2055	317	168	168
q3	10661	1276	744	744
q4	10293	972	546	546
q5	9372	2444	2189	2189
q6	206	169	138	138
q7	903	759	632	632
q8	9228	1323	1190	1190
q9	5982	4968	4878	4878
q10	6859	2318	1887	1887
q11	473	271	255	255
q12	351	369	227	227
q13	17778	3707	3162	3162
q14	243	245	209	209
q15	517	490	482	482
q16	638	620	598	598
q17	561	865	325	325
q18	7055	6529	6480	6480
q19	2154	961	572	572
q20	324	321	188	188
q21	2875	2276	2046	2046
q22	394	346	319	319
Total cold run time: 106873 ms
Total hot run time: 32669 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5724	5541	5579	5541
q2	238	336	235	235
q3	2272	2656	2287	2287
q4	1439	1803	1381	1381
q5	4358	4733	4962	4733
q6	176	163	126	126
q7	2067	1978	1854	1854
q8	2625	2801	2682	2682
q9	7226	7310	7131	7131
q10	2984	3308	2760	2760
q11	593	514	495	495
q12	688	765	636	636
q13	3557	3962	3310	3310
q14	292	309	284	284
q15	529	465	469	465
q16	657	687	639	639
q17	1210	1728	1225	1225
q18	7765	7465	7495	7465
q19	837	1168	1095	1095
q20	1986	2084	1900	1900
q21	5858	5323	4849	4849
q22	610	578	604	578
Total cold run time: 53691 ms
Total hot run time: 51671 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184397 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 518d3307e8b03429c3449c21d91515816e537daa, data reload: false

query1	955	381	397	381
query2	6546	2012	2010	2010
query3	6791	211	218	211
query4	33680	23509	23535	23509
query5	4384	636	458	458
query6	297	200	196	196
query7	4600	507	318	318
query8	292	232	230	230
query9	9456	2595	2547	2547
query10	460	312	239	239
query11	17762	15135	14935	14935
query12	148	107	101	101
query13	1654	501	378	378
query14	10311	6361	6306	6306
query15	217	189	182	182
query16	7919	625	480	480
query17	1565	711	551	551
query18	2046	394	297	297
query19	214	174	161	161
query20	112	107	105	105
query21	205	119	102	102
query22	4277	4601	4146	4146
query23	34121	32724	32974	32724
query24	6523	2210	2260	2210
query25	459	439	376	376
query26	1088	232	152	152
query27	2050	453	337	337
query28	5378	2429	2420	2420
query29	545	500	455	455
query30	232	192	162	162
query31	961	865	741	741
query32	76	62	60	60
query33	512	349	294	294
query34	757	831	484	484
query35	798	820	746	746
query36	987	1013	954	954
query37	133	103	85	85
query38	4128	4075	4107	4075
query39	1459	1401	1404	1401
query40	212	115	101	101
query41	52	51	53	51
query42	141	99	96	96
query43	505	530	488	488
query44	1324	806	809	806
query45	184	174	163	163
query46	840	1022	636	636
query47	1841	1861	1799	1799
query48	390	385	308	308
query49	772	485	403	403
query50	634	664	394	394
query51	4169	4351	4110	4110
query52	109	103	92	92
query53	239	255	184	184
query54	484	474	418	418
query55	81	76	87	76
query56	263	263	268	263
query57	1162	1171	1113	1113
query58	253	232	237	232
query59	2853	3070	2945	2945
query60	274	268	249	249
query61	115	113	113	113
query62	803	724	666	666
query63	224	191	185	185
query64	4151	1010	685	685
query65	3216	3158	3130	3130
query66	1094	438	330	330
query67	15924	15559	15576	15559
query68	2376	822	542	542
query69	411	310	282	282
query70	1184	1114	1133	1114
query71	312	299	261	261
query72	4972	3835	3771	3771
query73	629	743	364	364
query74	9744	8886	8952	8886
query75	3127	3156	2658	2658
query76	2211	1214	761	761
query77	337	359	280	280
query78	10138	10353	9347	9347
query79	997	888	598	598
query80	734	602	447	447
query81	511	267	232	232
query82	1231	159	126	126
query83	249	176	157	157
query84	240	92	77	77
query85	817	347	306	306
query86	344	319	302	302
query87	4373	4417	4362	4362
query88	3262	2232	2183	2183
query89	406	331	294	294
query90	1638	194	190	190
query91	134	143	109	109
query92	61	56	57	56
query93	929	859	536	536
query94	520	404	293	293
query95	332	268	256	256
query96	488	612	274	274
query97	2804	2865	2751	2751
query98	217	206	200	200
query99	1288	1415	1268	1268
Total cold run time: 273423 ms
Total hot run time: 184397 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 518d3307e8b03429c3449c21d91515816e537daa, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.25	0.07	0.06
query4	1.62	0.10	0.10
query5	0.41	0.42	0.39
query6	1.14	0.68	0.65
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.52	0.51
query10	0.56	0.56	0.56
query11	0.14	0.10	0.11
query12	0.13	0.10	0.12
query13	0.61	0.59	0.61
query14	2.72	2.85	2.85
query15	0.91	0.83	0.83
query16	0.39	0.38	0.38
query17	1.09	1.06	1.07
query18	0.24	0.22	0.21
query19	1.98	1.77	2.02
query20	0.02	0.01	0.01
query21	15.37	0.90	0.57
query22	0.76	1.02	0.66
query23	15.78	1.53	0.58
query24	2.62	0.73	2.26
query25	0.17	0.18	0.06
query26	0.25	0.15	0.13
query27	0.05	0.05	0.05
query28	14.19	0.97	0.43
query29	12.62	3.91	3.20
query30	0.25	0.09	0.06
query31	2.85	0.60	0.40
query32	3.23	0.54	0.46
query33	2.95	3.01	3.08
query34	16.65	5.16	4.52
query35	4.58	4.58	4.56
query36	0.64	0.50	0.48
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.41 s
Total hot run time: 30.49 s

zclllyybb
zclllyybb reviewed Jan 24, 2025
View reviewed changes
@koarz
Copy link
Contributor Author

koarz commented Jan 25, 2025

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.05% (10969/26083)
Line Coverage: 32.31% (92690/286839)
Region Coverage: 31.47% (47537/151055)
Branch Coverage: 27.51% (24079/87518)
Coverage Report: http://coverage.selectdb-in.cc/coverage/589606843828c8a7d376710ccd19e15f7dbe26b1_589606843828c8a7d376710ccd19e15f7dbe26b1/report/index.html

@koarz
Copy link
Contributor Author

koarz commented Jan 25, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32315 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b6d272bafb084c78f41416678ac70d5ac6a1aa0, data reload: false

------ Round 1 ----------------------------------
q1	17575	5485	5396	5396
q2	2058	299	166	166
q3	10617	1266	748	748
q4	10764	971	541	541
q5	9492	2391	2143	2143
q6	198	169	141	141
q7	898	763	627	627
q8	9240	1366	1218	1218
q9	5356	4737	4869	4737
q10	6822	2313	1881	1881
q11	488	291	258	258
q12	351	362	231	231
q13	17763	3675	3149	3149
q14	229	225	211	211
q15	527	461	469	461
q16	621	644	584	584
q17	570	864	329	329
q18	6928	6461	6430	6430
q19	1406	953	552	552
q20	319	329	194	194
q21	2874	2203	2018	2018
q22	361	345	300	300
Total cold run time: 105457 ms
Total hot run time: 32315 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5542	5488	5527	5488
q2	239	324	231	231
q3	2233	2610	2327	2327
q4	1415	1843	1362	1362
q5	4313	4732	4752	4732
q6	167	165	130	130
q7	2095	2011	1859	1859
q8	2644	2847	2741	2741
q9	7176	7197	7324	7197
q10	2994	3289	2794	2794
q11	567	505	491	491
q12	669	743	599	599
q13	3578	3970	3324	3324
q14	304	288	280	280
q15	517	505	471	471
q16	652	721	637	637
q17	1225	1754	1277	1277
q18	7651	7501	7200	7200
q19	811	1124	1066	1066
q20	2015	2025	1991	1991
q21	5901	5396	5086	5086
q22	606	613	559	559
Total cold run time: 53314 ms
Total hot run time: 51842 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.06% (10971/26083)
Line Coverage: 32.33% (92734/286839)
Region Coverage: 31.48% (47555/151055)
Branch Coverage: 27.52% (24082/87518)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b6d272bafb084c78f41416678ac70d5ac6a1aa0_6b6d272bafb084c78f41416678ac70d5ac6a1aa0/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 192714 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b6d272bafb084c78f41416678ac70d5ac6a1aa0, data reload: false

query1	1315	962	925	925
query2	6398	2026	1998	1998
query3	11011	4527	4559	4527
query4	60733	29542	23062	23062
query5	5542	593	459	459
query6	425	222	189	189
query7	5553	529	319	319
query8	345	246	242	242
query9	8344	2585	2593	2585
query10	460	318	256	256
query11	17811	15182	15521	15182
query12	171	118	110	110
query13	1482	572	425	425
query14	11327	7372	7558	7372
query15	217	220	203	203
query16	7430	630	464	464
query17	1124	752	615	615
query18	1903	421	315	315
query19	202	191	162	162
query20	119	121	114	114
query21	204	120	104	104
query22	4552	4669	4476	4476
query23	34128	33436	33665	33436
query24	5538	2356	2340	2340
query25	483	466	411	411
query26	651	298	159	159
query27	1541	496	351	351
query28	4462	2465	2442	2442
query29	551	559	432	432
query30	250	194	161	161
query31	927	879	838	838
query32	72	56	58	56
query33	448	357	312	312
query34	746	880	561	561
query35	820	884	787	787
query36	1005	1041	986	986
query37	129	108	79	79
query38	4401	4297	4243	4243
query39	1525	1426	1455	1426
query40	216	119	106	106
query41	51	50	47	47
query42	122	107	114	107
query43	538	558	503	503
query44	1498	825	821	821
query45	185	179	168	168
query46	921	1079	680	680
query47	1879	1917	1833	1833
query48	389	423	326	326
query49	699	512	411	411
query50	624	670	405	405
query51	4486	4380	4285	4285
query52	104	104	97	97
query53	248	280	201	201
query54	487	494	416	416
query55	81	82	83	82
query56	278	274	272	272
query57	1201	1248	1114	1114
query58	252	235	251	235
query59	3013	3216	3129	3129
query60	287	272	261	261
query61	141	138	166	138
query62	696	720	667	667
query63	234	193	192	192
query64	1262	1021	655	655
query65	3310	3215	3180	3180
query66	790	394	299	299
query67	15928	15643	15508	15508
query68	4233	855	532	532
query69	497	298	269	269
query70	1196	1137	1104	1104
query71	399	299	255	255
query72	5979	3925	3854	3854
query73	711	765	365	365
query74	9953	9011	8824	8824
query75	3273	3238	2726	2726
query76	3317	1191	794	794
query77	547	381	274	274
query78	10163	10019	9382	9382
query79	2525	825	622	622
query80	1638	546	439	439
query81	560	331	239	239
query82	343	160	118	118
query83	268	189	157	157
query84	290	93	74	74
query85	776	349	296	296
query86	463	321	307	307
query87	4535	4491	4398	4398
query88	3839	2191	2173	2173
query89	396	336	312	312
query90	1635	193	196	193
query91	137	144	106	106
query92	63	60	53	53
query93	2697	914	545	545
query94	753	411	300	300
query95	340	264	260	260
query96	483	615	277	277
query97	2737	2887	2736	2736
query98	219	195	199	195
query99	1255	1372	1273	1273
Total cold run time: 310485 ms
Total hot run time: 192714 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.85 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6b6d272bafb084c78f41416678ac70d5ac6a1aa0, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.05	0.05
query3	0.24	0.06	0.05
query4	1.64	0.08	0.09
query5	0.42	0.41	0.39
query6	1.16	0.67	0.65
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.55	0.49	0.49
query10	0.55	0.56	0.56
query11	0.18	0.12	0.12
query12	0.16	0.13	0.13
query13	0.62	0.60	0.61
query14	2.83	2.76	2.69
query15	0.91	0.84	0.83
query16	0.38	0.37	0.38
query17	1.06	1.06	1.07
query18	0.20	0.19	0.20
query19	1.98	1.82	1.98
query20	0.02	0.01	0.02
query21	15.36	0.98	0.66
query22	0.79	0.80	0.69
query23	14.97	1.48	0.68
query24	2.20	0.36	0.22
query25	0.15	0.09	0.09
query26	0.29	0.18	0.17
query27	0.08	0.08	0.08
query28	13.39	1.35	0.55
query29	12.63	4.16	3.40
query30	0.25	0.08	0.05
query31	2.84	0.64	0.41
query32	3.23	0.59	0.49
query33	2.98	3.01	3.09
query34	16.30	5.16	4.51
query35	4.59	4.56	4.61
query36	0.63	0.48	0.48
query37	0.19	0.17	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.06	0.05
query42	0.07	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 104.52 s
Total hot run time: 30.85 s

@koarz
Copy link
Contributor Author

koarz commented Jan 25, 2025

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.06% (10971/26083)
Line Coverage: 32.33% (92749/286839)
Region Coverage: 31.49% (47560/151055)
Branch Coverage: 27.52% (24082/87518)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f33fec591abf5ca166717f4f3e76c300724f0051_f33fec591abf5ca166717f4f3e76c300724f0051/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 32492 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f33fec591abf5ca166717f4f3e76c300724f0051, data reload: false

------ Round 1 ----------------------------------
q1	17833	5503	5372	5372
q2	2054	326	175	175
q3	10669	1231	754	754
q4	10301	983	561	561
q5	8951	2381	2178	2178
q6	199	177	137	137
q7	921	747	606	606
q8	9248	1368	1186	1186
q9	5155	4906	4955	4906
q10	6832	2342	1903	1903
q11	461	284	258	258
q12	349	357	224	224
q13	17770	3728	3096	3096
q14	245	218	215	215
q15	536	452	471	452
q16	639	602	589	589
q17	564	872	333	333
q18	7068	6452	6470	6452
q19	2259	949	550	550
q20	310	326	189	189
q21	2912	2192	2040	2040
q22	375	339	316	316
Total cold run time: 105651 ms
Total hot run time: 32492 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5571	5478	5467	5467
q2	236	332	237	237
q3	2218	2683	2359	2359
q4	1437	1833	1388	1388
q5	4275	4735	4787	4735
q6	179	167	132	132
q7	2074	2026	1815	1815
q8	2645	2851	2716	2716
q9	7354	7220	7269	7220
q10	2984	3308	2741	2741
q11	558	514	482	482
q12	648	728	612	612
q13	3602	3991	3279	3279
q14	283	301	279	279
q15	509	480	469	469
q16	679	703	631	631
q17	1231	1739	1296	1296
q18	7727	7383	7294	7294
q19	827	1141	1088	1088
q20	2000	2026	1891	1891
q21	5792	5286	5013	5013
q22	618	608	564	564
Total cold run time: 53447 ms
Total hot run time: 51708 ms

morrySnow
morrySnow reviewed May 27, 2025
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/types/TimeV2Type.java
@@ -49,6 +51,9 @@ public Type toCatalogDataType() {
* create TimeV2Type from scale
*/
public static TimeV2Type of(int scale) {
if (scale > MAX_SCALE || scale < 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should check scale in constructor too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the constructor is private TimeV2Type(int scale) private

@doris-robot
Copy link

TPC-H: Total hot run time: 33740 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 89c0c3ffe89bc2495222496d884f7f1cc4c7d757, data reload: false

------ Round 1 ----------------------------------
q1	26006	5093	4983	4983
q2	2076	290	197	197
q3	10512	1278	694	694
q4	10223	991	510	510
q5	7782	2415	2349	2349
q6	188	162	129	129
q7	904	737	602	602
q8	9335	1298	1099	1099
q9	6843	5059	5037	5037
q10	6868	2307	1899	1899
q11	509	282	266	266
q12	344	346	214	214
q13	17784	3708	3062	3062
q14	237	250	223	223
q15	538	486	499	486
q16	425	420	374	374
q17	612	862	357	357
q18	7659	7281	7134	7134
q19	2105	976	555	555
q20	326	340	223	223
q21	3703	3162	2352	2352
q22	1048	1016	995	995
Total cold run time: 116027 ms
Total hot run time: 33740 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5210	5422	5103	5103
q2	242	330	228	228
q3	2213	2663	2285	2285
q4	1407	1812	1426	1426
q5	4606	4479	4315	4315
q6	216	188	124	124
q7	1999	1963	1769	1769
q8	2575	2553	2527	2527
q9	7131	7018	7073	7018
q10	3018	3205	2770	2770
q11	572	504	505	504
q12	711	801	638	638
q13	3532	3827	3406	3406
q14	281	304	282	282
q15	525	512	471	471
q16	440	480	420	420
q17	1126	1498	1374	1374
q18	7870	7589	7457	7457
q19	803	843	982	843
q20	1946	2056	1835	1835
q21	4709	4303	4319	4303
q22	1064	1042	953	953
Total cold run time: 52196 ms
Total hot run time: 50051 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185588 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 89c0c3ffe89bc2495222496d884f7f1cc4c7d757, data reload: false

query1	1015	490	497	490
query2	6578	1914	1881	1881
query3	6750	220	219	219
query4	26798	23374	23289	23289
query5	4316	625	462	462
query6	324	222	199	199
query7	4625	497	295	295
query8	310	253	254	253
query9	8630	2611	2632	2611
query10	459	346	278	278
query11	15895	15026	14816	14816
query12	177	117	106	106
query13	1653	539	401	401
query14	9862	6181	6272	6181
query15	206	193	167	167
query16	7653	634	461	461
query17	1198	704	623	623
query18	1993	393	293	293
query19	185	186	155	155
query20	122	123	114	114
query21	208	131	106	106
query22	4016	4132	3965	3965
query23	34079	33165	32962	32962
query24	8407	2380	2358	2358
query25	527	455	384	384
query26	1232	272	150	150
query27	2715	497	333	333
query28	4317	2110	2104	2104
query29	743	567	435	435
query30	287	220	191	191
query31	948	856	791	791
query32	77	65	65	65
query33	545	368	305	305
query34	801	855	524	524
query35	795	790	742	742
query36	955	1008	877	877
query37	115	99	80	80
query38	4067	4034	4065	4034
query39	1453	1396	1398	1396
query40	217	124	110	110
query41	57	54	54	54
query42	129	109	108	108
query43	503	500	478	478
query44	1282	797	796	796
query45	174	168	164	164
query46	837	1023	629	629
query47	1774	1787	1730	1730
query48	383	409	312	312
query49	789	520	421	421
query50	649	707	402	402
query51	4116	4114	4132	4114
query52	114	108	96	96
query53	230	247	187	187
query54	582	575	507	507
query55	84	83	84	83
query56	302	302	281	281
query57	1137	1112	1107	1107
query58	263	258	280	258
query59	2659	2680	2639	2639
query60	332	319	309	309
query61	129	137	127	127
query62	816	750	647	647
query63	217	186	185	185
query64	4279	1011	694	694
query65	4342	4240	4219	4219
query66	1085	416	307	307
query67	15965	15695	15198	15198
query68	8632	891	579	579
query69	465	306	274	274
query70	1252	1119	1119	1119
query71	470	323	289	289
query72	5484	4636	4676	4636
query73	700	553	346	346
query74	9087	8788	9002	8788
query75	4110	3198	2697	2697
query76	3727	1187	755	755
query77	797	367	291	291
query78	9954	10235	9276	9276
query79	4560	817	560	560
query80	689	524	458	458
query81	481	249	228	228
query82	541	128	96	96
query83	292	251	240	240
query84	300	103	95	95
query85	771	357	360	357
query86	347	291	280	280
query87	4342	4451	4445	4445
query88	3104	2256	2249	2249
query89	445	327	291	291
query90	1953	209	203	203
query91	140	149	111	111
query92	76	62	60	60
query93	2453	946	573	573
query94	673	390	300	300
query95	378	300	289	289
query96	493	567	282	282
query97	2775	2776	2667	2667
query98	251	207	205	205
query99	1450	1404	1291	1291
Total cold run time: 279674 ms
Total hot run time: 185588 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 89c0c3ffe89bc2495222496d884f7f1cc4c7d757, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.20
query4	1.59	0.20	0.20
query5	0.43	0.42	0.42
query6	1.17	0.66	0.67
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.52	0.52
query10	0.57	0.57	0.56
query11	0.16	0.11	0.12
query12	0.14	0.12	0.11
query13	0.61	0.61	0.61
query14	0.78	0.82	0.81
query15	0.88	0.87	0.88
query16	0.39	0.39	0.39
query17	1.02	1.02	1.06
query18	0.22	0.21	0.22
query19	1.92	1.82	1.84
query20	0.01	0.01	0.01
query21	15.39	0.90	0.55
query22	0.75	1.26	0.74
query23	14.78	1.38	0.66
query24	7.66	1.02	0.36
query25	0.53	0.15	0.13
query26	0.61	0.16	0.14
query27	0.05	0.05	0.05
query28	9.38	0.87	0.45
query29	12.55	3.94	3.31
query30	0.25	0.08	0.06
query31	2.82	0.60	0.39
query32	3.23	0.55	0.47
query33	3.00	3.20	3.04
query34	15.83	5.15	4.52
query35	4.56	4.55	4.49
query36	0.68	0.52	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.5 s
Total hot run time: 28.84 s

924060929
924060929 reviewed May 27, 2025
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/analysis/TimeV2Literal.java Outdated
this.negative = false;
}

public TimeV2Literal(double value) throws AnalysisException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long is more reasonable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time type data is always converted to double type operation in be, I think it's more standardized to use double here？

@koarz
Copy link
Contributor Author

koarz commented May 28, 2025

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.17% (18676/28224)
Region Coverage 65.79% (9262/14079)
Branch Coverage 55.62% (4987/8966)

@doris-robot
Copy link

TPC-H: Total hot run time: 33782 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84, data reload: false

------ Round 1 ----------------------------------
q1	26366	5093	5005	5005
q2	2100	286	192	192
q3	10599	1286	698	698
q4	10232	1010	507	507
q5	7876	2429	2345	2345
q6	184	163	135	135
q7	883	718	613	613
q8	9325	1283	1083	1083
q9	6823	5084	5115	5084
q10	6871	2346	1883	1883
q11	503	294	273	273
q12	340	357	208	208
q13	17787	3690	3088	3088
q14	239	231	221	221
q15	557	499	520	499
q16	418	426	382	382
q17	594	875	373	373
q18	7693	7269	7086	7086
q19	1573	962	549	549
q20	335	338	220	220
q21	3849	3185	2388	2388
q22	997	1018	950	950
Total cold run time: 116144 ms
Total hot run time: 33782 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5213	5117	5114	5114
q2	241	330	232	232
q3	2128	2627	2334	2334
q4	1323	1769	1376	1376
q5	4544	4451	4404	4404
q6	222	175	129	129
q7	2008	1943	1759	1759
q8	2580	2482	2451	2451
q9	7196	7182	7270	7182
q10	2965	3153	2735	2735
q11	583	505	481	481
q12	680	792	580	580
q13	3459	3902	3210	3210
q14	268	297	283	283
q15	541	511	506	506
q16	435	481	439	439
q17	1147	1501	1405	1405
q18	7792	7494	7288	7288
q19	808	806	917	806
q20	1945	2033	1894	1894
q21	4892	4423	4173	4173
q22	1084	1003	959	959
Total cold run time: 52054 ms
Total hot run time: 49740 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185828 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84, data reload: false

query1	1023	477	499	477
query2	6611	1809	1784	1784
query3	6743	231	236	231
query4	26457	24211	23604	23604
query5	4787	618	442	442
query6	299	196	183	183
query7	4631	499	282	282
query8	272	228	216	216
query9	8631	2602	2594	2594
query10	491	349	271	271
query11	15857	15037	14805	14805
query12	157	110	106	106
query13	1648	531	437	437
query14	9246	5964	6088	5964
query15	207	184	170	170
query16	7221	618	496	496
query17	1128	701	568	568
query18	2001	411	292	292
query19	189	177	161	161
query20	124	121	160	121
query21	207	126	108	108
query22	4207	4279	4076	4076
query23	33957	33059	33073	33059
query24	8386	2389	2386	2386
query25	546	458	394	394
query26	1242	270	152	152
query27	2761	489	341	341
query28	4338	2126	2108	2108
query29	767	585	481	481
query30	288	221	187	187
query31	975	846	750	750
query32	77	65	72	65
query33	576	375	335	335
query34	801	863	562	562
query35	783	835	744	744
query36	938	981	851	851
query37	112	104	79	79
query38	4120	4097	4139	4097
query39	1489	1420	1457	1420
query40	216	127	116	116
query41	103	56	58	56
query42	129	106	106	106
query43	486	487	448	448
query44	1310	827	820	820
query45	176	174	165	165
query46	839	1019	637	637
query47	1724	1780	1717	1717
query48	393	426	317	317
query49	769	496	406	406
query50	667	686	407	407
query51	4087	4122	4081	4081
query52	109	108	99	99
query53	229	256	182	182
query54	634	583	502	502
query55	81	85	83	83
query56	305	292	284	284
query57	1126	1146	1069	1069
query58	257	261	252	252
query59	2629	2592	2535	2535
query60	330	339	304	304
query61	124	119	123	119
query62	789	715	673	673
query63	222	193	188	188
query64	4365	1038	696	696
query65	4297	4229	4281	4229
query66	1143	402	314	314
query67	15728	15445	15321	15321
query68	7745	899	528	528
query69	496	324	288	288
query70	1208	1124	1066	1066
query71	429	333	308	308
query72	5916	4825	4817	4817
query73	703	678	362	362
query74	8905	8987	8706	8706
query75	3385	3169	2691	2691
query76	3246	1174	754	754
query77	606	384	297	297
query78	10033	10251	9362	9362
query79	2123	795	592	592
query80	684	498	439	439
query81	486	250	224	224
query82	450	127	94	94
query83	293	248	234	234
query84	295	110	88	88
query85	779	350	311	311
query86	387	304	288	288
query87	4368	4383	4313	4313
query88	3771	2296	2297	2296
query89	398	308	288	288
query90	1983	223	213	213
query91	142	149	113	113
query92	81	62	63	62
query93	1778	945	579	579
query94	708	402	313	313
query95	377	302	287	287
query96	496	567	281	281
query97	2689	2762	2637	2637
query98	235	214	203	203
query99	1421	1411	1269	1269
Total cold run time: 274176 ms
Total hot run time: 185828 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.56 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b4497029fb5e5f88b6d4f2d5cddae5a24e5e9d84, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.12
query3	0.25	0.21	0.20
query4	1.59	0.21	0.11
query5	0.43	0.44	0.42
query6	1.17	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.60	0.51	0.50
query10	0.57	0.58	0.56
query11	0.16	0.10	0.11
query12	0.15	0.12	0.12
query13	0.62	0.59	0.59
query14	0.78	0.81	0.81
query15	0.86	0.87	0.85
query16	0.37	0.38	0.37
query17	1.03	1.03	1.04
query18	0.22	0.21	0.21
query19	1.92	1.81	1.89
query20	0.02	0.01	0.02
query21	15.41	0.92	0.54
query22	0.75	1.18	0.73
query23	14.84	1.37	0.59
query24	6.70	2.07	0.47
query25	0.44	0.21	0.07
query26	0.63	0.16	0.15
query27	0.06	0.05	0.04
query28	9.98	0.88	0.44
query29	12.55	3.94	3.28
query30	0.25	0.09	0.06
query31	2.83	0.59	0.38
query32	3.23	0.55	0.48
query33	2.98	3.06	3.09
query34	15.69	5.16	4.44
query35	4.54	4.50	4.46
query36	0.68	0.49	0.49
query37	0.09	0.06	0.06
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.06 s
Total hot run time: 28.56 s

@koarz
Copy link
Contributor Author

koarz commented May 29, 2025

run buildall

@koarz
Copy link
Contributor Author

koarz commented May 29, 2025

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.26% (1114/1338)
Line Coverage 66.48% (18806/28287)
Region Coverage 66.12% (9321/14098)
Branch Coverage 56.06% (5032/8976)

@koarz
Copy link
Contributor Author

koarz commented May 30, 2025

run p0

@koarz
Copy link
Contributor Author

koarz commented May 30, 2025

run performance

@koarz
Copy link
Contributor Author

koarz commented May 30, 2025

run external

1 similar comment
@koarz
Copy link
Contributor Author

koarz commented May 30, 2025

run external

@doris-robot
Copy link

TPC-H: Total hot run time: 33932 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 26662bd1038e97dc7dab3cfca26a1e0a73b7016b, data reload: false

------ Round 1 ----------------------------------
q1	26501	5112	5294	5112
q2	1967	295	184	184
q3	10398	1263	721	721
q4	10229	1003	555	555
q5	7659	2386	2302	2302
q6	184	165	133	133
q7	912	751	635	635
q8	9311	1291	1105	1105
q9	6743	5110	5041	5041
q10	6877	2317	1888	1888
q11	491	289	274	274
q12	356	362	227	227
q13	17785	3691	3072	3072
q14	245	233	225	225
q15	559	501	484	484
q16	433	443	377	377
q17	594	865	364	364
q18	7805	7249	7068	7068
q19	1695	980	573	573
q20	334	342	218	218
q21	3849	2544	2395	2395
q22	1069	1042	979	979
Total cold run time: 115996 ms
Total hot run time: 33932 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5235	5132	5173	5132
q2	237	332	220	220
q3	2198	2678	2283	2283
q4	1359	1845	1431	1431
q5	4431	4411	4386	4386
q6	219	166	133	133
q7	2017	1971	1769	1769
q8	2594	2680	2603	2603
q9	7250	7033	7259	7033
q10	3039	3163	2766	2766
q11	593	528	502	502
q12	671	767	598	598
q13	3521	3890	3384	3384
q14	279	310	266	266
q15	519	489	489	489
q16	464	496	450	450
q17	1173	1529	1406	1406
q18	7793	7594	7465	7465
q19	846	855	913	855
q20	1926	2030	1896	1896
q21	4913	4562	4435	4435
q22	1081	1071	1047	1047
Total cold run time: 52358 ms
Total hot run time: 50549 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192845 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 26662bd1038e97dc7dab3cfca26a1e0a73b7016b, data reload: false

query1	1388	1086	1044	1044
query2	6383	1817	1779	1779
query3	11051	4431	4626	4431
query4	52242	25526	23299	23299
query5	5098	578	463	463
query6	336	216	206	206
query7	4896	510	302	302
query8	289	233	221	221
query9	5733	2670	2677	2670
query10	450	330	275	275
query11	15018	15128	14809	14809
query12	160	108	111	108
query13	1053	534	418	418
query14	9982	6390	6391	6390
query15	206	207	170	170
query16	7047	650	504	504
query17	1100	776	557	557
query18	1570	401	320	320
query19	212	189	174	174
query20	136	129	127	127
query21	204	126	113	113
query22	4441	4383	4348	4348
query23	34365	33683	33686	33683
query24	6631	2460	2481	2460
query25	483	471	406	406
query26	730	276	160	160
query27	2343	530	339	339
query28	3134	2194	2190	2190
query29	583	575	428	428
query30	284	238	198	198
query31	859	839	765	765
query32	71	59	66	59
query33	437	380	326	326
query34	798	844	525	525
query35	824	860	765	765
query36	955	994	906	906
query37	111	103	82	82
query38	4247	4188	4245	4188
query39	1525	1488	1505	1488
query40	214	124	119	119
query41	67	58	58	58
query42	129	114	111	111
query43	502	496	475	475
query44	1366	870	848	848
query45	183	172	169	169
query46	851	1025	652	652
query47	1883	1887	1786	1786
query48	400	423	311	311
query49	654	489	410	410
query50	667	700	421	421
query51	4261	4247	4281	4247
query52	118	115	108	108
query53	233	267	185	185
query54	606	591	514	514
query55	89	91	85	85
query56	334	294	300	294
query57	1195	1229	1152	1152
query58	274	275	266	266
query59	2656	2772	2644	2644
query60	320	323	322	322
query61	132	128	137	128
query62	748	746	704	704
query63	230	203	203	203
query64	1824	1012	666	666
query65	4233	4143	4141	4141
query66	718	397	297	297
query67	15820	15678	15451	15451
query68	6805	892	529	529
query69	546	296	259	259
query70	1244	1118	1058	1058
query71	502	331	307	307
query72	6041	4886	4959	4886
query73	1487	686	366	366
query74	9254	8840	8738	8738
query75	4008	3228	2773	2773
query76	4270	1191	738	738
query77	695	396	294	294
query78	10168	10229	9319	9319
query79	2632	813	588	588
query80	573	510	446	446
query81	498	260	218	218
query82	442	123	100	100
query83	314	255	242	242
query84	292	100	93	93
query85	810	346	312	312
query86	362	319	278	278
query87	4375	4407	4347	4347
query88	3671	2302	2300	2300
query89	407	313	287	287
query90	1822	206	206	206
query91	139	138	110	110
query92	74	58	59	58
query93	2168	919	584	584
query94	677	409	306	306
query95	359	291	291	291
query96	504	564	281	281
query97	2734	2776	2616	2616
query98	226	205	201	201
query99	1478	1377	1251	1251
Total cold run time: 297659 ms
Total hot run time: 192845 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.71 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 26662bd1038e97dc7dab3cfca26a1e0a73b7016b, data reload: false

query1	0.04	0.04	0.03
query2	0.15	0.11	0.11
query3	0.35	0.20	0.20
query4	1.59	0.21	0.21
query5	0.46	0.45	0.45
query6	1.17	0.65	0.68
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.61	0.52	0.52
query10	0.57	0.57	0.57
query11	0.25	0.12	0.13
query12	0.28	0.14	0.14
query13	0.63	0.62	0.62
query14	0.80	0.81	0.82
query15	0.95	0.88	0.88
query16	0.38	0.37	0.37
query17	1.02	1.01	1.04
query18	0.20	0.18	0.18
query19	1.92	1.77	1.79
query20	0.02	0.01	0.01
query21	15.42	0.98	0.66
query22	0.92	1.03	0.85
query23	14.69	1.46	0.76
query24	5.51	0.54	0.27
query25	0.17	0.10	0.09
query26	0.56	0.21	0.18
query27	0.09	0.09	0.08
query28	11.02	1.18	0.57
query29	12.55	4.00	3.44
query30	0.28	0.09	0.07
query31	2.80	0.62	0.43
query32	3.24	0.58	0.52
query33	3.05	3.10	3.07
query34	16.22	5.17	4.42
query35	4.46	4.52	4.44
query36	0.63	0.50	0.50
query37	0.19	0.17	0.17
query38	0.16	0.15	0.16
query39	0.05	0.04	0.04
query40	0.19	0.17	0.16
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 103.87 s
Total hot run time: 29.71 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2025

PR approved by at least one committer and no changes requested.

zclllyybb
zclllyybb approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zclllyybb zclllyybb merged commit 14b15b4 into apache:master Jun 3, 2025
25 of 27 checks passed
@koarz koarz deleted the 20250117 branch June 4, 2025 03:11
koarz added a commit to koarz/doris that referenced this pull request Jun 4, 2025
@koarz
[Feature](literal)Support TimeV2Literal (apache#47319)
e8a6089 
```sql
explain select cast('12:30:30' as time);

before:

 PLAN FRAGMENT 0                   
   OUTPUT EXPRS:                   
     cast('12:30:30' as time)[#0]  
   PARTITION: UNPARTITIONED        
                                   
   HAS_COLO_PLAN_NODE: false       
                                   
   VRESULT SINK                    
      MYSQL_PROTOCAL               
                                   
   0:VUNION(28)                    
      constant exprs:              
          CAST('12:30:30' AS time) 

after:

PLAN FRAGMENT 0
  OUTPUT EXPRS:
    12:30:30[#0]
  PARTITION: UNPARTITIONED

  HAS_COLO_PLAN_NODE: false

  VRESULT SINK
     MYSQL_PROTOCAL

  0:VUNION(30)
     constant exprs: 
         "12:30:30"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow left review comments

@924060929 924060929 924060929 approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

@BiteTheDDDDt BiteTheDDDDt Awaiting requested review from BiteTheDDDDt

Assignees

@morrySnow morrySnow

Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@koarz @hello-stephen @doris-robot @zclllyybb @BiteTheDDDDt @924060929 @morrySnow