-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Prepared Statment) Fix exec prepared insert stmt in non master error #48689
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
594e881
to
bf60474
Compare
run buildall |
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32623 ms
|
TPC-DS: Total hot run time: 185542 ms
|
ClickBench: Total hot run time: 30.67 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bf60474
to
0890506
Compare
run buildall |
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32943 ms
|
TPC-DS: Total hot run time: 192046 ms
|
ClickBench: Total hot run time: 31.41 s
|
I test this pr, and it works well in my cluster. |
run beut |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add test case? example pick none master frontend and send insert/delete/update prepared requests
The pipeline doris cluster has only one FE. |
902b363
to
c5cbffc
Compare
run buildall |
run buildall |
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32328 ms
|
TPC-DS: Total hot run time: 192806 ms
|
ClickBench: Total hot run time: 31.78 s
|
run beut |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
…error (#48740) ### What problem does this PR solve? bp #48689 for 2.1 Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> --------- Co-authored-by: lucianljliu <[email protected]> Co-authored-by: liulijia <[email protected]>
What problem does this PR solve?
When client send a prepare command to non master frontend like
INSERT INTO xxxx VALUES(?)
and then execute it whith some params.The non master frontend will forward the origin stmt to master and analyze error will occur.
In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)