[Enhancement](paimon)support native read paimon top level schema change table. #48723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32681 ms |
TPC-DS: Total hot run time: 192362 ms |
ClickBench: Total hot run time: 31.4 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32633 ms |
TPC-DS: Total hot run time: 192050 ms |
ClickBench: Total hot run time: 31.36 s |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32645 ms |
TPC-DS: Total hot run time: 184942 ms |
ClickBench: Total hot run time: 30.6 s |
|
run buildall |
|
TeamCity cloud ut coverage result: |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
reviewed
Mar 12, 2025
| @@ -38,6 +38,134 @@ PaimonReader::PaimonReader(std::unique_ptr<GenericReader> file_format_reader, | |||
| ADD_CHILD_TIMER(_profile, "DeleteFileReadTime", paimon_profile); | |||
| } | |||
|
|
|||
| /** | |||
| sql: | |||
|
|
||
| public class PaimonSchemaCacheValue extends SchemaCacheValue { | ||
|
|
||
| private List<Column> partitionColumns; | ||
|
|
||
| public PaimonSchemaCacheValue(List<Column> schema, List<Column> partitionColumns) { | ||
| private TableSchema tableSchema; |
There was a problem hiding this comment.
Looks like we only use this TableSchema to build columnIdToName, no need to store it.
| @@ -154,6 +155,11 @@ protected Optional<String> getSerializedTable() { | |||
| return Optional.of(serializedTable); | |||
| } | |||
|
|
|||
| Map<Long, String> getSchemaInfo(Long schemaId) { | |||
There was a problem hiding this comment.
Suggested change
| Map<Long, String> getSchemaInfo(Long schemaId) { | |
| private Map<Long, String> getSchemaInfo(Long schemaId) { |
| @@ -1273,7 +1273,7 @@ Status FileScanner::_init_expr_ctxes() { | |||
| if (slot_info.is_file_slot) { | |||
| _file_slot_descs.emplace_back(it->second); | |||
| _file_col_names.push_back(it->second->col_name()); | |||
| if (it->second->col_unique_id() > 0) { | |||
| if (it->second->col_unique_id() >= 0) { | |||
There was a problem hiding this comment.
No, iceberg's field unique ID starts from 1, paimon/hudi field unique ID starts from 0.
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32806 ms |
TPC-DS: Total hot run time: 192295 ms |
ClickBench: Total hot run time: 31.35 s |
morningman
approved these changes
Mar 14, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
hubgeter
changed the title
16 tasks
wuwenchi
approved these changes
Mar 15, 2025
morningman
pushed a commit
that referenced
this pull request
Mar 21, 2025
…able. (#49051) ### What problem does this PR solve? Similar to pr #48723 Problem Summary: 1. Supports native reader reading tables after the top-level schema of hudi is changed, but does not support tables after the internal schema of struct is changed. change internal schema of struct schema(not support, will support in the next PR). 2. Unify the logic of iceberg/paimon/hudi native reader to handle schema change's table.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ge table. (apache#48723) ### What problem does this PR solve? Problem Summary: Supports native reader reading tables after the top-level schema of paimon is changed, but does not support tables after the internal schema of struct is changed. change top-level schema(support): ```sql --spark sql ALTER TABLE table_name ADD COLUMNS (c1 INT,c2 STRING); ALTER TABLE table_name RENAME COLUMN c0 TO c1; ALTER TABLE table_name DROP COLUMNS (c1, c2); ALTER TABLE table_name ADD COLUMN c INT FIRST; ALTER TABLE table_name ADD COLUMN c INT AFTER b; ALTER TABLE table_name ALTER COLUMN col_a FIRST; ALTER TABLE table_name ALTER COLUMN col_a AFTER col_b; ``` change internal schema of struct schema(not support, will support in the next PR): ```sql --spark sql ALTER TABLE table_name ADD COLUMN v.value.f3 STRING; ALTER TABLE table_name RENAME COLUMN v.f1 to f100; ALTER TABLE table_name DROP COLUMN v.value.f3 ; ALTER TABLE table_name ALTER COLUMN v.col_a FIRST; ```
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…able. (apache#49051) ### What problem does this PR solve? Similar to pr apache#48723 Problem Summary: 1. Supports native reader reading tables after the top-level schema of hudi is changed, but does not support tables after the internal schema of struct is changed. change internal schema of struct schema(not support, will support in the next PR). 2. Unify the logic of iceberg/paimon/hudi native reader to handle schema change's table.
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Jun 24, 2025
…ge table. (apache#48723) ### What problem does this PR solve? Problem Summary: Supports native reader reading tables after the top-level schema of paimon is changed, but does not support tables after the internal schema of struct is changed. change top-level schema(support): ```sql --spark sql ALTER TABLE table_name ADD COLUMNS (c1 INT,c2 STRING); ALTER TABLE table_name RENAME COLUMN c0 TO c1; ALTER TABLE table_name DROP COLUMNS (c1, c2); ALTER TABLE table_name ADD COLUMN c INT FIRST; ALTER TABLE table_name ADD COLUMN c INT AFTER b; ALTER TABLE table_name ALTER COLUMN col_a FIRST; ALTER TABLE table_name ALTER COLUMN col_a AFTER col_b; ``` change internal schema of struct schema(not support, will support in the next PR): ```sql --spark sql ALTER TABLE table_name ADD COLUMN v.value.f3 STRING; ALTER TABLE table_name RENAME COLUMN v.f1 to f100; ALTER TABLE table_name DROP COLUMN v.value.f3 ; ALTER TABLE table_name ALTER COLUMN v.col_a FIRST; ```
Merged
16 tasks
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Jun 24, 2025
…ge table. (apache#48723) ### What problem does this PR solve? Problem Summary: Supports native reader reading tables after the top-level schema of paimon is changed, but does not support tables after the internal schema of struct is changed. change top-level schema(support): ```sql --spark sql ALTER TABLE table_name ADD COLUMNS (c1 INT,c2 STRING); ALTER TABLE table_name RENAME COLUMN c0 TO c1; ALTER TABLE table_name DROP COLUMNS (c1, c2); ALTER TABLE table_name ADD COLUMN c INT FIRST; ALTER TABLE table_name ADD COLUMN c INT AFTER b; ALTER TABLE table_name ALTER COLUMN col_a FIRST; ALTER TABLE table_name ALTER COLUMN col_a AFTER col_b; ``` change internal schema of struct schema(not support, will support in the next PR): ```sql --spark sql ALTER TABLE table_name ADD COLUMN v.value.f3 STRING; ALTER TABLE table_name RENAME COLUMN v.f1 to f100; ALTER TABLE table_name DROP COLUMN v.value.f3 ; ALTER TABLE table_name ALTER COLUMN v.col_a FIRST; ```
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Jun 27, 2025
…ge table. (apache#48723) Problem Summary: Supports native reader reading tables after the top-level schema of paimon is changed, but does not support tables after the internal schema of struct is changed. change top-level schema(support): ```sql --spark sql ALTER TABLE table_name ADD COLUMNS (c1 INT,c2 STRING); ALTER TABLE table_name RENAME COLUMN c0 TO c1; ALTER TABLE table_name DROP COLUMNS (c1, c2); ALTER TABLE table_name ADD COLUMN c INT FIRST; ALTER TABLE table_name ADD COLUMN c INT AFTER b; ALTER TABLE table_name ALTER COLUMN col_a FIRST; ALTER TABLE table_name ALTER COLUMN col_a AFTER col_b; ``` change internal schema of struct schema(not support, will support in the next PR): ```sql --spark sql ALTER TABLE table_name ADD COLUMN v.value.f3 STRING; ALTER TABLE table_name RENAME COLUMN v.f1 to f100; ALTER TABLE table_name DROP COLUMN v.value.f3 ; ALTER TABLE table_name ALTER COLUMN v.col_a FIRST; ```
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Jun 27, 2025
…ge table. (apache#48723) Problem Summary: Supports native reader reading tables after the top-level schema of paimon is changed, but does not support tables after the internal schema of struct is changed. change top-level schema(support): ```sql --spark sql ALTER TABLE table_name ADD COLUMNS (c1 INT,c2 STRING); ALTER TABLE table_name RENAME COLUMN c0 TO c1; ALTER TABLE table_name DROP COLUMNS (c1, c2); ALTER TABLE table_name ADD COLUMN c INT FIRST; ALTER TABLE table_name ADD COLUMN c INT AFTER b; ALTER TABLE table_name ALTER COLUMN col_a FIRST; ALTER TABLE table_name ALTER COLUMN col_a AFTER col_b; ``` change internal schema of struct schema(not support, will support in the next PR): ```sql --spark sql ALTER TABLE table_name ADD COLUMN v.value.f3 STRING; ALTER TABLE table_name RENAME COLUMN v.f1 to f100; ALTER TABLE table_name DROP COLUMN v.value.f3 ; ALTER TABLE table_name ALTER COLUMN v.col_a FIRST; ```
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Jun 28, 2025
…able. (apache#49051) Similar to pr apache#48723 Problem Summary: 1. Supports native reader reading tables after the top-level schema of hudi is changed, but does not support tables after the internal schema of struct is changed. change internal schema of struct schema(not support, will support in the next PR). 2. Unify the logic of iceberg/paimon/hudi native reader to handle schema change's table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Supports native reader reading tables after the top-level schema of paimon is changed, but does not support tables after the internal schema of struct is changed.
change top-level schema(support):
change internal schema of struct schema(not support, will support in the next PR):
Release note
Supports native reader reading tables after the top-level schema of paimon is changed.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)