Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor](Nereids) rename MAX_MIN_FILTER_PUSH_DOWN to PUSH_DOWN_MAX_MIN_FILTER #48840

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiedeyantu
Copy link
Contributor

What problem does this PR solve?

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xiedeyantu
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32678 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5480654e23720d393b51ebcaf9c6ddda3c3a7bb7, data reload: false

------ Round 1 ----------------------------------
q1	17594	5229	5113	5113
q2	2041	290	168	168
q3	10621	1259	753	753
q4	10216	1049	557	557
q5	7563	2426	2320	2320
q6	194	175	137	137
q7	902	756	608	608
q8	9304	1295	1113	1113
q9	4904	4679	4805	4679
q10	6885	2316	1908	1908
q11	482	271	248	248
q12	345	351	229	229
q13	17764	3650	3155	3155
q14	227	227	205	205
q15	522	494	483	483
q16	664	611	580	580
q17	565	851	349	349
q18	7114	6439	6417	6417
q19	1520	949	541	541
q20	325	331	190	190
q21	2778	2203	1950	1950
q22	1077	1009	975	975
Total cold run time: 103607 ms
Total hot run time: 32678 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5233	5179	5143	5143
q2	234	329	228	228
q3	2143	2644	2284	2284
q4	1470	1838	1372	1372
q5	4257	4113	4134	4113
q6	207	161	127	127
q7	1898	1930	1776	1776
q8	2688	2783	2655	2655
q9	7416	7421	7423	7421
q10	3087	3308	2777	2777
q11	575	519	518	518
q12	688	729	596	596
q13	3498	3922	3332	3332
q14	275	313	271	271
q15	545	512	491	491
q16	678	687	659	659
q17	1169	1617	1379	1379
q18	7761	7657	7616	7616
q19	821	784	899	784
q20	1970	2009	1896	1896
q21	5565	4873	4799	4799
q22	1103	1058	1051	1051
Total cold run time: 53281 ms
Total hot run time: 51288 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192759 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5480654e23720d393b51ebcaf9c6ddda3c3a7bb7, data reload: false

query1	1352	1000	1015	1000
query2	6341	1862	1897	1862
query3	11151	4528	4614	4528
query4	55217	25729	23922	23922
query5	5203	565	479	479
query6	343	199	199	199
query7	4879	521	302	302
query8	319	248	236	236
query9	5698	2522	2561	2522
query10	408	296	277	277
query11	15184	15157	14882	14882
query12	158	104	108	104
query13	1039	485	382	382
query14	10188	6397	6899	6397
query15	217	195	175	175
query16	7105	663	519	519
query17	1107	731	576	576
query18	1555	404	310	310
query19	205	187	155	155
query20	123	123	119	119
query21	203	125	111	111
query22	4573	4915	4551	4551
query23	33940	33611	33412	33412
query24	5771	2442	2450	2442
query25	463	470	391	391
query26	701	287	162	162
query27	1832	507	335	335
query28	2734	2437	2467	2437
query29	601	603	469	469
query30	276	245	187	187
query31	890	867	782	782
query32	67	60	59	59
query33	452	346	318	318
query34	757	866	508	508
query35	792	824	779	779
query36	945	994	915	915
query37	123	96	74	74
query38	4182	4198	4191	4191
query39	1475	1428	1444	1428
query40	197	118	104	104
query41	52	52	53	52
query42	125	107	102	102
query43	500	500	484	484
query44	1351	821	805	805
query45	173	171	163	163
query46	847	1033	633	633
query47	1900	1936	1863	1863
query48	375	423	315	315
query49	680	523	442	442
query50	696	758	414	414
query51	4303	4307	4244	4244
query52	111	103	96	96
query53	233	264	190	190
query54	485	502	421	421
query55	84	80	83	80
query56	253	263	250	250
query57	1181	1216	1149	1149
query58	259	237	238	237
query59	2699	2804	2713	2713
query60	305	289	280	280
query61	151	136	136	136
query62	741	761	693	693
query63	233	193	185	185
query64	1596	1096	778	778
query65	4544	4433	4537	4433
query66	773	410	302	302
query67	16180	15552	15333	15333
query68	7146	869	502	502
query69	541	294	268	268
query70	1214	1145	1097	1097
query71	478	291	265	265
query72	5739	3576	3783	3576
query73	1491	738	349	349
query74	9287	9099	8750	8750
query75	3730	3145	2716	2716
query76	4166	1185	748	748
query77	613	386	277	277
query78	10087	10136	9216	9216
query79	2740	831	587	587
query80	725	518	447	447
query81	490	265	221	221
query82	618	125	92	92
query83	283	166	154	154
query84	283	91	76	76
query85	785	353	304	304
query86	365	296	278	278
query87	4574	4570	4398	4398
query88	3472	2217	2160	2160
query89	409	309	282	282
query90	1891	205	205	205
query91	139	141	116	116
query92	70	60	57	57
query93	1502	1048	592	592
query94	662	420	305	305
query95	340	263	255	255
query96	482	558	269	269
query97	3360	3530	3326	3326
query98	239	203	195	195
query99	1457	1422	1282	1282
Total cold run time: 298974 ms
Total hot run time: 192759 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.24 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5480654e23720d393b51ebcaf9c6ddda3c3a7bb7, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.61	0.10	0.11
query5	0.56	0.54	0.55
query6	1.20	0.71	0.71
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.52
query10	0.58	0.64	0.58
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.62	0.60
query14	2.73	2.87	2.69
query15	0.93	0.86	0.85
query16	0.36	0.36	0.37
query17	1.03	1.06	1.05
query18	0.20	0.20	0.19
query19	1.94	1.79	2.00
query20	0.01	0.01	0.02
query21	15.35	0.92	0.54
query22	0.76	1.28	0.69
query23	14.87	1.36	0.66
query24	6.77	2.28	1.13
query25	0.54	0.27	0.22
query26	0.59	0.15	0.14
query27	0.05	0.05	0.05
query28	9.98	0.85	0.42
query29	12.55	3.96	3.27
query30	0.25	0.09	0.06
query31	2.82	0.59	0.39
query32	3.23	0.55	0.47
query33	2.99	2.96	3.03
query34	15.76	5.16	4.55
query35	4.53	4.57	4.54
query36	0.65	0.51	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.25 s
Total hot run time: 31.24 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants