Skip to content

branch-4.1: [fix](exec) Return Thrift DATETIME as naive Arrow timestamp #67232 - #67299

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-67232-branch-4.1
Aug 29, 2026
Merged

branch-4.1: [fix](exec) Return Thrift DATETIME as naive Arrow timestamp #67232#67299
yiguolei merged 1 commit into
branch-4.1from
auto-pick-67232-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #67232

Thrift external scanner responses encoded Doris `DATETIME` values with
the BE session timezone in the Arrow schema. This made clients interpret
wall-clock values as instants and could introduce an eight-hour offset.
The MemoryScratch sink now uses the existing naive-timestamp conversion
for `DATETIMEV2`, while preserving timezone-aware `TIMESTAMPTZ`
behavior.

### Release note

`DATETIME` values returned through the Thrift external scanner are
represented as timezone-naive Arrow timestamps.

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions
github-actions Bot requested a review from yiguolei as a code owner August 28, 2026 13:12
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.13% (31187/42072)
Line Coverage 58.28% (345511/592835)
Region Coverage 54.96% (287369/522826)
Branch Coverage 55.93% (129544/231621)

@yiguolei
yiguolei merged commit 790e320 into branch-4.1 Aug 29, 2026
30 of 32 checks passed
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants