Update unit tests

Author: cgivre

contrib/storage-sentinel/src/test/java/org/apache/drill/exec/store/sentinel/TestSentinelBatchReader.java

@@ -22,12 +22,13 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.junit.Test;
 
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
 
 public class TestSentinelBatchReader {
-  private ObjectMapper mapper = new ObjectMapper();
+  private final ObjectMapper mapper = new ObjectMapper();
 
   @Test
   public void testParseSimpleSecurityAlertResponse() throws Exception {
@@ -67,15 +68,29 @@ public void testParseSimpleSecurityAlertResponse() throws Exception {
     assertEquals("AlertName", firstColumn.get("name").asText());
     assertEquals("string", firstColumn.get("type").asText());
 
+    // Verify column order
+    assertEquals("AlertName", columns.get(0).get("name").asText());
+    assertEquals("Severity", columns.get(1).get("name").asText());
+    assertEquals("Count", columns.get(2).get("name").asText());
+    assertEquals("Active", columns.get(3).get("name").asText());
+
+    // Verify first row data
     JsonNode firstRow = rows.get(0);
     assertEquals("Alert1", firstRow.get(0).asText());
     assertEquals("High", firstRow.get(1).asText());
     assertEquals(5, firstRow.get(2).asLong());
     assertTrue(firstRow.get(3).asBoolean());
+
+    // Verify second row data
+    JsonNode secondRow = rows.get(1);
+    assertEquals("Alert2", secondRow.get(0).asText());
+    assertEquals("Medium", secondRow.get(1).asText());
+    assertEquals(3, secondRow.get(2).asLong());
+    assertFalse(secondRow.get(3).asBoolean());
   }
 
   @Test
-  public void testParseTypeMappings() throws Exception {
+  public void testParseAllKqlTypeMappings() throws Exception {
     String jsonResponse = "{\n" +
         "  \"tables\": [\n" +
         "    {\n" +
@@ -97,10 +112,22 @@ public void testParseTypeMappings() throws Exception {
     JsonNode root = mapper.readTree(jsonResponse);
     JsonNode columns = root.get("tables").get(0).get("columns");
 
+    String[] expectedNames = {"StringCol", "IntCol", "LongCol", "RealCol", "BoolCol", "DatetimeCol"};
     String[] expectedTypes = {"string", "int", "long", "real", "bool", "datetime"};
+
     for (int i = 0; i < expectedTypes.length; i++) {
+      assertEquals(expectedNames[i], columns.get(i).get("name").asText());
       assertEquals(expectedTypes[i], columns.get(i).get("type").asText());
     }
+
+    // Verify row values match types
+    JsonNode row = root.get("tables").get(0).get("rows").get(0);
+    assertEquals("value", row.get(0).asText());
+    assertEquals(42, row.get(1).asInt());
+    assertEquals(1000, row.get(2).asLong());
+    assertTrue(Math.abs(3.14 - row.get(3).asDouble()) < 0.01);
+    assertTrue(row.get(4).asBoolean());
+    assertTrue(row.get(5).asText().contains("2026-04-26"));
   }
 
   @Test
@@ -117,8 +144,14 @@ public void testParseEmptyResult() throws Exception {
         "}";
 
     JsonNode root = mapper.readTree(jsonResponse);
+    JsonNode columns = root.get("tables").get(0).get("columns");
     JsonNode rows = root.get("tables").get(0).get("rows");
 
+    // Should have column metadata even with empty rows
+    assertEquals(1, columns.size());
+    assertEquals("Column1", columns.get(0).get("name").asText());
+
+    // But no data rows
     assertEquals(0, rows.size());
   }
 
@@ -142,7 +175,12 @@ public void testParseNullValues() throws Exception {
     JsonNode root = mapper.readTree(jsonResponse);
     JsonNode rows = root.get("tables").get(0).get("rows");
 
+    // First row: null string, 123 int
     assertTrue(rows.get(0).get(0).isNull());
+    assertEquals(123, rows.get(0).get(1).asInt());
+
+    // Second row: "value" string, null int
+    assertEquals("value", rows.get(1).get(0).asText());
     assertTrue(rows.get(1).get(1).isNull());
   }
 
@@ -162,9 +200,27 @@ public void testParsePaginationLink() throws Exception {
     JsonNode nextLink = root.get("@odata.nextLink");
 
     assertNotNull(nextLink);
+    assertTrue(nextLink.asText().contains("api.loganalytics.io"));
     assertTrue(nextLink.asText().contains("skip=1000"));
   }
 
+  @Test
+  public void testParseNoPaginationLink() throws Exception {
+    String jsonResponse = "{\n" +
+        "  \"tables\": [\n" +
+        "    {\n" +
+        "      \"columns\": [{\"name\": \"Col1\", \"type\": \"string\"}],\n" +
+        "      \"rows\": [[\"value1\"]]\n" +
+        "    }\n" +
+        "  ]\n" +
+        "}";
+
+    JsonNode root = mapper.readTree(jsonResponse);
+    JsonNode nextLink = root.get("@odata.nextLink");
+
+    assertTrue(nextLink == null || nextLink.isNull());
+  }
+
   @Test
   public void testParseLargeNumbers() throws Exception {
     String jsonResponse = "{\n" +
@@ -182,6 +238,27 @@ public void testParseLargeNumbers() throws Exception {
     assertEquals(9223372036854775807L, value);
   }
 
+  @Test
+  public void testParseNegativeNumbers() throws Exception {
+    String jsonResponse = "{\n" +
+        "  \"tables\": [\n" +
+        "    {\n" +
+        "      \"columns\": [\n" +
+        "        {\"name\": \"IntVal\", \"type\": \"int\"},\n" +
+        "        {\"name\": \"RealVal\", \"type\": \"real\"}\n" +
+        "      ],\n" +
+        "      \"rows\": [[-42, -3.14]]\n" +
+        "    }\n" +
+        "  ]\n" +
+        "}";
+
+    JsonNode root = mapper.readTree(jsonResponse);
+    JsonNode row = root.get("tables").get(0).get("rows").get(0);
+
+    assertEquals(-42, row.get(0).asInt());
+    assertTrue(Math.abs(-3.14 - row.get(1).asDouble()) < 0.01);
+  }
+
   @Test
   public void testParseDecimalNumbers() throws Exception {
     String jsonResponse = "{\n" +
@@ -202,7 +279,40 @@ public void testParseDecimalNumbers() throws Exception {
     double realValue = row.get(0).asDouble();
     double decimalValue = row.get(1).asDouble();
 
-    assertEquals(1.5, realValue, 0.01);
-    assertEquals(2.7, decimalValue, 0.01);
+    assertTrue(Math.abs(1.5 - realValue) < 0.01);
+    assertTrue(Math.abs(2.7 - decimalValue) < 0.01);
+  }
+
+  @Test
+  public void testParseMultipleRows() throws Exception {
+    String jsonResponse = "{\n" +
+        "  \"tables\": [\n" +
+        "    {\n" +
+        "      \"columns\": [\n" +
+        "        {\"name\": \"Name\", \"type\": \"string\"},\n" +
+        "        {\"name\": \"Value\", \"type\": \"int\"}\n" +
+        "      ],\n" +
+        "      \"rows\": [\n" +
+        "        [\"Alert1\", 10],\n" +
+        "        [\"Alert2\", 20],\n" +
+        "        [\"Alert3\", 30]\n" +
+        "      ]\n" +
+        "    }\n" +
+        "  ]\n" +
+        "}";
+
+    JsonNode root = mapper.readTree(jsonResponse);
+    JsonNode rows = root.get("tables").get(0).get("rows");
+
+    assertEquals(3, rows.size());
+
+    assertEquals("Alert1", rows.get(0).get(0).asText());
+    assertEquals(10, rows.get(0).get(1).asInt());
+
+    assertEquals("Alert2", rows.get(1).get(0).asText());
+    assertEquals(20, rows.get(1).get(1).asInt());
+
+    assertEquals("Alert3", rows.get(2).get(0).asText());
+    assertEquals(30, rows.get(2).get(1).asInt());
   }
 }