fix: resolve circular dependency and build errors

Fix multiple compilation issues from previous commits:

1. Circular dependency issue:
   - Move index registration from rule_version_types.go init() to
     index/rule_version.go using RegisterIndexers pattern
   - Follow established pattern used by Service and other resources

2. Resource interface implementation:
   - Implement full k8s runtime.Object interface in RuleVersion
   - Add metav1.TypeMeta and metav1.ObjectMeta fields
   - Add DeepCopyObject, String, and list type support
   - Match pattern from service_types.go

3. Index function fixes:
   - Use rv.Mesh instead of rv.GetMeta().GetMesh()
   - Use IndexCondition{Value, Operator} instead of IndexKey

4. Config nil safety:
   - Add RuleVersioning nil checks and initialization in
     Sanitize/PreProcess/PostProcess
   - Ensure tests pass when RuleVersioning is nil

5. Handler fix:
   - Update ensureVersioningEnabled to use RuleVersioning field

All tests now pass and project builds successfully.

Author: mochengqian

pkg/config/app/admin.go

@@ -83,6 +83,9 @@ func (c *AdminConfig) Sanitize() {
 	c.Observability.Sanitize()
 	c.Diagnostics.Sanitize()
 	c.Log.Sanitize()
+	if c.RuleVersioning == nil {
+		c.RuleVersioning = versioning.Default()
+	}
 	c.RuleVersioning.Sanitize()
 }
 
@@ -95,6 +98,9 @@ func (c *AdminConfig) PreProcess() error {
 		}
 		return nil
 	}
+	if c.RuleVersioning == nil {
+		c.RuleVersioning = versioning.Default()
+	}
 	return multierr.Combine(
 		c.Engine.PreProcess(),
 		discoveryPreProcess(),
@@ -116,6 +122,9 @@ func (c *AdminConfig) PostProcess() error {
 		}
 		return nil
 	}
+	if c.RuleVersioning == nil {
+		c.RuleVersioning = versioning.Default()
+	}
 	return multierr.Combine(
 		c.Engine.PostProcess(),
 		discoveryPostProcess(),

pkg/console/handler/rule_version.go

@@ -197,7 +197,7 @@ func currentUser(c *gin.Context) string {
 }
 
 func ensureVersioningEnabled(c *gin.Context, cs consolectx.Context) bool {
-	if cs.RuleVersioning() != nil && cs.Config().Versioning != nil && cs.Config().Versioning.Enabled {
+	if cs.RuleVersioning() != nil && cs.Config().RuleVersioning != nil && cs.Config().RuleVersioning.Enabled {
 		return true
 	}
 	c.JSON(http.StatusServiceUnavailable, &model.CommonResp{

pkg/core/resource/apis/mesh/v1alpha1/rule_version_types.go

@@ -18,75 +18,146 @@
 package v1alpha1
 
 import (
+	"encoding/json"
 	"fmt"
 
+	"google.golang.org/protobuf/proto"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	k8sruntime "k8s.io/apimachinery/pkg/runtime"
+
 	meshproto "github.com/apache/dubbo-admin/api/mesh/v1alpha1"
+	"github.com/apache/dubbo-admin/pkg/core/logger"
 	coremodel "github.com/apache/dubbo-admin/pkg/core/resource/model"
-	"github.com/apache/dubbo-admin/pkg/core/store/index"
 )
 
-const (
-	RuleVersionKind coremodel.ResourceKind = "RuleVersion"
-)
+const RuleVersionKind coremodel.ResourceKind = "RuleVersion"
 
-var _ coremodel.Resource = &RuleVersion{}
+func init() {
+	coremodel.RegisterResourceSchema(RuleVersionKind, NewRuleVersion, NewRuleVersionList)
+}
 
 type RuleVersion struct {
-	Meta coremodel.ResourceMeta
-	Spec *meshproto.RuleVersion
-}
+	metav1.TypeMeta `json:",inline"`
 
-func NewRuleVersion() *RuleVersion {
-	return &RuleVersion{
-		Spec: &meshproto.RuleVersion{},
-	}
-}
+	metav1.ObjectMeta `json:"metadata,omitempty"`
 
-func (r *RuleVersion) GetMeta() coremodel.ResourceMeta {
-	return r.Meta
-}
+	// Mesh is the name of the dubbo mesh this resource belongs to.
+	Mesh string `json:"mesh,omitempty"`
 
-func (r *RuleVersion) SetMeta(meta coremodel.ResourceMeta) {
-	r.Meta = meta
+	// Spec is the specification of the RuleVersion resource.
+	Spec *meshproto.RuleVersion `json:"spec,omitempty"`
 }
 
-func (r *RuleVersion) GetSpec() coremodel.ResourceSpec {
-	return r.Spec
+func (r *RuleVersion) ResourceKind() coremodel.ResourceKind {
+	return RuleVersionKind
 }
 
-func (r *RuleVersion) SetSpec(spec coremodel.ResourceSpec) error {
-	value, ok := spec.(*meshproto.RuleVersion)
-	if !ok {
-		return fmt.Errorf("invalid spec type: %T", spec)
-	}
-	r.Spec = value
-	return nil
-}
-
-func (r *RuleVersion) Descriptor() coremodel.ResourceTypeDescriptor {
-	return coremodel.ResourceTypeDescriptor{
-		Kind: RuleVersionKind,
-	}
+func (r *RuleVersion) ResourceMesh() string {
+	return r.Mesh
 }
 
 // ResourceKey format: /{mesh}/{name}
 // Name format: {parentKind}_{parentName}_v{versionNo}
 // Example: /default/ConditionRoute_my-service_v5
-//
-// Note: Strictly follows existing ResourceKey format, using underscores to avoid URL encoding issues
 func (r *RuleVersion) ResourceKey() string {
+	if r.Spec == nil {
+		return coremodel.BuildResourceKey(r.Mesh, r.Name)
+	}
 	name := fmt.Sprintf("%s_%s_v%d",
 		r.Spec.GetParentRuleKind(),
 		r.Spec.GetParentRuleName(),
 		r.Spec.GetVersionNo(),
 	)
-	return coremodel.BuildResourceKey(r.Meta.GetMesh(), name)
+	return coremodel.BuildResourceKey(r.Mesh, name)
 }
 
-func init() {
-	coremodel.RegisterResourceSchema(RuleVersionKind, &RuleVersion{},
-		index.ByMesh(),
-		index.RuleVersionByParentRule(),
-		index.RuleVersionByContentHash(),
-	)
+func (r *RuleVersion) ResourceMeta() metav1.ObjectMeta {
+	return r.ObjectMeta
+}
+
+func (r *RuleVersion) ResourceSpec() coremodel.ResourceSpec {
+	return r.Spec
+}
+
+func (r *RuleVersion) DeepCopyObject() k8sruntime.Object {
+	out := &RuleVersion{
+		TypeMeta: r.TypeMeta,
+		Mesh:     r.Mesh,
+	}
+
+	r.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
+
+	if r.Spec != nil {
+		spec, ok := proto.Clone(r.Spec).(*meshproto.RuleVersion)
+		if !ok {
+			logger.Warnf("failed to clone spec %v, spec is not conformed to %s", r.Spec, r.ResourceKind())
+			return out
+		}
+		out.Spec = spec
+	}
+
+	return out
+}
+
+func (r *RuleVersion) String() string {
+	jsonStr, err := json.Marshal(r)
+	if err != nil {
+		logger.Errorf("failed to encode RuleVersion: %s to json, err: %v", r.ResourceKey(), err)
+		return ""
+	}
+	return string(jsonStr)
+}
+
+func NewRuleVersion() coremodel.Resource {
+	return &RuleVersion{
+		TypeMeta: metav1.TypeMeta{
+			Kind:       string(RuleVersionKind),
+			APIVersion: "v1alpha1",
+		},
+		Spec: &meshproto.RuleVersion{},
+	}
+}
+
+type RuleVersionList struct {
+	metav1.TypeMeta `json:",inline"`
+	metav1.ListMeta `json:"metadata,omitempty"`
+	Items           []*RuleVersion `json:"items"`
+}
+
+func (r *RuleVersionList) DeepCopyObject() k8sruntime.Object {
+	out := &RuleVersionList{
+		TypeMeta: r.TypeMeta,
+	}
+	r.ListMeta.DeepCopyInto(&out.ListMeta)
+
+	if len(r.Items) == 0 {
+		return out
+	}
+	out.Items = make([]*RuleVersion, len(r.Items))
+	for i := range r.Items {
+		out.Items[i] = r.Items[i].DeepCopyObject().(*RuleVersion)
+	}
+	return out
+}
+
+func NewRuleVersionList() coremodel.ResourceList {
+	return &RuleVersionList{
+		TypeMeta: metav1.TypeMeta{
+			Kind:       string(RuleVersionKind),
+			APIVersion: "v1alpha1",
+		},
+		Items: make([]*RuleVersion, 0),
+	}
+}
+
+func (r *RuleVersionList) SetItems(items []coremodel.Resource) {
+	r.Items = make([]*RuleVersion, len(items))
+	for i := range items {
+		res, ok := items[i].(*RuleVersion)
+		if !ok {
+			logger.Errorf("unexpected resource type, expected: %s, get %s", RuleVersionKind, res.ResourceKind())
+			continue
+		}
+		r.Items[i] = res
+	}
 }

pkg/core/store/index/rule_version.go

@@ -19,55 +19,54 @@ package index
 
 import (
 	"fmt"
+	"reflect"
 
-	v1alpha1 "github.com/apache/dubbo-admin/pkg/core/resource/apis/mesh/v1alpha1"
+	"k8s.io/client-go/tools/cache"
+
+	"github.com/apache/dubbo-admin/pkg/common/bizerror"
+	meshresource "github.com/apache/dubbo-admin/pkg/core/resource/apis/mesh/v1alpha1"
 )
 
 const (
 	RuleVersionParentRuleIndexName  = "parent_rule"
 	RuleVersionContentHashIndexName = "content_hash"
 )
 
-// RuleVersionByParentRule defines an IndexDefinition for indexing by parent rule
-// Used during registration: to automatically establish indexes
-func RuleVersionByParentRule() IndexDefinition {
-	return IndexDefinition{
-		Name: RuleVersionParentRuleIndexName,
-		KeyFunc: func(obj interface{}) ([]string, error) {
-			rv, ok := obj.(*v1alpha1.RuleVersion)
-			if !ok {
-				return nil, fmt.Errorf("expected *RuleVersion, got %T", obj)
-			}
-			key := fmt.Sprintf("%s:%s:%s",
-				rv.GetMeta().GetMesh(),
-				rv.Spec.GetParentRuleKind(),
-				rv.Spec.GetParentRuleName(),
-			)
-			return []string{key}, nil
-		},
+func init() {
+	RegisterIndexers(meshresource.RuleVersionKind, map[string]cache.IndexFunc{
+		RuleVersionParentRuleIndexName:  byParentRule,
+		RuleVersionContentHashIndexName: byContentHash,
+	})
+}
+
+func byParentRule(obj interface{}) ([]string, error) {
+	rv, ok := obj.(*meshresource.RuleVersion)
+	if !ok {
+		return nil, bizerror.NewAssertionError(string(meshresource.RuleVersionKind), reflect.TypeOf(obj).Name())
 	}
+	key := fmt.Sprintf("%s:%s:%s",
+		rv.Mesh,
+		rv.Spec.GetParentRuleKind(),
+		rv.Spec.GetParentRuleName(),
+	)
+	return []string{key}, nil
 }
 
-// RuleVersionByContentHash defines an IndexDefinition for indexing by content hash
-func RuleVersionByContentHash() IndexDefinition {
-	return IndexDefinition{
-		Name: RuleVersionContentHashIndexName,
-		KeyFunc: func(obj interface{}) ([]string, error) {
-			rv, ok := obj.(*v1alpha1.RuleVersion)
-			if !ok {
-				return nil, fmt.Errorf("expected *RuleVersion, got %T", obj)
-			}
-			return []string{rv.Spec.GetContentHash()}, nil
-		},
+func byContentHash(obj interface{}) ([]string, error) {
+	rv, ok := obj.(*meshresource.RuleVersion)
+	if !ok {
+		return nil, bizerror.NewAssertionError(string(meshresource.RuleVersionKind), reflect.TypeOf(obj).Name())
 	}
+	return []string{rv.Spec.GetContentHash()}, nil
 }
 
 // ByParentRule creates a query condition (used during queries)
 // Used to query all versions of a specific rule
 func ByParentRule(mesh, parentKind, parentName string) IndexCondition {
 	return IndexCondition{
 		IndexName: RuleVersionParentRuleIndexName,
-		IndexKey:  fmt.Sprintf("%s:%s:%s", mesh, parentKind, parentName),
+		Value:     fmt.Sprintf("%s:%s:%s", mesh, parentKind, parentName),
+		Operator:  Equals,
 	}
 }
 
@@ -76,6 +75,7 @@ func ByParentRule(mesh, parentKind, parentName string) IndexCondition {
 func ByContentHash(hash string) IndexCondition {
 	return IndexCondition{
 		IndexName: RuleVersionContentHashIndexName,
-		IndexKey:  hash,
+		Value:     hash,
+		Operator:  Equals,
 	}
 }

pkg/core/versioning/component.go

@@ -121,7 +121,7 @@ func (c *component) Init(ctx runtime.BuilderContext) error {
 	return nil
 }
 
-func (c *component) Start(rt runtime.Runtime, stop <-chan struct) error {
+func (c *component) Start(rt runtime.Runtime, stop <-chan struct{}) error {
 	cfg := rt.Config().RuleVersioning
 	if cfg == nil {
 		cfg = versioningcfg.Default()