Skip to content

Commit 86e113f

Browse files
authored
[ISSUE ##4865] Improve readability of failed topic list log (#4868)
Signed-off-by: Rohit Satya <[email protected]>
1 parent 5451de0 commit 86e113f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Diff for: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/DeleteTopicProcessor.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,11 @@ public void handler(HandlerService.HandlerSpecific handlerSpecific, HttpRequest
122122

123123
Map<String, Object> responseBodyMap = new HashMap<>();
124124
StringBuilder sb = new StringBuilder();
125-
sb.append(faildTopic.toString()).append(" not exist in eventmesh");
126-
HTTP_LOGGER.warn("delete topic fail, {}", sb.toString());
125+
String topics = String.join(", ", faildTopic);
126+
sb.append(topics).append(" do not exist in eventmesh");
127+
HTTP_LOGGER.warn("delete topic fail, {}", sb);
127128
responseBodyMap.put("retCode", EventMeshRetCode.EVENTMESH_OPERATE_FAIL.getRetCode());
128-
responseBodyMap.put("retMsg", EventMeshRetCode.EVENTMESH_OPERATE_FAIL.getErrMsg() + sb.toString());
129+
responseBodyMap.put("retMsg", EventMeshRetCode.EVENTMESH_OPERATE_FAIL.getErrMsg() + sb);
129130
responseWrapper = requestWrapper.createHttpResponse(responseHeaderMap, responseBodyMap);
130131
responseWrapper.setHttpResponseStatus(HttpResponseStatus.BAD_REQUEST);
131132
handlerSpecific.sendErrorResponse(EventMeshRetCode.EVENTMESH_OPERATE_FAIL, responseHeaderMap,

0 commit comments

Comments
 (0)