From 7a0cd278a366c8fcd55c669bae61da81d4a8d770 Mon Sep 17 00:00:00 2001 From: Rohit Satya Date: Fri, 26 Apr 2024 22:13:27 +0530 Subject: [PATCH] improve readability of failed topic list log Signed-off-by: Rohit Satya --- .../core/protocol/http/processor/DeleteTopicProcessor.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/DeleteTopicProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/DeleteTopicProcessor.java index 039754a815..c156cc704d 100644 --- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/DeleteTopicProcessor.java +++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/DeleteTopicProcessor.java @@ -122,10 +122,11 @@ public void handler(HandlerService.HandlerSpecific handlerSpecific, HttpRequest Map responseBodyMap = new HashMap<>(); StringBuilder sb = new StringBuilder(); - sb.append(faildTopic.toString()).append(" not exist in eventmesh"); - HTTP_LOGGER.warn("delete topic fail, {}", sb.toString()); + String topics = String.join(", ", faildTopic); + sb.append(topics).append(" do not exist in eventmesh"); + HTTP_LOGGER.warn("delete topic fail, {}", sb); responseBodyMap.put("retCode", EventMeshRetCode.EVENTMESH_OPERATE_FAIL.getRetCode()); - responseBodyMap.put("retMsg", EventMeshRetCode.EVENTMESH_OPERATE_FAIL.getErrMsg() + sb.toString()); + responseBodyMap.put("retMsg", EventMeshRetCode.EVENTMESH_OPERATE_FAIL.getErrMsg() + sb); responseWrapper = requestWrapper.createHttpResponse(responseHeaderMap, responseBodyMap); responseWrapper.setHttpResponseStatus(HttpResponseStatus.BAD_REQUEST); handlerSpecific.sendErrorResponse(EventMeshRetCode.EVENTMESH_OPERATE_FAIL, responseHeaderMap,