Skip to content

Commit 571f967

Browse files
committed
fix: applying copilot feedback
1 parent 88b49ed commit 571f967

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/IcebergMetadataApplier.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,9 @@ private void applyAddColumnEventWithPosition(Table table, AddColumnEvent event)
252252
case LAST:
253253
break;
254254
case BEFORE:
255+
checkNotNull(
256+
columnWithPosition.getExistedColumnName(),
257+
"Existing column name must be provided for BEFORE position");
255258
updateSchema.moveBefore(
256259
columnName, columnWithPosition.getExistedColumnName());
257260
break;

flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/utils/IcebergTypeUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public static Literal<?> parseDefaultValue(
7272
if (defaultValueExpression == null) {
7373
return null;
7474
}
75+
defaultValueExpression = defaultValueExpression.trim();
7576
try {
7677
switch (cdcType.getTypeRoot()) {
7778
case CHAR:
@@ -104,7 +105,7 @@ public static Literal<?> parseDefaultValue(
104105
new java.math.BigDecimal(defaultValueExpression)
105106
.setScale(scale, java.math.RoundingMode.HALF_UP));
106107
default:
107-
LOG.warn(
108+
LOG.debug(
108109
"Unsupported default value type {} for expression '{}', skipping default value.",
109110
cdcType.getTypeRoot(),
110111
defaultValueExpression);

0 commit comments

Comments
 (0)