Skip to content

Commit d565d85

Browse files
committed
[starrocks] Escape quoted default/comment literals in DDL
1 parent 3778300 commit d565d85

1 file changed

Lines changed: 16 additions & 6 deletions

File tree

flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierITCase.java

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,9 @@ private List<Event> generateAddColumnEvents(TableId tableId) {
101101
Schema.newBuilder()
102102
.column(new PhysicalColumn("id", DataTypes.INT().notNull(), null))
103103
.column(new PhysicalColumn("number", DataTypes.DOUBLE(), null))
104-
.column(new PhysicalColumn("name", DataTypes.VARCHAR(17), null))
104+
.column(
105+
new PhysicalColumn(
106+
"name", DataTypes.VARCHAR(17), "\"name\"", "\"\""))
105107
.primaryKey("id")
106108
.build();
107109

@@ -123,9 +125,16 @@ private List<Event> generateAddColumnEvents(TableId tableId) {
123125
Collections.singletonList(
124126
new AddColumnEvent.ColumnWithPosition(
125127
new PhysicalColumn(
126-
"extra_decimal",
127-
DataTypes.DECIMAL(17, 0),
128-
null)))));
128+
"extra_decimal", DataTypes.DECIMAL(17, 0), null)))),
129+
new AddColumnEvent(
130+
tableId,
131+
Collections.singletonList(
132+
new AddColumnEvent.ColumnWithPosition(
133+
new PhysicalColumn(
134+
"extra_string",
135+
DataTypes.VARCHAR(17),
136+
"\"extra_string\"",
137+
"\"\"")))));
129138
}
130139

131140
private List<Event> generateDropColumnEvents(TableId tableId) {
@@ -285,10 +294,11 @@ void testStarRocksAddColumn() throws Exception {
285294
Arrays.asList(
286295
"id | int | NO | true | null",
287296
"number | double | YES | false | null",
288-
"name | varchar(51) | YES | false | null",
297+
"name | varchar(51) | YES | false | \"\"",
289298
"extra_date | date | YES | false | null",
290299
"extra_bool | boolean | YES | false | null",
291-
"extra_decimal | decimal(17,0) | YES | false | null");
300+
"extra_decimal | decimal(17,0) | YES | false | null",
301+
"extra_string | varchar(51) | YES | false | \"\"");
292302

293303
assertEqualsInOrder(expected, actual);
294304
}

0 commit comments

Comments
 (0)