Skip to content

Commit df6893d

Browse files
authored
[minor][docs] add JDK baseline version and remove useless code (#4238)
1 parent 7f909f4 commit df6893d

4 files changed

Lines changed: 6 additions & 13 deletions

File tree

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
scalastyle-output.xml
33
.classpath
44
.idea/*
5-
!.idea/vcs.xml
65
.metadata
76
.settings
87
.project

docs/content.zh/docs/developer-guide/contribute-to-flink-cdc.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ Flink CDC 项目通过众多贡献者的代码贡献来维护,改进和拓展
4848

4949
在 Flink CDC 社区可以自由的在任何时间提出自己的问题,通过社区 Dev 邮件列表进行交流或在任何感兴趣的 issue 下评论和讨论。
5050

51+
Flink CDC 使用 JDK 11 作为基础版本,请确保您的开发环境已经正确配置。
52+
5153
如果您想要为 Flink CDC 贡献代码,可以通过如下的方式。
5254

5355
1. 首先在 [Flink jira](https://issues.apache.org/jira/projects/FLINK/issues) 的想要负责的 issue

docs/content/docs/developer-guide/contribute-to-flink-cdc.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ Flink CDC is maintained, improved, and extended by code contributions of volunte
5151

5252
Please feel free to ask questions at any time. Either send a mail to the Dev mailing list or comment on the issue you are working on.
5353

54+
Flink CDC uses JDK 11 as the baseline version. Please make sure your development environment is set up correctly.
55+
5456
If you would like to contribute to Flink CDC, you could raise it as follows.
5557

5658
1. Left comment under the issue that you want to take. (It's better to explain your understanding of the issue, and

flink-cdc-e2e-tests/flink-cdc-source-e2e-tests/src/test/java/org/apache/flink/cdc/connectors/tests/MongoE2eITCase.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import java.time.Duration;
4444
import java.util.Arrays;
4545
import java.util.List;
46-
import java.util.Objects;
4746
import java.util.Random;
4847
import java.util.stream.Stream;
4948

@@ -65,16 +64,7 @@ class MongoE2eITCase extends FlinkContainerTestEnvironment {
6564

6665
private MongoClient mongoClient;
6766

68-
public static String getMongoVersion() {
69-
String specifiedMongoVersion = System.getProperty("specifiedMongoVersion");
70-
if (Objects.isNull(specifiedMongoVersion)) {
71-
throw new IllegalArgumentException(
72-
"No MongoDB version specified to run this test. Please use -DspecifiedMongoVersion to pass one.");
73-
}
74-
return specifiedMongoVersion;
75-
}
76-
77-
void setup(String mongoVersion, boolean parallelismSnapshot, boolean scanFullChangelog) {
67+
void setup(String mongoVersion, boolean scanFullChangelog) {
7868
container =
7969
new MongoDBContainer("mongo:" + mongoVersion)
8070
.withSharding()
@@ -123,7 +113,7 @@ public void after() {
123113
})
124114
void testMongoDbCDC(String mongoVersion, boolean parallelismSnapshot, boolean scanFullChangelog)
125115
throws Exception {
126-
setup(mongoVersion, parallelismSnapshot, scanFullChangelog);
116+
setup(mongoVersion, scanFullChangelog);
127117
String dbName =
128118
container.executeCommandFileInDatabase(
129119
"mongo_inventory",

0 commit comments

Comments
 (0)