[FLINK-39573][cdc][docs] Fix Build documentation CI startup_failure by replacing third-party rsync action#4385
Merged
Conversation
…y replacing third-party rsync action The Build documentation workflow has been failing with startup_failure since April 18, 2026 because burnett01/rsync-deployments is not allowed by the Apache Infra actions policy. Replace the third-party action with a local composite action that uses native rsync and ssh-agent, following the same approach used in FLINK-38448 for flink-kubernetes-operator. This eliminates the dependency on third-party actions entirely and avoids future breakage from allowed list changes or version expirations. Note: After merging, this action needs to be backported to release-3.5 and release-3.6 branches as well, since the workflow checks out those branches and requires the local action to be present.
Contributor
Author
|
@lvyanquan PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Build documentationGitHub Actions workflow has been failing withstartup_failuresince April 18, 2026. All scheduled and PR-triggered documentation builds are broken, meaning updated documentation cannot be published to the Apache Nightlies website.Error message:
CI failure history: All runs since April 18 show
startup_failure— Build documentation workflow runsRoot Cause
The workflow uses
burnett01/rsync-deployments@0dc935cdwhich is pinned to v5.2 (from 2022). This version is not in the Apache Infra approved actions list. Apache enforces an allowlist for third-party GitHub Actions, and only the following versions ofburnett01/rsync-deploymentsare approved:7659d600d8bdd035bb5cdfba1d4bd0dd4a307ca6(v8.0.3, expires 2026-05-22)dc0d5d44c4728aad3f02154a87309809e62a960f(v8.0.4)Considered Approaches
Option 1: Upgrade to an approved version (v8.0.4)
Simply replace the SHA with the approved
dc0d5d44c4728aad3f02154a87309809e62a960f(v8.0.4).Pros: Minimal change, single-line fix.
Cons: Still depends on a third-party action. The approved versions have expiration dates (e.g., v8.0.3 expires 2026-05-22). When they expire, the workflow will break again with the same
startup_failure. This was exactly the experience reported in FLINK-38448 — upgrading to the latest version did not help at that time.Option 2: Replace with a local composite action (Chosen ✅)
Create a local composite action at
.github/actions/rsync-deployments/that uses nativersync+ssh-agent(both pre-installed onubuntu-latestrunners), eliminating the dependency on any third-party action entirely.Pros:
Cons:
release-3.5andrelease-3.6branches (the workflow checks out these branches via matrix and requires the local action to be present)Changes
.github/actions/rsync-deployments/action.yml— Local composite action that usesssh-agent+rsyncto deploy documentation, with the same interface as the original third-party action.github/actions/rsync-deployments/LICENSE— MIT License from the original burnett01/rsync-deployments.github/workflows/build_docs.yml— Replaceburnett01/rsync-deployments@0dc935cdwith./.github/actions/rsync-deploymentsin both upload stepsPost-merge Steps
After this PR is merged to
master, the.github/actions/rsync-deployments/directory must be backported to the following branches so that the matrix builds for those versions continue to work:release-3.6release-3.5References