You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During a project we're working on we decided to use Flink over Opensearch 2.3, which seems to have a breaking change of removing the type property from responses.
This PR updates the dependency and the relevant tests.
I'd be happy to do any necessary changes to make sure this release is differentiated from the one meant for Opensearch 1.3.
@amirhalatzi the OpenSearch 2.x has JDK-11 baseline (the connector works with 2.x as well). Please correct me if I am wrong, Apache Flink still supports JDK 8 (although it is deprecated).
@reta you're right. Java 8 is still supported. As for the current connector working with 2.x - you can see in the PR that the API has changed.
Any ideas on how to support both versions without upgrading to Java 11?
@reta you're right. Java 8 is still supported. As for the current connector working with 2.x - you can see in the PR that the API has changed. Any ideas on how to support both versions without upgrading to Java 11?
@amirhalatzi this is only test code which uses type, sadly the Bulk API in 1.x requires it (at least for responses), it might be possible to rewrite this test case as integration (in this case the responses don't need to be mocked). The connector's code itself does not use any deprecated APIs though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
During a project we're working on we decided to use Flink over Opensearch 2.3, which seems to have a breaking change of removing the
typeproperty from responses.This PR updates the dependency and the relevant tests.
I'd be happy to do any necessary changes to make sure this release is differentiated from the one meant for Opensearch 1.3.
Thanks!