Skip to content

[FLINK-39707] Update flink-connector-parent to 2.0.0#64

Open
mukul-8 wants to merge 1 commit into
apache:mainfrom
mukul-8:FLINK-39707-update-connector-parent-2.0
Open

[FLINK-39707] Update flink-connector-parent to 2.0.0#64
mukul-8 wants to merge 1 commit into
apache:mainfrom
mukul-8:FLINK-39707-update-connector-parent-2.0

Conversation

@mukul-8
Copy link
Copy Markdown

@mukul-8 mukul-8 commented May 19, 2026

What is the purpose of the change

Update flink-connector-parent from 1.1.0 to 2.0.0.

Brief change log

  • Updated parent POM version from 1.1.0 to 2.0.0
  • Updated japicmp-maven-plugin groupId from io.github.zentol.japicmp to com.github.siom79.japicmp (aligned with new parent)
  • Updated checkstyle.xml to use properties compatible with newer Checkstyle version (replaced deprecated properties)
  • Updated archunit-violations baselines to reflect changes in the new parent

Verifying this change

This change is a dependency version bump. Verified by building the project successfully.

Does this pull request potentially affect one of the following parts?

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API: no
  • The runtime per-record code paths (performance sensitive): no

Documentation

  • Does this pull request introduce a new feature? no

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 19, 2026

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@mukul-8
Copy link
Copy Markdown
Author

mukul-8 commented May 19, 2026

@chesnay @reta Could you please approve the CI workflow and review this change? This is a dependency maintenance improvement — updating to the latest connector parent — and would be a good fit before the next release. Thanks!

@reta
Copy link
Copy Markdown
Member

reta commented May 19, 2026

@chesnay @reta Could you please approve the CI workflow and review this change? This is a dependency maintenance improvement — updating to the latest connector parent — and would be a good fit before the next release. Thanks!

I sadly cannot, @snuyanzin could you please help here? Thank you!

@snuyanzin
Copy link
Copy Markdown
Contributor

started

@mukul-8 mukul-8 force-pushed the FLINK-39707-update-connector-parent-2.0 branch from ee9be84 to 693f206 Compare May 20, 2026 02:48
@mukul-8
Copy link
Copy Markdown
Author

mukul-8 commented May 20, 2026

@snuyanzin Could you please re-approve the CI workflow? I force-pushed to fix missing Apache license headers in two files (pre-existing issue now caught by the new parent's stricter RAT config). Thanks!

https://github.com/apache/flink-connector-opensearch/actions/runs/26096942370/job/76749795483

@mukul-8
Copy link
Copy Markdown
Author

mukul-8 commented May 20, 2026

Added a commit to fix spotless formatting violations — the new parent's upgraded spotless (2.43.0 with google-java-format 1.24.0) requires a blank line before Javadoc comments. Pre-existing issue in 3 files, not caught locally because spotless is
disabled on JDK 21 (CI runs JDK 11).

@mukul-8 mukul-8 force-pushed the FLINK-39707-update-connector-parent-2.0 branch from 893f653 to dfd01fb Compare May 21, 2026 05:06
@mukul-8
Copy link
Copy Markdown
Author

mukul-8 commented May 21, 2026

@snuyanzin Could you please re-approve the CI workflow? @reta can you help with review
I've squashed all fixes into a single commit — parent upgrade, license headers, spotless formatting, checkstyle config update, and removed the now-redundant JDK-21 spotless profile (parent 2.0.0 handles it). Verified locally with both JDK 17 and JDK 21. Thanks!

Copy link
Copy Markdown
Member

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukul-8 !

@mukul-8
Copy link
Copy Markdown
Author

mukul-8 commented May 22, 2026

@reta thanks for the review! @snuyanzin thanks for helping with CI approvals. Could you please merge this when you get a chance? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants