-
Notifications
You must be signed in to change notification settings - Fork 80
[FLINK-39697] Bump Flink version to 2.2.1 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,14 +133,21 @@ under the License. | |
| <artifactId>flink-table-test-utils</artifactId> | ||
| <version>${flink.version}</version> | ||
| <scope>test</scope> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-table-planner-loader</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-table-api-scala-bridge_${scala.binary.version}</artifactId> | ||
| <artifactId>flink-table-planner_${scala.binary.version}</artifactId> | ||
| <version>${flink.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate |
||
| <dependency> | ||
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-table-planner_${scala.binary.version}</artifactId> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -202,7 +202,7 @@ public TypeSerializer<T> restoreSerializer() { | |
|
|
||
| @Override | ||
| public TypeSerializerSchemaCompatibility<T> resolveSchemaCompatibility( | ||
| TypeSerializer<T> newSerializer) { | ||
| TypeSerializerSnapshot<T> oldSerializerSnapshot) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Always returning |
||
| return TypeSerializerSchemaCompatibility.compatibleAsIs(); | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,12 +20,9 @@ | |
|
|
||
| import org.apache.flink.annotation.Internal; | ||
| import org.apache.flink.configuration.Configuration; | ||
| import org.apache.flink.connector.base.source.reader.RecordsWithSplitIds; | ||
| import org.apache.flink.connector.base.source.reader.SourceReaderBase; | ||
| import org.apache.flink.connector.base.source.reader.fetcher.SplitFetcher; | ||
| import org.apache.flink.connector.base.source.reader.fetcher.SplitFetcherManager; | ||
| import org.apache.flink.connector.base.source.reader.splitreader.SplitReader; | ||
| import org.apache.flink.connector.base.source.reader.synchronization.FutureCompletingBlockingQueue; | ||
| import org.apache.flink.connector.pulsar.source.enumerator.topic.TopicPartition; | ||
| import org.apache.flink.connector.pulsar.source.split.PulsarPartitionSplit; | ||
|
|
||
|
|
@@ -59,16 +56,13 @@ public class PulsarSourceFetcherManager | |
| /** | ||
| * Creates a new SplitFetcherManager with multiple I/O threads. | ||
| * | ||
| * @param elementsQueue The queue that is used to hand over data from the I/O thread (the | ||
| * fetchers) to the reader, which emits the records and book-keeps the state. This must be | ||
| * the same queue instance that is also passed to the {@link SourceReaderBase}. | ||
| * @param splitReaderSupplier The factory for the split reader that connects to the source | ||
| * @param configuration The configuration for the fetcher manager | ||
| */ | ||
| public PulsarSourceFetcherManager( | ||
| FutureCompletingBlockingQueue<RecordsWithSplitIds<Message<byte[]>>> elementsQueue, | ||
| Supplier<SplitReader<Message<byte[]>, PulsarPartitionSplit>> splitReaderSupplier, | ||
| Configuration configuration) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Constructor signature change is correct for Flink 2.x. Consider adding Javadoc to note the |
||
| super(elementsQueue, splitReaderSupplier, configuration); | ||
| super(splitReaderSupplier, configuration); | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -86,7 +80,7 @@ public void addSplits(List<PulsarPartitionSplit> splitsToAdd) { | |
| } | ||
| } | ||
|
|
||
| // @Override // to keep compatible with Flink 1.17 | ||
| @Override | ||
| public void removeSplits(List<PulsarPartitionSplit> splitsToRemove) { | ||
| // TODO empty - wait for FLINK-31748 to implement it. | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK 8 removed correctly per Flink 2.x requirements. Update README.md to document minimum JDK 11 requirement.