Skip to content

Commit 0b6f1c8

Browse files
rebase merge conflict
1 parent a1aeae3 commit 0b6f1c8

File tree

3 files changed

+7
-72
lines changed

3 files changed

+7
-72
lines changed

fluss-server/src/main/java/org/apache/fluss/server/kv/KvTablet.java

Lines changed: 3 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,8 @@
6767
import org.apache.fluss.types.RowType;
6868
import org.apache.fluss.utils.BytesUtils;
6969
import org.apache.fluss.utils.FileUtils;
70-
import org.apache.fluss.utils.FlussPaths;
71-
import org.apache.fluss.utils.types.Tuple2;
7270

71+
import org.rocksdb.RateLimiter;
7372
import org.slf4j.Logger;
7473
import org.slf4j.LoggerFactory;
7574

@@ -161,69 +160,6 @@ private KvTablet(
161160
this.changelogImage = changelogImage;
162161
}
163162

164-
public static KvTablet create(
165-
LogTablet logTablet,
166-
File kvTabletDir,
167-
Configuration serverConf,
168-
TabletServerMetricGroup serverMetricGroup,
169-
BufferAllocator arrowBufferAllocator,
170-
MemorySegmentPool memorySegmentPool,
171-
KvFormat kvFormat,
172-
RowMerger rowMerger,
173-
ArrowCompressionInfo arrowCompressionInfo,
174-
SchemaGetter schemaGetter,
175-
ChangelogImage changelogImage)
176-
throws IOException {
177-
Tuple2<PhysicalTablePath, TableBucket> tablePathAndBucket =
178-
FlussPaths.parseTabletDir(kvTabletDir);
179-
return create(
180-
tablePathAndBucket.f0,
181-
tablePathAndBucket.f1,
182-
logTablet,
183-
kvTabletDir,
184-
serverConf,
185-
serverMetricGroup,
186-
arrowBufferAllocator,
187-
memorySegmentPool,
188-
kvFormat,
189-
rowMerger,
190-
arrowCompressionInfo,
191-
schemaGetter,
192-
changelogImage,
193-
null);
194-
}
195-
196-
public static KvTablet create(
197-
PhysicalTablePath tablePath,
198-
TableBucket tableBucket,
199-
LogTablet logTablet,
200-
File kvTabletDir,
201-
Configuration serverConf,
202-
TabletServerMetricGroup serverMetricGroup,
203-
BufferAllocator arrowBufferAllocator,
204-
MemorySegmentPool memorySegmentPool,
205-
KvFormat kvFormat,
206-
RowMerger rowMerger,
207-
ArrowCompressionInfo arrowCompressionInfo,
208-
SchemaGetter schemaGetter,
209-
ChangelogImage changelogImage)
210-
throws IOException {
211-
return create(
212-
tablePath,
213-
tableBucket,
214-
logTablet,
215-
kvTabletDir,
216-
serverConf,
217-
serverMetricGroup,
218-
arrowBufferAllocator,
219-
memorySegmentPool,
220-
kvFormat,
221-
rowMerger,
222-
arrowCompressionInfo,
223-
schemaGetter,
224-
null);
225-
}
226-
227163
public static KvTablet create(
228164
PhysicalTablePath tablePath,
229165
TableBucket tableBucket,
@@ -238,7 +174,7 @@ public static KvTablet create(
238174
ArrowCompressionInfo arrowCompressionInfo,
239175
SchemaGetter schemaGetter,
240176
ChangelogImage changelogImage,
241-
@Nullable org.rocksdb.RateLimiter sharedRateLimiter)
177+
RateLimiter sharedRateLimiter)
242178
throws IOException {
243179
RocksDBKv kv = buildRocksDBKv(serverConf, kvTabletDir, sharedRateLimiter);
244180
return new KvTablet(
@@ -260,9 +196,7 @@ public static KvTablet create(
260196
}
261197

262198
private static RocksDBKv buildRocksDBKv(
263-
Configuration configuration,
264-
File kvDir,
265-
org.rocksdb.RateLimiter sharedRateLimiter)
199+
Configuration configuration, File kvDir, RateLimiter sharedRateLimiter)
266200
throws IOException {
267201
RocksDBResourceContainer rocksDBResourceContainer =
268202
new RocksDBResourceContainer(configuration, kvDir, false, sharedRateLimiter);

fluss-server/src/main/java/org/apache/fluss/server/kv/rocksdb/RocksDBResourceContainer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public class RocksDBResourceContainer implements AutoCloseable {
7575
private final boolean enableStatistics;
7676

7777
/** The shared rate limiter for all RocksDB instances. */
78-
@Nullable private final RateLimiter sharedRateLimiter;
78+
private final RateLimiter sharedRateLimiter;
7979

8080
/** The handles to be closed when the container is closed. */
8181
private final ArrayList<AutoCloseable> handlesToClose;
@@ -100,7 +100,7 @@ public RocksDBResourceContainer(
100100
ReadableConfig configuration,
101101
@Nullable File instanceBasePath,
102102
boolean enableStatistics,
103-
@Nullable RateLimiter sharedRateLimiter) {
103+
RateLimiter sharedRateLimiter) {
104104
this.configuration = configuration;
105105

106106
this.instanceRocksDBPath =

fluss-server/src/test/java/org/apache/fluss/server/kv/KvTabletTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,8 @@ private KvTablet createKvTablet(
191191
rowMerger,
192192
DEFAULT_COMPRESSION,
193193
schemaGetter,
194-
tableConf.getChangelogImage());
194+
tableConf.getChangelogImage(),
195+
null);
195196
}
196197

197198
@Test

0 commit comments

Comments
 (0)