[flink] Increase code coverage for FlinkCatalogOptions (#929)

Author: MehulBatra

fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/catalog/FlinkCatalogOptions.java

@@ -23,5 +23,10 @@
 public class FlinkCatalogOptions {
 
     public static final ConfigOption<String> DEFAULT_DATABASE =
-            ConfigOptions.key("default-database").stringType().defaultValue("fluss");
+            ConfigOptions.key("default-database")
+                    .stringType()
+                    .defaultValue("fluss")
+                    .withDescription("Default database name used when none is specified.");
+
+    private FlinkCatalogOptions() {}
 }

fluss-flink/fluss-flink-common/src/test/java/com/alibaba/fluss/flink/catalog/FlinkCatalogFactoryTest.java

@@ -19,6 +19,7 @@
 import com.alibaba.fluss.config.ConfigOptions;
 import com.alibaba.fluss.flink.FlinkConnectorOptions;
 
+import org.apache.flink.configuration.ConfigOption;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.table.api.ValidationException;
 import org.apache.flink.table.catalog.CommonCatalogOptions;
@@ -28,6 +29,7 @@
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Set;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -119,4 +121,20 @@ private static void checkEquals(FlinkCatalog c1, FlinkCatalog c2) {
         assertThat(c2.getName()).isEqualTo(c1.getName());
         assertThat(c2.getDefaultDatabase()).isEqualTo(c1.getDefaultDatabase());
     }
+
+    @Test
+    public void testOptionalOptionsConfiguration() {
+        FlinkCatalogFactory factory = new FlinkCatalogFactory();
+
+        // Test that optionalOptions() correctly declares DEFAULT_DATABASE
+        Set<ConfigOption<?>> optionalOptions = factory.optionalOptions();
+        assertThat(optionalOptions)
+                .hasSize(1)
+                .containsExactly(FlinkCatalogOptions.DEFAULT_DATABASE);
+
+        ConfigOption<?> defaultDbOption = FlinkCatalogOptions.DEFAULT_DATABASE;
+        assertThat(defaultDbOption.key()).isEqualTo("default-database");
+        assertThat(defaultDbOption.hasDefaultValue()).isTrue();
+        assertThat(defaultDbOption.defaultValue()).isEqualTo("fluss");
+    }
 }

fluss-test-coverage/pom.xml

@@ -275,9 +275,6 @@
                                         <exclude>com.alibaba.fluss.flink.utils.*</exclude>
                                         <exclude>com.alibaba.fluss.flink.source.*
                                         </exclude>
-                                        <exclude>
-                                            com.alibaba.fluss.flink.catalog.FlinkCatalogOptions
-                                        </exclude>
                                         <exclude>
                                             com.alibaba.fluss.flink.source.FlinkTableSource.*
                                         </exclude>