Skip to content

Commit 84e0c8d

Browse files
authored
[common] Improve test converage on BinarySection (#1009)
1 parent 3c2bfea commit 84e0c8d

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

fluss-common/src/test/java/com/alibaba/fluss/row/BinaryStringTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.junit.jupiter.api.extension.ExtendWith;
2525

2626
import java.math.BigDecimal;
27+
import java.nio.ByteBuffer;
2728
import java.nio.charset.StandardCharsets;
2829
import java.util.Arrays;
2930
import java.util.List;
@@ -465,4 +466,29 @@ public void testFromBytes() {
465466
byte[] bytes = Arrays.copyOf(s.getBytes(UTF_8), 10);
466467
assertThat(fromBytes(bytes, 0, 6)).isEqualTo(BinaryString.fromString(s));
467468
}
469+
470+
@TestTemplate
471+
public void testBinarySectionFunctions() throws Exception {
472+
BinaryString testStr1 = BinaryString.fromString("");
473+
BinaryString testStr2 = BinaryString.fromString("");
474+
475+
BinaryString str = BinaryString.fromString("Hello World");
476+
// 1. pointTo
477+
testStr1.pointTo(str.getSegments(), 0, 5);
478+
assertThat(testStr1.toString()).isEqualTo("Hello");
479+
480+
testStr2.pointTo(str.getSegments()[0], 6, 5);
481+
assertThat(testStr2.toString()).isEqualTo("World");
482+
assertThat(testStr2.getOffset()).isEqualTo(6);
483+
484+
// 2. wrapByteBuffer
485+
ByteBuffer byteBuffer = testStr2.wrapByteBuffer();
486+
String str2FromByteBuffer = UTF_8.decode(byteBuffer).toString();
487+
assertThat(str2FromByteBuffer).isEqualTo("World");
488+
489+
// 3. equals
490+
assertThat(testStr2.equals(testStr2)).isTrue();
491+
assertThat(testStr2.equals(null)).isFalse();
492+
assertThat(testStr2.equals("World")).isFalse();
493+
}
468494
}

fluss-test-coverage/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@
252252
<exclude>
253253
com.alibaba.fluss.utils.concurrent.FutureUtils.Timeout
254254
</exclude>
255-
<exclude>com.alibaba.fluss.row.BinarySection</exclude>
256255
<exclude>com.alibaba.fluss.row.arrow.*</exclude>
257256
<exclude>
258257
com.alibaba.fluss.row.columnar.BytesColumnVector.Bytes

0 commit comments

Comments
 (0)