Skip to content

Commit 86722e8

Browse files
committed
added license to newly added file & removed unwanted comments
1 parent 0555e07 commit 86722e8

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

fluss-connectors/fluss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/source/reader/FlinkSourceReader.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
public class FlinkSourceReader
4949
extends SingleThreadMultiplexSourceReaderBase<
5050
RecordAndPos, RowData, SourceSplitBase, SourceSplitState> {
51-
// todo take changes for changeloftable columns
5251
public FlinkSourceReader(
5352
FutureCompletingBlockingQueue<RecordsWithSplitIds<RecordAndPos>> elementsQueue,
5453
Configuration flussConfig,
@@ -70,7 +69,6 @@ public FlinkSourceReader(
7069
projectedFields,
7170
flinkSourceReaderMetrics),
7271
(ignore) -> {}),
73-
// todo should have a special FlussRowToFlinkRowConverter that converts the Fluss
7472
// InternalRow into Flink RowData with the additional metadata columns
7573
new FlinkRecordEmitter(sourceOutputType, isChangelog),
7674
context.getConfiguration(),

fluss-connectors/fluss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/ChangelogRowConverter.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
/*
2+
* Copyright (c) 2024 Alibaba Group Holding Ltd.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
117
package com.alibaba.fluss.connector.flink.utils;
218

319
import com.alibaba.fluss.client.table.scanner.ScanRecord;

fluss-connectors/fluss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/utils/FlussRowToFlinkRowConverter.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public class FlussRowToFlinkRowConverter {
4747
private final FlussDeserializationConverter[] toFlinkFieldConverters;
4848
private final InternalRow.FieldGetter[] flussFieldGetters;
4949

50-
// todo converts the Fluss InternalRow into Flink RowData with the additional metadata columns
5150
public FlussRowToFlinkRowConverter(RowType rowType) {
5251
this.toFlinkFieldConverters = new FlussDeserializationConverter[rowType.getFieldCount()];
5352
this.flussFieldGetters = new InternalRow.FieldGetter[rowType.getFieldCount()];

fluss-server/src/main/java/com/alibaba/fluss/server/coordinator/CoordinatorService.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,6 @@ public CompletableFuture<DropDatabaseResponse> dropDatabase(DropDatabaseRequest
137137
return CompletableFuture.completedFuture(response);
138138
}
139139

140-
// todo keep a validation that whether the created table using system reserved columns
141-
// (_change_type, _log_offset, _commit_timestamp)
142-
143140
@Override
144141
public CompletableFuture<CreateTableResponse> createTable(CreateTableRequest request) {
145142
TablePath tablePath = toTablePath(request.getTablePath());

0 commit comments

Comments
 (0)