Skip to content

Commit 93f1bff

Browse files
committed
address comments
1 parent 9260edd commit 93f1bff

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

fluss-common/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
<dependency>
7171
<groupId>com.github.luben</groupId>
7272
<artifactId>zstd-jni</artifactId>
73-
<version> 1.5.7-1</version>
73+
<version>1.5.7-1</version>
7474
</dependency>
7575

7676
<!-- RocksDB dependencies -->

fluss-common/src/main/java/com/alibaba/fluss/compression/ZstdArrowCompressionCodec.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,10 @@ protected ArrowBuf doCompress(BufferAllocator allocator, ArrowBuf uncompressedBu
5454
compressedBuffer.nioBuffer(
5555
CompressionUtil.SIZE_OF_UNCOMPRESSED_LENGTH, (int) maxSize);
5656

57-
// The reason why we use Zstd.compressDirectByteBuffer(ByteBuffer dst, int dstOffset, int
58-
// dstSize, ByteBuffer src, int srcOffset, int srcSize, int level) instead of
59-
// Zstd.compressUnsafe(long dst, long dstSize, long src, long srcSize, int level) used in
60-
// arrow-java here is that compressUnsafe() may encounter occasional data corruption issues
61-
// when dealing with large volumes of data, and the cause has not yet been determined.
57+
// The reason why we use Zstd.compressDirectByteBuffer instead of Zstd.compressUnsafe used
58+
// in arrow-java here is that compressUnsafe() may encounter occasional data corruption
59+
// issues when dealing with large volumes of data, and the cause has not yet been
60+
// determined.
6261
long bytesWritten =
6362
Zstd.compressDirectByteBuffer(
6463
compressedDirectBuffer,

0 commit comments

Comments
 (0)