Skip to content

Commit 978480c

Browse files
zcooluoyuxia
andauthored
[hotfix] remove redundant "wait" for CompletableFuture (#657)
--------- Co-authored-by: yuxia Luo <[email protected]>
1 parent 8ef3c63 commit 978480c

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

fluss-server/src/main/java/com/alibaba/fluss/server/log/LogTablet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ public void updateRemoteLogEndOffset(long remoteLogEndOffset) {
456456
if (remoteLogEndOffset > this.remoteLogEndOffset) {
457457
this.remoteLogEndOffset = remoteLogEndOffset;
458458

459-
// try to delete these segments already exits in remote storage.
459+
// try to delete these segments already exist in remote storage.
460460
deleteSegmentsAlreadyExistsInRemote();
461461
}
462462
}

fluss-server/src/main/java/com/alibaba/fluss/server/log/remote/DefaultRemoteLogStorage.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ public void copyLogSegmentFiles(
105105
List<CompletableFuture<Void>> futures =
106106
createUploadFutures(remoteLogSegment, logSegmentFiles);
107107
FutureUtils.waitForAll(futures).get();
108-
for (CompletableFuture<Void> future : futures) {
109-
future.get();
110-
}
111108
} catch (ExecutionException e) {
112109
Throwable throwable = ExceptionUtils.stripExecutionException(e);
113110
throwable = ExceptionUtils.stripException(throwable, RuntimeException.class);

0 commit comments

Comments
 (0)