Skip to content

Commit 98f34df

Browse files
committed
[server] Remove annoy useless logging and improve log information
1 parent 7738e5f commit 98f34df

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

fluss-server/src/main/java/com/alibaba/fluss/server/authorizer/DefaultAuthorizer.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -695,5 +695,10 @@ public VersionedAcls(int zkVersion, Set<AccessControlEntry> acls) {
695695
boolean exists() {
696696
return zkVersion != UNKNOWN_VERSION;
697697
}
698+
699+
@Override
700+
public String toString() {
701+
return "VersionedAcls{" + "acls=" + acls + ", zkVersion=" + zkVersion + '}';
702+
}
698703
}
699704
}

fluss-server/src/main/java/com/alibaba/fluss/server/authorizer/ZkNodeChangeNotificationWatcher.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ private void processNotifications() {
100100
List<String> notifications = zooKeeperClient.getChildren(seqNodeRoot);
101101
Collections.sort(notifications);
102102
if (!notifications.isEmpty()) {
103-
LOG.info("Processing notifications for path = {}", seqNodeRoot);
104103
long now = clock.milliseconds();
105104
for (String notification : notifications) {
106105
long changeId = changeNumber(notification);

fluss-server/src/main/java/com/alibaba/fluss/server/tablet/TabletService.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,9 @@ private void authorizeTable(OperationType operationType, long tableId) {
348348
PhysicalTablePath tablePath = metadataCache.getTablePath(tableId);
349349
if (tablePath == null) {
350350
throw new UnknownTableOrBucketException(
351-
String.format("This server does not host this table ID %s.", tableId));
351+
String.format(
352+
"This server %s does not host this table ID %s. This may happen when the table metadata cache in the server is not updated yet.",
353+
serviceName, tableId));
352354
}
353355
if (authorizer != null
354356
&& !authorizer.isAuthorized(
@@ -390,8 +392,9 @@ private <T, K extends ResultForBucket> Map<TableBucket, T> authorizeRequestData(
390392
new ApiError(
391393
Errors.UNKNOWN_TABLE_OR_BUCKET_EXCEPTION,
392394
String.format(
393-
"This server does not host this table ID %s.",
394-
tableId))));
395+
"This server %s does not host this table ID %s. "
396+
+ "This may happen when the table metadata cache in the server is not updated yet.",
397+
serviceName, tableId))));
395398
} else if (!filteredTableIds.contains(tableId)) {
396399
errorResponseMap.put(
397400
tableBucket,

fluss-server/src/main/java/com/alibaba/fluss/server/zk/ZooKeeperClient.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -783,7 +783,6 @@ public List<String> getChildren(String path) throws Exception {
783783
public Optional<Stat> getStat(String path) throws Exception {
784784
try {
785785
Stat stat = zkClient.checkExists().forPath(path);
786-
LOG.info("stat of path {} is {}", path, stat);
787786
return Optional.of(stat);
788787
} catch (KeeperException.NoNodeException e) {
789788
return Optional.empty();

0 commit comments

Comments
 (0)