Skip to content

Commit a6974fd

Browse files
committed
fix failing tests
1 parent 81d5f5e commit a6974fd

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

fluss-client/src/test/java/org/apache/fluss/client/write/CompactedLogWriteBatchTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
import java.util.List;
4040
import java.util.concurrent.CompletableFuture;
4141

42-
import static org.apache.fluss.record.DefaultKvRecordBatch.RECORD_BATCH_HEADER_SIZE;
42+
import static org.apache.fluss.record.LogRecordBatch.CURRENT_LOG_MAGIC_VALUE;
43+
import static org.apache.fluss.record.LogRecordBatchFormat.recordBatchHeaderSize;
4344
import static org.apache.fluss.record.TestData.DATA1_PHYSICAL_TABLE_PATH;
4445
import static org.apache.fluss.record.TestData.DATA1_ROW_TYPE;
4546
import static org.apache.fluss.record.TestData.DATA1_TABLE_ID;
@@ -70,7 +71,9 @@ void testTryAppendWithWriteLimit() throws Exception {
7071
writeLimit,
7172
MemorySegment.allocateHeapMemory(writeLimit));
7273

73-
int maxRecordsPerBatch = (writeLimit - RECORD_BATCH_HEADER_SIZE) / estimatedSizeInBytes;
74+
int maxRecordsPerBatch =
75+
(writeLimit - recordBatchHeaderSize(CURRENT_LOG_MAGIC_VALUE))
76+
/ estimatedSizeInBytes;
7477
for (int i = 0; i < maxRecordsPerBatch; i++) {
7578
boolean appendResult =
7679
logProducerBatch.tryAppend(createWriteRecord(), newWriteCallback());

fluss-client/src/test/java/org/apache/fluss/client/write/IndexedLogWriteBatchTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939
import java.util.List;
4040
import java.util.concurrent.CompletableFuture;
4141

42-
import static org.apache.fluss.record.DefaultKvRecordBatch.RECORD_BATCH_HEADER_SIZE;
42+
import static org.apache.fluss.record.LogRecordBatch.CURRENT_LOG_MAGIC_VALUE;
43+
import static org.apache.fluss.record.LogRecordBatchFormat.recordBatchHeaderSize;
4344
import static org.apache.fluss.record.TestData.DATA1_PHYSICAL_TABLE_PATH;
4445
import static org.apache.fluss.record.TestData.DATA1_ROW_TYPE;
4546
import static org.apache.fluss.record.TestData.DATA1_TABLE_ID;
@@ -70,7 +71,9 @@ void testTryAppendWithWriteLimit() throws Exception {
7071
writeLimit,
7172
MemorySegment.allocateHeapMemory(writeLimit));
7273

73-
int maxRecordsPerBatch = (writeLimit - RECORD_BATCH_HEADER_SIZE) / estimatedSizeInBytes;
74+
int maxRecordsPerBatch =
75+
(writeLimit - recordBatchHeaderSize(CURRENT_LOG_MAGIC_VALUE))
76+
/ estimatedSizeInBytes;
7477
for (int i = 0; i < maxRecordsPerBatch; i++) {
7578
boolean appendResult =
7679
logProducerBatch.tryAppend(createWriteRecord(), newWriteCallback());

0 commit comments

Comments
 (0)