Skip to content

Commit b2f5a6e

Browse files
[server] Safely release buffer in FlussRequest (#1043)
1 parent 1356a7d commit b2f5a6e

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

fluss-rpc/src/main/java/com/alibaba/fluss/rpc/netty/server/FlussRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
import com.alibaba.fluss.rpc.protocol.RequestType;
2222
import com.alibaba.fluss.security.acl.FlussPrincipal;
2323
import com.alibaba.fluss.shaded.netty4.io.netty.buffer.ByteBuf;
24+
import com.alibaba.fluss.shaded.netty4.io.netty.util.ReferenceCountUtil;
25+
26+
import org.slf4j.Logger;
27+
import org.slf4j.LoggerFactory;
2428

2529
import java.net.InetAddress;
2630
import java.util.concurrent.CompletableFuture;
@@ -29,6 +33,7 @@
2933

3034
/** Represents a request received from Fluss protocol channel. */
3135
public final class FlussRequest implements RpcRequest {
36+
private static final Logger LOG = LoggerFactory.getLogger(FlussRequest.class);
3237

3338
private final short apiKey;
3439
private final short apiVersion;
@@ -101,7 +106,7 @@ public ApiMessage getMessage() {
101106

102107
public void releaseBuffer() {
103108
if (message.isLazilyParsed()) {
104-
buffer.release();
109+
ReferenceCountUtil.safeRelease(buffer);
105110
}
106111
}
107112

0 commit comments

Comments
 (0)