Skip to content

Commit e879be6

Browse files
committed
address gujian's comments
1 parent f2e8744 commit e879be6

File tree

2 files changed

+16
-16
lines changed
  • fluss-client/src/main/java/org/apache/fluss/client/admin
  • fluss-rpc/src/main/java/org/apache/fluss/rpc/protocol

2 files changed

+16
-16
lines changed

fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -510,12 +510,12 @@ ListOffsetsResult listOffsets(
510510
* <p>If one tabletServer failed adding tag, none of the tags will take effect.
511511
*
512512
* <ul>
513-
* <li>{@link AuthorizationException} If the authenticated user doesn't have reset config
514-
* access to the cluster.
513+
* <li>{@link AuthorizationException} If the authenticated user doesn't have cluster
514+
* permissions.
515515
* <li>{@link ServerNotExistException} If the tabletServer in {@code tabletServers} does not
516516
* exist.
517-
* <li>{@link ServerTagAlreadyExistException} If the server tag already exists when {@code
518-
* overWriteIfExists} is false.
517+
* <li>{@link ServerTagAlreadyExistException} If the server tag already exists for any one of
518+
* the tabletServers.
519519
* </ul>
520520
*
521521
* @param tabletServers the tabletServers we want to add server tags.
@@ -529,12 +529,12 @@ ListOffsetsResult listOffsets(
529529
* <p>If one tabletServer failed removing tag, none of the tags will be removed.
530530
*
531531
* <ul>
532-
* <li>{@link AuthorizationException} If the authenticated user doesn't have reset config
533-
* access to the cluster.
532+
* <li>{@link AuthorizationException} If the authenticated user doesn't have cluster
533+
* permissions.
534534
* <li>{@link ServerNotExistException} If the tabletServer in {@code tabletServers} does not
535535
* exist.
536-
* <li>{@link ServerTagNotExistException} If the server tag does not exist when {@code
537-
* overWriteIfExists} is false.
536+
* <li>{@link ServerTagNotExistException} If the server tag does not exist for any one of the
537+
* tabletServers.
538538
* </ul>
539539
*
540540
* @param tabletServers the tabletServers we want to remove server tags.
@@ -552,8 +552,8 @@ ListOffsetsResult listOffsets(
552552
* rebalance task exists, an {@link RebalanceFailureException} will be thrown.
553553
*
554554
* <ul>
555-
* <li>{@link AuthorizationException} If the authenticated user doesn't have reset config
556-
* access to the cluster.
555+
* <li>{@link AuthorizationException} If the authenticated user doesn't have cluster
556+
* permissions.
557557
* <li>{@link RebalanceFailureException} If the rebalance failed. Such as there is an ongoing
558558
* execution.
559559
* </ul>
@@ -570,8 +570,8 @@ CompletableFuture<Map<TableBucket, RebalancePlanForBucket>> rebalance(
570570
* List the rebalance process.
571571
*
572572
* <ul>
573-
* <li>{@link AuthorizationException} If the authenticated user doesn't have reset config
574-
* access to the cluster.
573+
* <li>{@link AuthorizationException} If the authenticated user doesn't have cluster
574+
* permissions.
575575
* <li>{@link NoRebalanceInProgressException} If there are no rebalance tasks in progress.
576576
* </ul>
577577
*
@@ -583,8 +583,8 @@ CompletableFuture<Map<TableBucket, RebalancePlanForBucket>> rebalance(
583583
* Cannel the rebalance task.
584584
*
585585
* <ul>
586-
* <li>{@link AuthorizationException} If the authenticated user doesn't have reset config
587-
* access to the cluster.
586+
* <li>{@link AuthorizationException} If the authenticated user doesn't have cluster
587+
* permissions.
588588
* <li>{@link NoRebalanceInProgressException} If there are no rebalance tasks in progress.
589589
* </ul>
590590
*/

fluss-rpc/src/main/java/org/apache/fluss/rpc/protocol/Errors.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
import org.apache.fluss.exception.SecurityTokenException;
7070
import org.apache.fluss.exception.ServerNotExistException;
7171
import org.apache.fluss.exception.ServerTagAlreadyExistException;
72+
import org.apache.fluss.exception.ServerTagNotExistException;
7273
import org.apache.fluss.exception.StorageException;
7374
import org.apache.fluss.exception.TableAlreadyExistException;
7475
import org.apache.fluss.exception.TableNotExistException;
@@ -236,8 +237,7 @@ public enum Errors {
236237
SERVER_NOT_EXIST_EXCEPTION(58, "The server is not exist.", ServerNotExistException::new),
237238
SEVER_TAG_ALREADY_EXIST_EXCEPTION(
238239
59, "The server tag already exist.", ServerTagAlreadyExistException::new),
239-
SEVER_TAG_NOT_EXIST_EXCEPTION(
240-
60, "The server tag not exist.", ServerTagAlreadyExistException::new),
240+
SEVER_TAG_NOT_EXIST_EXCEPTION(60, "The server tag not exist.", ServerTagNotExistException::new),
241241
REBALANCE_FAILURE_EXCEPTION(61, "The rebalance task failure.", RebalanceFailureException::new),
242242
NO_REBALANCE_IN_PROGRESS_EXCEPTION(
243243
62, "No rebalance task in progress.", NoRebalanceInProgressException::new);

0 commit comments

Comments
 (0)