Skip to content

Commit ee249b6

Browse files
authored
[hotfix] Optimize the error msg when throwing LogOffsetOutOfRangeException (#1216)
* [hotfix] Optimize the error msg when throwing LogOffsetOutOfRangeException * address jark's comments
1 parent 295c7b8 commit ee249b6

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

fluss-client/src/main/java/com/alibaba/fluss/client/table/scanner/log/LogFetchCollector.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -256,33 +256,37 @@ private void handleInitializeErrors(
256256
|| error == Errors.STORAGE_EXCEPTION
257257
|| error == Errors.FENCED_LEADER_EPOCH_EXCEPTION) {
258258
LOG.debug(
259-
"Error in fetch for bucket {}: {}:{}", tb, error.exceptionName(), errorMessage);
259+
"Error in fetch for bucket {}: {}:{}",
260+
tb,
261+
error.exceptionName(),
262+
error.exception(errorMessage));
260263
metadataUpdater.checkAndUpdateMetadata(tablePath, tb);
261264
} else if (error == Errors.UNKNOWN_TABLE_OR_BUCKET_EXCEPTION) {
262265
LOG.warn("Received unknown table or bucket error in fetch for bucket {}", tb);
263266
metadataUpdater.checkAndUpdateMetadata(tablePath, tb);
264267
} else if (error == Errors.LOG_OFFSET_OUT_OF_RANGE_EXCEPTION) {
265268
throw new FetchException(
266-
String.format("The fetching offset %s is out of range", fetchOffset),
267-
error.exception());
269+
String.format(
270+
"The fetching offset %s is out of range: %s",
271+
fetchOffset, error.exception(errorMessage)));
268272
} else if (error == Errors.AUTHORIZATION_EXCEPTION) {
269273
throw new AuthorizationException(errorMessage);
270274
} else if (error == Errors.UNKNOWN_SERVER_ERROR) {
271275
LOG.warn(
272276
"Unknown server error while fetching offset {} for bucket {}: {}",
273277
fetchOffset,
274278
tb,
275-
errorMessage);
279+
error.exception(errorMessage));
276280
} else if (error == Errors.CORRUPT_MESSAGE) {
277281
throw new FetchException(
278282
String.format(
279283
"Encountered corrupt message when fetching offset %s for bucket %s: %s",
280-
fetchOffset, tb, errorMessage));
284+
fetchOffset, tb, error.exception(errorMessage)));
281285
} else {
282286
throw new FetchException(
283287
String.format(
284288
"Unexpected error code %s while fetching at offset %s from bucket %s: %s",
285-
error, fetchOffset, tb, errorMessage));
289+
error, fetchOffset, tb, error.exception(errorMessage)));
286290
}
287291
}
288292
}

0 commit comments

Comments
 (0)