Skip to content

Commit f9d0dee

Browse files
authored
[dist] Fix bug when passing dynamic properties to CLI tooling (#763)
1 parent c07e09e commit f9d0dee

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

fluss-dist/src/main/resources/bin/coordinator-server.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ USAGE="Usage: $0 ((start|start-foreground) [args])|stop|stop-all"
2222

2323
STARTSTOP=$1
2424

25-
if [ -z $2 ] || [[ $2 == "-D" ]]; then
26-
# start [-D ...]
25+
if [ -z $2 ] || [[ $2 == -D* ]]; then
26+
# start|start-foreground [-D...]
2727
args=("${@:2}")
2828
fi
2929

fluss-dist/src/main/resources/bin/lakehouse.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
# limitations under the License.
1616
#
1717

18-
if [ -z $1 ] || [[ $1 == "-D" ]]; then
19-
# [-D ...]
18+
if [ -z $1 ] || [[ $1 == -D* ]]; then
19+
# [-D...]
2020
args=("${@:1}")
2121
fi
2222

fluss-dist/src/main/resources/bin/local-cluster.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ USAGE="Usage: $0 (start [args])|stop"
2020

2121
STARTSTOP=$1
2222

23-
if [ -z $2 ] || [[ $2 == "-D" ]]; then
24-
# start [-D ...]
23+
if [ -z $2 ] || [[ $2 == -D* ]]; then
24+
# start [-D...]
2525
args=("${@:2}")
2626
fi
2727

fluss-dist/src/main/resources/bin/tablet-server.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ USAGE="Usage: $0 ((start|start-foreground) [args])|stop|stop-all"
2222

2323
STARTSTOP=$1
2424

25-
if [ -z $2 ] || [[ $2 == "-D" ]]; then
26-
# start [-D ...]
25+
if [ -z $2 ] || [[ $2 == -D* ]]; then
26+
# start|start-foreground [-D...]
2727
args=("${@:2}")
2828
fi
2929

website/docs/maintenance/tiered-storage/lakehouse-storage.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,20 @@ You can use the following commands to start the datalake tiering service:
5757
cd $FLUSS_HOME
5858

5959
# start the tiering service, assuming rest endpoint is localhost:8081
60-
./bin/lakehouse.sh -D flink.rest.address=localhost -D flink.rest.port=8081
60+
./bin/lakehouse.sh -Dflink.rest.address=localhost -Dflink.rest.port=8081
6161
```
6262

6363
**Note:**
6464
- `flink.rest.address` and `flink.rest.port` are the Flink cluster's rest endpoint, you may need to change it according to your Flink cluster's configuration.
6565
- The datalake tiering service is actual a flink job, you can set the Flink configuration in `-D` arguments while starting the datalake tiering service, There are some example commands for reference below.
6666
```shell
6767
# If want to set the checkpoint interval to 10s, you can use the following command to start the datalake tiering service
68-
./bin/lakehouse.sh -D flink.rest.address=localhost -D flink.rest.port=8081 -D flink.execution.checkpointing.interval=10s
68+
./bin/lakehouse.sh -Dflink.rest.address=localhost -Dflink.rest.port=8081 -Dflink.execution.checkpointing.interval=10s
6969

7070
# By default, datalake tiering service synchronizes all the tables with datalake enabled to Lakehouse Storage.
7171
# To distribute the workload of the datalake tiering service through multiple Flink jobs,
7272
# you can specify the "database" parameter to synchronize only the datalake enabled tables in the specific database.
73-
./bin/lakehouse.sh -D flink.rest.address=localhost -D flink.rest.port=8081 -D database=fluss_\\w+
73+
./bin/lakehouse.sh -Dflink.rest.address=localhost -Dflink.rest.port=8081 -Ddatabase=fluss_\\w+
7474
```
7575

7676
### Enable Lakehouse Storage Per Table

website/docs/quickstart/flink.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ SELECT * FROM fluss_customer WHERE `cust_key` = 1;
363363
To integrate with [Apache Paimon](https://paimon.apache.org/), you need to start the `Lakehouse Tiering Service`.
364364
Open a new terminal, navigate to the `fluss-quickstart-flink` directory, and execute the following command within this directory to start the service:
365365
```shell
366-
docker compose exec coordinator-server ./bin/lakehouse.sh -D flink.rest.address=jobmanager -D flink.rest.port=8081 -D flink.execution.checkpointing.interval=30s
366+
docker compose exec coordinator-server ./bin/lakehouse.sh -Dflink.rest.address=jobmanager -Dflink.rest.port=8081 -Dflink.execution.checkpointing.interval=30s
367367
```
368368
You should see a Flink Job named `fluss-paimon-tiering-service` running in the [Flink Web UI](http://localhost:8083/).
369369

0 commit comments

Comments
 (0)