[codestyle] Require static importing from Preconditions (#473)

Author: liuxiaocs7

fluss-client/src/main/java/com/alibaba/fluss/client/table/getter/PartitionGetter.java

@@ -20,10 +20,12 @@
 import com.alibaba.fluss.types.DataType;
 import com.alibaba.fluss.types.DataTypeRoot;
 import com.alibaba.fluss.types.RowType;
-import com.alibaba.fluss.utils.Preconditions;
 
 import java.util.List;
 
+import static com.alibaba.fluss.utils.Preconditions.checkArgument;
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /** A getter to get partition name from a row. */
 public class PartitionGetter {
 
@@ -40,15 +42,15 @@ public PartitionGetter(RowType rowType, List<String> partitionKeys) {
         List<String> fieldNames = rowType.getFieldNames();
         String partitionColumnName = partitionKeys.get(0);
         int partitionColumnIndex = fieldNames.indexOf(partitionColumnName);
-        Preconditions.checkArgument(
+        checkArgument(
                 partitionColumnIndex >= 0,
                 "The partition column %s is not in the row %s.",
                 partitionColumnName,
                 rowType);
 
         // check the data type of the partition column
         DataType partitionColumnDataType = rowType.getTypeAt(partitionColumnIndex);
-        Preconditions.checkArgument(
+        checkArgument(
                 partitionColumnDataType.getTypeRoot() == DataTypeRoot.STRING,
                 "Currently, partitioned table only supports STRING type partition key, but got partition key '%s' with data type %s.",
                 partitionColumnName,
@@ -59,7 +61,7 @@ public PartitionGetter(RowType rowType, List<String> partitionKeys) {
 
     public String getPartition(InternalRow row) {
         Object partitionValue = partitionFieldGetter.getFieldOrNull(row);
-        Preconditions.checkNotNull(partitionValue, "Partition value shouldn't be null.");
+        checkNotNull(partitionValue, "Partition value shouldn't be null.");
         return partitionValue.toString();
     }
 }

fluss-client/src/main/java/com/alibaba/fluss/client/write/ArrowLogWriteBatch.java

@@ -28,13 +28,15 @@
 import com.alibaba.fluss.row.InternalRow;
 import com.alibaba.fluss.row.arrow.ArrowWriter;
 import com.alibaba.fluss.rpc.messages.ProduceLogRequest;
-import com.alibaba.fluss.utils.Preconditions;
 
 import javax.annotation.concurrent.NotThreadSafe;
 
 import java.io.IOException;
 import java.util.List;
 
+import static com.alibaba.fluss.utils.Preconditions.checkArgument;
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /**
  * A batch of log records managed in ARROW format that is or will be sent to server by {@link
  * ProduceLogRequest}.
@@ -63,13 +65,12 @@ public ArrowLogWriteBatch(
     @Override
     public boolean tryAppend(WriteRecord writeRecord, WriteCallback callback) throws Exception {
         InternalRow row = writeRecord.getRow();
-        Preconditions.checkArgument(
+        checkArgument(
                 writeRecord.getTargetColumns() == null,
                 "target columns must be null for log record");
-        Preconditions.checkArgument(
-                writeRecord.getKey() == null, "key must be null for log record");
-        Preconditions.checkNotNull(row != null, "row must not be null for log record");
-        Preconditions.checkNotNull(callback, "write callback must be not null");
+        checkArgument(writeRecord.getKey() == null, "key must be null for log record");
+        checkNotNull(row != null, "row must not be null for log record");
+        checkNotNull(callback, "write callback must be not null");
         if (recordsBuilder.isFull() || recordsBuilder.isClosed()) {
             return false;
         } else {

fluss-client/src/main/java/com/alibaba/fluss/client/write/RecordAccumulator.java

@@ -39,7 +39,6 @@
 import com.alibaba.fluss.shaded.arrow.org.apache.arrow.memory.RootAllocator;
 import com.alibaba.fluss.utils.CopyOnWriteMap;
 import com.alibaba.fluss.utils.MathUtils;
-import com.alibaba.fluss.utils.Preconditions;
 import com.alibaba.fluss.utils.clock.Clock;
 
 import org.slf4j.Logger;
@@ -59,6 +58,7 @@
 import java.util.concurrent.atomic.AtomicInteger;
 
 import static com.alibaba.fluss.record.LogRecordBatch.NO_WRITER_ID;
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
 
 /* This file is based on source code of Apache Kafka Project (https://kafka.apache.org/), licensed by the Apache
  * Software Foundation (ASF) under the Apache License, Version 2.0. See the NOTICE file distributed with this work for
@@ -636,7 +636,7 @@ private List<WriteBatch> drainBatchesForOneNode(Cluster cluster, ServerNode node
             }
 
             // the rest of the work by processing outside the lock close() is particularly expensive
-            Preconditions.checkNotNull(batch, "batch should not be null");
+            checkNotNull(batch, "batch should not be null");
             batch.close();
             size += batch.estimatedSizeInBytes();
             ready.add(batch);

fluss-client/src/main/java/com/alibaba/fluss/client/write/Sender.java

@@ -37,7 +37,6 @@
 import com.alibaba.fluss.rpc.messages.PutKvResponse;
 import com.alibaba.fluss.rpc.protocol.ApiError;
 import com.alibaba.fluss.rpc.protocol.Errors;
-import com.alibaba.fluss.utils.Preconditions;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -53,6 +52,7 @@
 
 import static com.alibaba.fluss.client.utils.ClientRpcMessageUtils.makeProduceLogRequest;
 import static com.alibaba.fluss.client.utils.ClientRpcMessageUtils.makePutKvRequest;
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
 
 /* This file is based on source code of Apache Kafka Project (https://kafka.apache.org/), licensed by the Apache
  * Software Foundation (ASF) under the Apache License, Version 2.0. See the NOTICE file distributed with this work for
@@ -121,7 +121,7 @@ public Sender(
         this.inFlightBatches = new HashMap<>();
 
         this.metadataUpdater = metadataUpdater;
-        Preconditions.checkNotNull(metadataUpdater.getCoordinatorServer());
+        checkNotNull(metadataUpdater.getCoordinatorServer());
 
         this.idempotenceManager = idempotenceManager;
         this.writerMetricGroup = writerMetricGroup;

fluss-client/src/main/java/com/alibaba/fluss/client/write/WriteBatch.java

@@ -23,7 +23,6 @@
 import com.alibaba.fluss.metadata.TableBucket;
 import com.alibaba.fluss.record.LogRecordBatch;
 import com.alibaba.fluss.record.bytesview.BytesView;
-import com.alibaba.fluss.utils.Preconditions;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -36,6 +35,8 @@
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReference;
 
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /** The abstract write batch contains write callback object to wait write request feedback. */
 @Internal
 public abstract class WriteBatch {
@@ -161,7 +162,7 @@ public boolean complete() {
      * contained in the batch.
      */
     public boolean completeExceptionally(Exception exception) {
-        Preconditions.checkNotNull(exception);
+        checkNotNull(exception);
         return done(exception);
     }
 

fluss-common/src/main/java/com/alibaba/fluss/config/ConfigBuilder.java

@@ -17,13 +17,14 @@
 package com.alibaba.fluss.config;
 
 import com.alibaba.fluss.annotation.PublicStable;
-import com.alibaba.fluss.utils.Preconditions;
 
 import java.time.Duration;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
 
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /**
  * The config builder is used to create a {@link ConfigOption}.
  *
@@ -99,7 +100,7 @@ private ConfigBuilder(String key) {
      * @return The builder for the config option with the given key.
      */
     public static ConfigBuilder key(String key) {
-        Preconditions.checkNotNull(key);
+        checkNotNull(key);
         return new ConfigBuilder(key);
     }
 

fluss-common/src/main/java/com/alibaba/fluss/config/Configuration.java

@@ -18,7 +18,6 @@
 
 import com.alibaba.fluss.annotation.PublicStable;
 import com.alibaba.fluss.utils.CollectionUtils;
-import com.alibaba.fluss.utils.Preconditions;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -32,6 +31,8 @@
 import java.util.Properties;
 import java.util.Set;
 
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /* This file is based on source code of Apache Flink Project (https://flink.apache.org/), licensed by the Apache
  * Software Foundation (ASF) under the Apache License, Version 2.0. See the NOTICE file distributed with this work for
  * additional information regarding copyright ownership. */
@@ -442,8 +443,8 @@ public String getValue(ConfigOption<?> configOption) {
      */
     public <T extends Enum<T>> T getEnum(
             final Class<T> enumClass, final ConfigOption<String> configOption) {
-        Preconditions.checkNotNull(enumClass, "enumClass must not be null");
-        Preconditions.checkNotNull(configOption, "configOption must not be null");
+        checkNotNull(enumClass, "enumClass must not be null");
+        checkNotNull(configOption, "configOption must not be null");
 
         Object rawValue = getRawValueFromOption(configOption).orElseGet(configOption::defaultValue);
         try {

fluss-common/src/main/java/com/alibaba/fluss/config/MemorySize.java

@@ -17,7 +17,6 @@
 package com.alibaba.fluss.config;
 
 import com.alibaba.fluss.annotation.PublicStable;
-import com.alibaba.fluss.utils.Preconditions;
 
 import java.math.BigDecimal;
 import java.util.Arrays;
@@ -27,6 +26,9 @@
 import java.util.Optional;
 import java.util.stream.IntStream;
 
+import static com.alibaba.fluss.utils.Preconditions.checkArgument;
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /* This file is based on source code of Apache Flink Project (https://flink.apache.org/), licensed by the Apache
  * Software Foundation (ASF) under the Apache License, Version 2.0. See the NOTICE file distributed with this work for
  * additional information regarding copyright ownership. */
@@ -75,7 +77,7 @@ public class MemorySize implements java.io.Serializable, Comparable<MemorySize>
      * @param bytes The size, in bytes. Must be zero or larger.
      */
     public MemorySize(long bytes) {
-        Preconditions.checkArgument(bytes >= 0, "bytes must be >= 0");
+        checkArgument(bytes >= 0, "bytes must be >= 0");
         this.bytes = bytes;
     }
 
@@ -205,7 +207,7 @@ public MemorySize subtract(MemorySize that) {
     }
 
     public MemorySize multiply(double multiplier) {
-        Preconditions.checkArgument(multiplier >= 0, "multiplier must be >= 0");
+        checkArgument(multiplier >= 0, "multiplier must be >= 0");
 
         BigDecimal product =
                 BigDecimal.valueOf(this.bytes).multiply(BigDecimal.valueOf(multiplier));
@@ -216,7 +218,7 @@ public MemorySize multiply(double multiplier) {
     }
 
     public MemorySize divide(long by) {
-        Preconditions.checkArgument(by >= 0, "divisor must be >= 0");
+        checkArgument(by >= 0, "divisor must be >= 0");
         return new MemorySize(bytes / by);
     }
 
@@ -244,7 +246,7 @@ public static MemorySize parse(String text) throws IllegalArgumentException {
      * @throws IllegalArgumentException Thrown, if the expression cannot be parsed.
      */
     public static long parseBytes(String text) throws IllegalArgumentException {
-        Preconditions.checkNotNull(text, "text");
+        checkNotNull(text, "text");
         if (!MemoryUnit.hasUnit(text)) {
             throw new IllegalArgumentException(
                     "The memory value '"
@@ -255,8 +257,7 @@ public static long parseBytes(String text) throws IllegalArgumentException {
         }
 
         final String trimmed = text.trim();
-        Preconditions.checkArgument(
-                !trimmed.isEmpty(), "argument is an empty- or whitespace-only string");
+        checkArgument(!trimmed.isEmpty(), "argument is an empty- or whitespace-only string");
 
         final int len = trimmed.length();
         int pos = 0;
@@ -375,11 +376,10 @@ public static String getAllUnits() {
         }
 
         public static boolean hasUnit(String text) {
-            Preconditions.checkNotNull(text, "text");
+            checkNotNull(text, "text");
 
             final String trimmed = text.trim();
-            Preconditions.checkArgument(
-                    !trimmed.isEmpty(), "argument is an empty- or whitespace-only string");
+            checkArgument(!trimmed.isEmpty(), "argument is an empty- or whitespace-only string");
 
             final int len = trimmed.length();
             int pos = 0;

fluss-common/src/main/java/com/alibaba/fluss/config/StructuredOptionsSplitter.java

@@ -16,12 +16,12 @@
 
 package com.alibaba.fluss.config;
 
-import com.alibaba.fluss.utils.Preconditions;
-
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /** Helper class for splitting a string on a given delimiter with quoting logic. */
 class StructuredOptionsSplitter {
 
@@ -44,7 +44,7 @@ class StructuredOptionsSplitter {
      * @return a list of splits
      */
     static List<String> splitEscaped(String string, char delimiter) {
-        List<Token> tokens = tokenize(Preconditions.checkNotNull(string), delimiter);
+        List<Token> tokens = tokenize(checkNotNull(string), delimiter);
         return processTokens(tokens);
     }
 

fluss-common/src/main/java/com/alibaba/fluss/fs/ClosingFSDataInputStream.java

@@ -17,11 +17,12 @@
 package com.alibaba.fluss.fs;
 
 import com.alibaba.fluss.annotation.Internal;
-import com.alibaba.fluss.utils.Preconditions;
 import com.alibaba.fluss.utils.WrappingProxy;
 
 import java.io.IOException;
 
+import static com.alibaba.fluss.utils.Preconditions.checkNotNull;
+
 /**
  * This class is a {@link WrappingProxy} for {@link FSDataInputStream} that is used to implement a
  * safety net against unclosed streams.
@@ -40,8 +41,8 @@ public class ClosingFSDataInputStream extends FSDataInputStreamWrapper
     private ClosingFSDataInputStream(
             FSDataInputStream delegate, SafetyNetCloseableRegistry registry, String debugInfo) {
         super(delegate);
-        this.registry = Preconditions.checkNotNull(registry);
-        this.debugInfo = Preconditions.checkNotNull(debugInfo);
+        this.registry = checkNotNull(registry);
+        this.debugInfo = checkNotNull(debugInfo);
         this.closed = false;
     }