test(benchmark): add msgpack serialization/deserialization to benchmark #2242
Conversation
ObjectType must be MEDIA_CONTENT or SAMPLE.
| import org.apache.fury.benchmark.state.ObjectType; | ||
| import org.apache.fury.benchmark.state.ProtoBuffersState; | ||
| import org.apache.fury.benchmark.state.ProtostuffState; | ||
| import org.apache.fury.benchmark.state.*; |
There was a problem hiding this comment.
could you use mvn spotless:apply to format code? if it doesn't optimize imports, change it manualy
we do not use * for import
There was a problem hiding this comment.
Yes, I have already used mvn spotless:apply to format code.But It is an IDE issue. I'll fix it.
| return mediaContent; | ||
| } | ||
|
|
||
| private static void packMedia(MessagePacker messagePacker, Media media) throws IOException { |
There was a problem hiding this comment.
Is there an automatic way to serialize it ? This is basically a manually-written serializer. We are benchmarking with the serializer you written instead of msgpack itself. We only use the msgpack protocol
There was a problem hiding this comment.
If there is no automatic way, maybe we could add some comments in this class and the benchmark readme
There was a problem hiding this comment.
The msgpack's official provides msgpack-jackson lib, but the performance is relatively poor. So, generate a basic handwritten code using qwen3(LLM). Then modify it.
Below is a performance comparison.
1. add description of msgpack to README.md. 2. optimize imports
manually written code
ObjectType must be MEDIA_CONTENT or SAMPLE.
What does this PR do?
add msgpack serialization/deserialization to benchmark
Related issues
no
Does this PR introduce any user-facing change?
no
Benchmark