feat(java): row encoder supports custom types and collections #2243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
extensible-row-format
branch
8 times, most recently
from
07dabdd to
276bccb
Compare
chaokunyang
reviewed
May 17, 2025
chaokunyang
approved these changes
May 17, 2025
|
Code lint failed, Please use |
|
Some generated code failed to compile |
stevenschlansker
force-pushed
the
extensible-row-format
branch
from
276bccb to
e602fd8
Compare
|
Fixed the last bug and applied formatting. |
|
One question: is there any important difference between |
stevenschlansker
force-pushed
the
extensible-row-format
branch
from
e602fd8 to
4685049
Compare
I think both are OK |
chaokunyang
pushed a commit
that referenced
this pull request
Jun 18, 2025
## What does this PR do? This PR adds documentation to `row_format_guide.md` for recent enhancements that support Java `interface` types and class inheritance (`extends`) in row format mapping. The update includes code examples demonstrating how to register interface mappings and superclass support using Fury's Java API. ## Related issues - #2310 - [#2243](#2243) - [#2250](#2250) - [#2256](#2256) ## Does this PR introduce any user-facing change? Yes. It introduces user-facing documentation explaining how to use interface and extension types with row encoding in Java. --------- Co-authored-by: nabil.shafi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extend Java Row Format to allow registering custom datatypes (e.g. UUID as Int128) and collection factories (e.g.
SortedSet<UUID>asnew TreeSet<UUID>(customComparator))Additionally supports arrays of custom types e.g.
UUID[]Since the type inference is in
fury-corebut I wanted to keep new features scoped tofury-format, I had to add a small plugin interface to core so that format can add types dynamically without affecting existing core behavior.Related issues
#2208
Does this PR introduce any user-facing change?
The
Encodersclass has newregisterCustomCodecandregisterCustomCollectionFactorymethods.All custom types are written with the existing protocol as embedded memory buffers just like any other field, but with a custom byte representation, so there should be no wire compatibility concerns.
Benchmark
There should be no change to performance in existing use cases. The code is carefully written to have no runtime impact if not used. Custom types are invoked via static methods or instance method on static final fields, which should be easily inlined by jit for minimum overhead.
Here is example generated code to help show this:
https://gist.github.com/stevenschlansker/ed7dae863e78d3c87e30bdea39fa8dea