Skip to content

Commit b69c952

Browse files
authored
fix: improve error handling in searchVectorIndex method (#750)
* fix: ensure IndexReader is properly closed in searchVectorIndex method * fix: use try-with-resources approach to avoiding exception masked
1 parent 0eb38df commit b69c952

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

  • geaflow/geaflow-plugins/geaflow-store/geaflow-store-vector/src/main/java/org/apache/geaflow/store/lucene

geaflow/geaflow-plugins/geaflow-store/geaflow-store-vector/src/main/java/org/apache/geaflow/store/lucene/GraphVectorIndex.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,7 @@ public void addVectorIndex(boolean isVertex, K key, String fieldName, float[] ve
136136
*/
137137
@Override
138138
public K searchVectorIndex(boolean isVertex, String fieldName, float[] vector, int topK) {
139-
try {
140-
// Open index reader
141-
IndexReader reader = DirectoryReader.open(directory);
139+
try (IndexReader reader = DirectoryReader.open(directory)) {
142140
IndexSearcher searcher = new IndexSearcher(reader);
143141

144142
// Create KNN vector query
@@ -166,8 +164,6 @@ public K searchVectorIndex(boolean isVertex, String fieldName, float[] vector, i
166164
throw new IllegalArgumentException("Unsupported key type: " + keyClass.getName());
167165
}
168166

169-
reader.close();
170-
171167
return result;
172168
} catch (IOException e) {
173169
throw new RuntimeException("Failed to search vector index", e);

0 commit comments

Comments
 (0)