Skip to content

Commit fb15622

Browse files
authored
Fix raw type usage: replace Collections.EMPTY_LIST with Collections.emptyList() (#766)
1 parent 332d7fd commit fb15622

6 files changed

Lines changed: 6 additions & 6 deletions

File tree

geaflow/geaflow-common/src/main/java/org/apache/geaflow/common/serialize/impl/KryoSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ protected Kryo initialValue() {
7474
kryo.setRegistrationRequired(false);
7575

7676
kryo.register(Arrays.asList("").getClass(), new ArraysAsListSerializer());
77-
kryo.register(Collections.EMPTY_LIST.getClass(), new CollectionsEmptyListSerializer());
77+
kryo.register(Collections.emptyList().getClass(), new CollectionsEmptyListSerializer());
7878
kryo.register(Collections.singletonList("").getClass(),
7979
new CollectionsSingletonListSerializer());
8080
kryo.register(ClosureSerializer.Closure.class, new ClosureSerializer());

geaflow/geaflow-core/geaflow-engine/geaflow-cluster/src/main/java/org/apache/geaflow/cluster/web/handler/PipelineRestHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public ApiResponse<Collection<CycleMetrics>> queryCycleList(@PathParam("pipeline
7878
metricFetcher.update();
7979
PipelineMetricCache cache = metricCache.getPipelineMetricCaches().get(pipelineName);
8080
if (cache == null) {
81-
return ApiResponse.success(Collections.EMPTY_LIST);
81+
return ApiResponse.success(Collections.emptyList());
8282
}
8383
return ApiResponse.success(cache.getCycleMetricList().values());
8484
} catch (Throwable t) {

geaflow/geaflow-core/geaflow-engine/geaflow-cluster/src/test/java/org/apache/geaflow/cluster/web/HttpServerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public void run() {
6060
}
6161
}).start();
6262

63-
Mockito.when(clusterManager.getContainerInfos()).thenReturn(Collections.EMPTY_MAP);
63+
Mockito.when(clusterManager.getContainerInfos()).thenReturn(Collections.emptyMap());
6464

6565
latch.await();
6666
doGet("http://localhost:8090/", "rest/overview");

geaflow/geaflow-dsl/geaflow-dsl-connector/geaflow-dsl-connector-kafka/src/main/java/org/apache/geaflow/dsl/connector/kafka/KafkaTableSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ public <T> FetchData<T> fetch(Partition partition, Optional<Offset> startOffset,
235235
if (windowStartOffset == null || windowStartOffset.timestamp() >= windowEndTimeMs) {
236236
// no data in current window, skip!
237237
KafkaOffset offset = new KafkaOffset(partitionWithOffset.f1, windowEndTimeMs);
238-
return (FetchData<T>) FetchData.createStreamFetch(Collections.EMPTY_LIST, offset, false);
238+
return (FetchData<T>) FetchData.createStreamFetch(Collections.emptyList(), offset, false);
239239
}
240240
List<String> dataList = new ArrayList<>();
241241
long responseMaxTimestamp = -1;

geaflow/geaflow-plugins/geaflow-store/geaflow-store-memory/src/main/java/org/apache/geaflow/store/memory/StaticGraphMemoryCSRStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ public Map<K, Integer> getDict() {
218218

219219
public List<IEdge<K, EV>> getEdges(K sid) {
220220
int pos = getDictId(sid);
221-
return pos == NON_EXIST ? Collections.EMPTY_LIST : getEdges(sid, pos);
221+
return pos == NON_EXIST ? Collections.emptyList() : getEdges(sid, pos);
222222
}
223223

224224
public List<IEdge<K, EV>> getEdges(K sid, int pos) {

geaflow/geaflow-plugins/geaflow-store/geaflow-store-memory/src/main/java/org/apache/geaflow/store/memory/StaticGraphMemoryStore.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ protected IVertex<K, VV> getVertex(K sid) {
7171
@Override
7272
protected List<IEdge<K, EV>> getEdges(K sid) {
7373
Tuple<IVertex<K, VV>, List<IEdge<K, EV>>> v = map.get(sid);
74-
return v == null ? Collections.EMPTY_LIST : v.f1;
74+
return v == null ? Collections.emptyList() : v.f1;
7575
}
7676

7777
@Override

0 commit comments

Comments
 (0)