Commit bae22ec
authored
Replace all #!/bin/bash shebangs with #!/usr/bin/env bash in project-owned shell scripts.
Third-party dependencies and documentation code blocks are left unchanged.
Some operating systems (e.g. NixOS) do not have a Bash executable at /bin/bash, so using
env to locate bash improves cross-platform compatibility.
For example, running dev/run-scala-test.sh on macOS may fail when Bash is installed via
Homebrew at /opt/homebrew/bin/bash rather than /bin/bash, and the hardcoded #!/bin/bash
shebang picks up the outdated system Bash (3.2) instead of the user-installed version. Apple
ships Bash 3.2 and cannot upgrade it due to the GPLv3 license of Bash 4+, so macOS users who
need modern Bash features must rely on a separately installed copy, which #!/usr/bin/env bash
will correctly resolve.
This aligns with the same change adopted by GitHub Actions runner
(see actions/runner#314) and is also consistent with what Apache Spark
does in its codebase.
Additionally, a shebang check is added to .github/workflows/util/check.sh so that future PRs
introducing #!/bin/bash in new or modified .sh files will be caught by the License Header
Check CI workflow.
1 parent 71e0db1 commit bae22ec
File tree
77 files changed
+94
-77
lines changed- .github/workflows/util
- dev
- release
- ep
- build-clickhouse/src
- resources/bin
- build-velox/src
- tools
- gluten-it/sbin
- gluten-te
- centos
- examples/buildhere-veloxbe-portable-libs
- scripts
- gha/gha-checkout
- scripts
- ubuntu
- examples
- buildhere-veloxbe-dev
- scripts
- buildhere-veloxbe-portable-libs
- scripts
- buildhere-veloxbe
- gha/gha-checkout
- scripts
- scripts
- workload
- benchmark_velox
- tpcds-delta/gen_data
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
77 files changed
+94
-77
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
18 | 21 | | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
25 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
26 | 41 | | |
27 | 42 | | |
| 43 | + | |
| 44 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
0 commit comments