Skip to content

Commit cc9269b

Browse files
authored
Merge pull request #15019 from matrei/forge-fixes
Forge fixes
2 parents 00b8008 + 0f34be3 commit cc9269b

File tree

16 files changed

+135
-56
lines changed

16 files changed

+135
-56
lines changed

dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
ext {
2424
gradleBomDependencyVersions = [
2525
'ant.version' : '1.10.15',
26-
'asciidoctor-gradle-jvm.version': '4.0.4',
26+
'asciidoctor-gradle-jvm.version': '4.0.5',
2727
'asciidoctorj.version' : '3.0.0',
2828
'asset-pipeline-gradle.version' : '5.0.15',
2929
'byte-buddy.version' : '1.17.7',

gradle.properties

Lines changed: 38 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -15,55 +15,57 @@
1515

1616
projectVersion=7.0.0-SNAPSHOT
1717

18+
javaVersion=17
19+
20+
githubBranch=7.0.x
21+
githubSlug=apache/grails-core
22+
23+
# Note: BOM dependencies are defined in dependencies.gradle files to allow for dependabot updates
24+
25+
# Project dependency versions not managed by BOMs
1826
apacheMavenVersion=3.9.9
1927
apacheMavenResolverVersion=1.9.22
20-
apacheRatVersion=0.8.1
21-
coberturaVersion=2.1.1
22-
expectitCoreVersion=0.9.0
23-
gradleExtraConfigurationsPluginVersion=10.0.1
24-
gradleLicensePluginVersion=0.16.1
25-
gradleChecksumPluginVersion=1.4.0
26-
gradleToolingApiVersion=8.12.1
27-
javaVersion=17
28-
joptSimpleVersion=5.0.4
29-
slf4jVersion=2.0.16
30-
gparsVersion=1.2.1
3128
commonsValidatorVersion=1.9.0
3229
concurrentlinkedhashmapLruVersion=1.4.2
33-
jnrPosixVersion=3.1.20
34-
joddWotVersion=3.3.8
30+
defaultElImplementationVersion=5.0.0
3531
# See https://projects.eclipse.org/releases/jakarta-10 and latest 5.0.x from https://mvnrepository.com/artifact/jakarta.el/jakarta.el-api
3632
elApiVersion=5.0.1
37-
defaultElImplementationVersion=5.0.0
38-
jspApiVersion=4.0.0
33+
expectitCoreVersion=0.9.0
34+
gparsVersion=1.2.1
35+
gradleToolingApiVersion=8.12.1
36+
hibernate5Version=5.6.15.Final
3937
javassistVersion=3.30.2-GA
40-
yakworksHibernateGroovyProxyVersion=1.1
41-
picocliVersion=4.7.6
38+
jnrPosixVersion=3.1.20
39+
joddWotVersion=3.3.8
40+
joptSimpleVersion=5.0.4
41+
jspApiVersion=4.0.0
4242
liquibaseHibernate5Version=4.27.0
43-
hibernate5Version=5.6.15.Final
44-
45-
githubSlug=apache/grails-core
46-
githubBranch=7.0.x
43+
picocliVersion=4.7.6
44+
slf4jVersion=2.0.17
45+
yakworksHibernateGroovyProxyVersion=1.1
4746

48-
org.gradle.caching=true
49-
# until https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/564 is fixed, we can't cache our configuration
50-
# org.gradle.configuration-cache=true
51-
org.gradle.parallel=true
52-
org.gradle.daemon=true
53-
# do NOT turn on due to https://github.com/gradle/gradle/issues/9489
54-
#org.gradle.configureondemand=true
55-
# note: groovydoc requires almost a doubling of this memory; if it could run in a process isolation, we could reduce this
56-
# this is a future TODO see groovydoc-tool-rewrite branch for experiementations with this
57-
org.gradle.jvmargs=-Dfile.encoding=UTF-8 -Xmx5G
47+
# Build dependency versions not managed by BOMs
48+
apacheRatVersion=0.8.1
49+
gradleChecksumPluginVersion=1.4.0
50+
gradleLicensePluginVersion=0.16.1
5851

59-
# libraries only specific to test apps, these should not be exposed
60-
jbossTransactionApiVersion=2.0.0.Final
61-
micronautVersion=4.6.5
62-
micronautSerdeJacksonVersion=2.11.0
52+
# Libraries only specific to test apps, these should not be exposed
6353
grailsSpringSecurityVersion=7.0.0-SNAPSHOT
54+
jbossTransactionApiVersion=2.0.0.Final
55+
micronautVersion=4.9.10
56+
micronautSerdeJacksonVersion=2.15.1
6457

6558
# This prevents the Grails Gradle Plugin from unnecessarily excluding slf4j-simple in the generated POMs
6659
# https://github.com/apache/grails-gradle-plugin/issues/222
6760
slf4jPreventExclusion=true
6861

69-
# note: bom dependencies are defined in dependencies.gradle files to allow for dependabot updates
62+
org.gradle.caching=true
63+
# Until https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/564 is fixed, we can't cache our configuration
64+
# org.gradle.configuration-cache=true
65+
org.gradle.parallel=true
66+
org.gradle.daemon=true
67+
# Do NOT turn on due to https://github.com/gradle/gradle/issues/9489
68+
#org.gradle.configureondemand=true
69+
# Note: groovydoc requires almost a doubling of this memory; if it could run in a process isolation, we could reduce this
70+
# This is a future TODO see groovydoc-tool-rewrite branch for experiementations with this
71+
org.gradle.jvmargs=-Dfile.encoding=UTF-8 -Xmx5G

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/Category.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ public class Category {
5252
public static final String SERVICE_DISCOVERY = "Service Discovery";
5353
public static final String SPRING = "Spring Framework";
5454
public static final String SSL = "SSL";
55+
public static final String TESTING = "Testing";
5556
public static final String TRACING = "Distributed Tracing";
5657
public static final String VALIDATION = "Validation";
5758
public static final String VIEW = "View Rendering";

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/database/TestContainers.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ public String getTitle() {
4949
return "Testcontainers";
5050
}
5151

52+
@Override
53+
public String getCategory() {
54+
return Category.TESTING;
55+
}
56+
5257
@Override
5358
public String getDescription() {
5459
return "Leverage Testcontainers to run databases and other services in Docker containers during testing.";
@@ -130,11 +135,6 @@ public boolean supports(ApplicationType applicationType) {
130135
return true;
131136
}
132137

133-
@Override
134-
public String getCategory() {
135-
return Category.DATABASE;
136-
}
137-
138138
@Nullable
139139
@Override
140140
public String getThirdPartyDocumentation() {

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/other/ShadePlugin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void apply(GeneratorContext generatorContext) {
6868
generatorContext.addHelpLink("Shadow Gradle Plugin", "https://plugins.gradle.org/plugin/com.gradleup.shadow");
6969
GradlePlugin.Builder builder = GradlePlugin.builder()
7070
.id("com.gradleup.shadow")
71-
.lookupArtifactId("shadow");
71+
.lookupArtifactId("shadow-gradle-plugin");
7272
generatorContext.addBuildPlugin(builder.build());
7373

7474
}

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/test/AssertJ.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void apply(GeneratorContext generatorContext) {
5858

5959
@Override
6060
public String getCategory() {
61-
return Category.DEV_TOOLS;
61+
return Category.TESTING;
6262
}
6363

6464
@Override

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithTestcontainers.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.grails.forge.application.Project;
2525
import org.grails.forge.application.generator.GeneratorContext;
2626
import org.grails.forge.build.dependencies.Dependency;
27+
import org.grails.forge.feature.Category;
2728
import org.grails.forge.feature.DefaultFeature;
2829
import org.grails.forge.feature.Feature;
2930
import org.grails.forge.feature.FeatureContext;
@@ -65,6 +66,11 @@ public String getDescription() {
6566
return "This plugins configure Geb for Grails framework to write automation tests that run with Testcontainers.";
6667
}
6768

69+
@Override
70+
public String getCategory() {
71+
return Category.TESTING;
72+
}
73+
6874
@Override
6975
public int getOrder() {
7076
return FeaturePhase.TEST.getOrder();

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/test/GebWithWebDriverBinaries.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ public String getDescription() {
6161
return "This plugins configure Geb for Grails framework to write automation tests with WebDriver binaries Gradle plugin. No longer maintained and limited to Gradle 8.6 and JDK 21. geb-with-testcontainers is the replacement and default starting with Grails 7.";
6262
}
6363

64+
@Override
65+
public String getCategory() {
66+
return Category.TESTING;
67+
}
68+
6469
@Override
6570
public int getOrder() {
6671
return FeaturePhase.TEST.getOrder();

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/test/GormTestingSupport.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.grails.forge.application.ApplicationType;
2323
import org.grails.forge.application.generator.GeneratorContext;
2424
import org.grails.forge.build.dependencies.Dependency;
25+
import org.grails.forge.feature.Category;
2526
import org.grails.forge.feature.DefaultFeature;
2627
import org.grails.forge.feature.Feature;
2728
import org.grails.forge.options.Options;
@@ -40,6 +41,11 @@ public String getName() {
4041
return "grails-gorm-testing-support";
4142
}
4243

44+
@Override
45+
public String getCategory() {
46+
return Category.TESTING;
47+
}
48+
4349
@Override
4450
public boolean supports(ApplicationType applicationType) {
4551
return true;

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/test/GrailsWebTestingSupport.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.grails.forge.application.ApplicationType;
2323
import org.grails.forge.application.generator.GeneratorContext;
2424
import org.grails.forge.build.dependencies.Dependency;
25+
import org.grails.forge.feature.Category;
2526
import org.grails.forge.feature.DefaultFeature;
2627
import org.grails.forge.feature.Feature;
2728
import org.grails.forge.options.Options;
@@ -40,6 +41,11 @@ public String getName() {
4041
return "grails-web-testing-support";
4142
}
4243

44+
@Override
45+
public String getCategory() {
46+
return Category.TESTING;
47+
}
48+
4349
@Override
4450
public boolean supports(ApplicationType applicationType) {
4551
return true;

0 commit comments

Comments
 (0)