fix: increase waitFor timeout in login/logout page objects for slow CI

jamesfredley · jamesfredley · commit f6af4802e19c · 2026-02-19T10:23:31.000-05:00
The default 5-second waitFor timeout was insufficient on JDK 25 CI
runners, causing UserControllerSpec to fail when the login redirect
had not completed before the test navigated to a secured page.

Assisted-by: Claude Code &lt;Claude@Claude.ai&gt;
diff --git a/grails-test-examples/scaffolding/src/integrationTest/groovy/com/example/pages/LoginPage.groovy b/grails-test-examples/scaffolding/src/integrationTest/groovy/com/example/pages/LoginPage.groovy
@@ -36,6 +36,6 @@ class LoginPage extends Page {
         this.username = username
         this.password = password
         loginButton.click()
-        waitFor { title != pageTitle }
+        waitFor(10) { title != pageTitle }
     }
 }
diff --git a/grails-test-examples/scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy b/grails-test-examples/scaffolding/src/integrationTest/groovy/com/example/pages/LogoutPage.groovy
@@ -32,6 +32,6 @@ class LogoutPage extends Page {
 
     void logout() {
         logoutButton.click()
-        waitFor { title != pageTitle }
+        waitFor(10) { title != pageTitle }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,6 @@ class LoginPage extends Page {`
`36`	`36`	`this.username = username`
`37`	`37`	`this.password = password`
`38`	`38`	`loginButton.click()`
`39`		`- waitFor { title != pageTitle }`
	`39`	`+ waitFor(10) { title != pageTitle }`
`40`	`40`	`}`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,6 @@ class LogoutPage extends Page {`
`32`	`32`
`33`	`33`	`void logout() {`
`34`	`34`	`logoutButton.click()`
`35`		`- waitFor { title != pageTitle }`
	`35`	`+ waitFor(10) { title != pageTitle }`
`36`	`36`	`}`
`37`	`37`	`}`