Using `GRAILS_REPO_URL=~/.m2/repository` generates broken `build.gradle`

[matrei]

export GRAILS_REPO_URL=~/.m2/repository
grails create-app demo

generates:

maven {
    url = 'uri('/home/mattias/.m2/repository')'
}

[jdaugherty]

@vigneshsiva11 this should be an easy fix, can you take a look?

[vigneshsiva11]

Hi @jdaugherty! I found the problem. Here is what I think we should do:

• The issue is that when a user sets GRAILS_REPO_URL to ~/.m2/repository the shell doesn't expand the ~ because it's stored as an environment variable.

• When CreateAppCommand uses this value in the build.gradle template the ~ is taken literally. Gradle can't resolve it.

To fix this we can change CreateAppCommand.groovy to normalize the path before putting it in the template. We can do this by replacing a leading ~ with the user's home directory.

Here is how we can do it:

String repoUrl = System.getenv("GRAILS_REPO_URL")

if (repoUrl != null && repoUrl.startsWith("~")) {

String homeDir = System.getProperty("user.home")

repoUrl = homeDir + repoUrl.substring(1)

}

This approach works on macOS, Linux, and Windows. It also doesn't rely on behavior. We should also add a test case to make sure it works.

The test case will set GRAILS_REPO_URL to a path that starts with ~. Check that the generated build.gradle has a full path.

I can make a request with this fix. Just let me know if this looks good or if you want me to change something.

[matrei]

The issue is that when a user sets GRAILS_REPO_URL to ~/.m2/repository the shell doesn't expand the ~ because it's stored as an environment variable.

@vigneshsiva11 If you look at the issue description, you can see that the ~ (home directory alias) is resolved, so that is not the problem. The problem is the quote usage when rendered in build.gradle.

[vigneshsiva11]

@matrei, Thank you for the correction!. Now I get it.

The ~ is already done right. The build.gradle that is generated wraps the uri call in quotes, which makes it just a string instead of a call to the Groovy method.

Here is what I have now, which is not working:
url = 'uri("/home/mattias/.m2/repository")'

I want it to be like this:
url = uri('/home/mattias/.m2/repository')

I will look at the CreateAppCommand and the ProfileRepoConfig to see where things are going wrong with the quotes and fix it.

Let me know if I am on the right track with the build.gradle and the URI call.