Skip to content

Commit 74a287f

Browse files
committed
reviewed
1 parent 9a3636e commit 74a287f

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

spock-container-test-app/src/integration-test/groovy/org/demo/spock/InheritedConfigSpec.groovy

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@ class SuperSpec extends ContainerGebSpec implements IContainerGebConfiguration {
1515
return 'super.example.com'
1616
}
1717
}
18+
1819
@Integration
1920
@ContainerGebConfiguration(hostName = 'not.example.com')
20-
class NotSuperSpec extends ContainerGebSpec {
21-
22-
}
21+
class NotSuperSpec extends ContainerGebSpec {}
2322

2423
@Integration
2524
class InheritedConfigSpec extends SuperSpec {
@@ -75,6 +74,7 @@ class SuperSuperInheritedConfigSpec extends SuperSpec {
7574
return true
7675
}
7776
}
77+
7878
@Integration
7979
class MultipleInheritanceSpec extends SuperSuperInheritedConfigSpec {
8080
void 'should show the right server name when visiting /serverName'() {

src/testFixtures/groovy/grails/plugin/geb/ContainerGebConfiguration.groovy

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2024 original author or authors
2+
* Copyright 2024-2025 original author or authors
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -56,17 +56,20 @@ import java.lang.annotation.Target
5656

5757
/**
5858
* Inheritable version of {@link ContainerGebConfiguration}
59+
*
60+
* @since 4.2
5961
*/
6062
interface IContainerGebConfiguration {
63+
6164
default String protocol() {
62-
return ContainerGebConfiguration.DEFAULT_PROTOCOL
65+
ContainerGebConfiguration.DEFAULT_PROTOCOL
6366
}
6467

6568
default String hostName() {
66-
return ContainerGebConfiguration.DEFAULT_HOSTNAME_FROM_CONTAINER
69+
ContainerGebConfiguration.DEFAULT_HOSTNAME_FROM_CONTAINER
6770
}
6871

6972
default boolean reporting() {
70-
return false
73+
false
7174
}
7275
}

0 commit comments

Comments
 (0)