From 349b3433361ce473d31370395140a20a38484c95 Mon Sep 17 00:00:00 2001 From: Brijeshthummar02 Date: Mon, 3 Mar 2025 18:39:33 +0530 Subject: [PATCH] Fix CLI output consistency and improve resource handling --- .../gravitino/cli/commands/ListCatalogProperties.java | 2 ++ .../apache/gravitino/cli/commands/ListColumns.java | 11 +++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java index 801af319ab5..94b05a6564d 100644 --- a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java +++ b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java @@ -52,6 +52,8 @@ public void handle() { try (GravitinoClient client = buildClient(metalake)) { gCatalog = client.loadCatalog(catalog); + } catch (NoSuchMetalakeException err) { + exitWithError(ErrorMessages.UNKNOWN_METALAKE); } catch (NoSuchCatalogException err) { exitWithError(ErrorMessages.UNKNOWN_CATALOG); } catch (Exception exp) { diff --git a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java index 12d6f70aadd..11ee82b2633 100644 --- a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java +++ b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java @@ -59,18 +59,17 @@ public void handle() { } StringBuilder all = new StringBuilder(); - all.append("name,datatype,comment,nullable,auto_increment").append(System.lineSeparator()); + all.append("name\tdatatype\tcomment\tnullable\tauto_increment").append(System.lineSeparator()); for (Column column : columns) { if (column == null) { continue; } - all.append(column.name()).append(","); - all.append(column.dataType() != null ? column.dataType().simpleString() : "UNKNOWN") - .append(","); - all.append(column.comment() != null ? column.comment() : "N/A").append(","); - all.append(column.nullable() ? "true" : "false").append(","); + all.append(column.name()).append("\t"); + all.append(column.dataType() != null ? column.dataType().simpleString() : "UNKNOWN").append("\t"); + all.append(column.comment() != null ? column.comment() : "N/A").append("\t"); + all.append(column.nullable() ? "true" : "false").append("\t"); all.append(column.autoIncrement() ? "true" : "false"); all.append(System.lineSeparator()); }