Skip to content

Commit 42ca8c9

Browse files
Remove redundant return statement after exitWithError
1 parent 69d5223 commit 42ca8c9

11 files changed

+0
-15
lines changed

clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTable.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,19 +88,16 @@ public void handle() {
8888

8989
if (client == null) {
9090
exitWithError("Client initialization failed.");
91-
return;
9291
}
9392
if (tableName == null) {
9493
exitWithError("Table name could not be determined.");
95-
return;
9694
}
9795

9896
try {
9997
tableData = readTableCSV.parse(columnFile);
10098
columns = readTableCSV.columns(tableData);
10199
if (columns == null || columns.length == 0) {
102100
exitWithError("No valid columns found in the provided file.");
103-
return;
104101
}
105102
} catch (Exception exp) {
106103
exitWithError("Error reading or parsing column file: " + exp.getMessage());

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.apache.gravitino.cli.ErrorMessages;
2626
import org.apache.gravitino.client.GravitinoClient;
2727
import org.apache.gravitino.exceptions.NoSuchCatalogException;
28-
import org.apache.gravitino.exceptions.NoSuchMetalakeException;
2928

3029
/** List the properties of a catalog. */
3130
public class ListCatalogProperties extends ListProperties {
@@ -53,8 +52,6 @@ public void handle() {
5352

5453
try (GravitinoClient client = buildClient(metalake)) {
5554
gCatalog = client.loadCatalog(catalog);
56-
} catch (NoSuchMetalakeException err) {
57-
exitWithError(ErrorMessages.UNKNOWN_METALAKE);
5855
} catch (NoSuchCatalogException err) {
5956
exitWithError(ErrorMessages.UNKNOWN_CATALOG);
6057
} catch (Exception exp) {

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public void handle() {
5656

5757
if (columns == null || columns.length == 0) {
5858
exitWithError("No columns found for the specified table.");
59-
return;
6059
}
6160

6261
StringBuilder all = new StringBuilder();

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesetProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ public void handle() {
7777

7878
if (gFileset == null) {
7979
exitWithError("Failed to load fileset: " + fileset);
80-
return;
8180
}
8281

8382
printProperties(gFileset.properties() != null ? gFileset.properties() : Collections.emptyMap());

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListMetalakeProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ public void handle() {
5757

5858
if (gMetalake == null) {
5959
exitWithError("Metalake not found: " + metalake);
60-
return;
6160
}
6261

6362
Map<String, String> properties = gMetalake.properties();

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchemaProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ public void handle() {
7272

7373
if (gSchema == null) {
7474
exitWithError("Schema not found: " + schema);
75-
return;
7675
}
7776

7877
Map<String, String> properties = gSchema.properties();

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTableProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ public void handle() {
8080

8181
if (gTable == null) {
8282
exitWithError("Table not found: " + table);
83-
return;
8483
}
8584

8685
Map<String, String> properties = gTable.properties();

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTagProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ public void handle() {
6464

6565
if (gTag == null) {
6666
exitWithError(ErrorMessages.UNKNOWN_TAG);
67-
return;
6867
}
6968

7069
Map<String, String> properties = gTag.properties();

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopicProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ public void handle() {
7979

8080
if (gTopic == null) {
8181
exitWithError(ErrorMessages.UNKNOWN_TOPIC);
82-
return;
8382
}
8483

8584
Map<String, String> properties = gTopic.properties();

clients/cli/src/main/java/org/apache/gravitino/cli/commands/ModelDetails.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ public void handle() {
8383

8484
if (gModel == null) {
8585
exitWithError(ErrorMessages.UNKNOWN_MODEL);
86-
return;
8786
}
8887

8988
String basicInfo =

clients/cli/src/main/java/org/apache/gravitino/cli/commands/TopicDetails.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ public void handle() {
7777

7878
if (gTopic == null) {
7979
exitWithError(ErrorMessages.UNKNOWN_TOPIC);
80-
return;
8180
}
8281

8382
printResults("Topic Name: " + gTopic.name() + ", Comment: " + gTopic.comment());

0 commit comments

Comments
 (0)