Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4584]feat(catalog-iceberg) Support loading custom catalog as backend in Gravitino Iceberg catalog #4680

Closed
wants to merge 1 commit into from
Closed

[#4584]feat(catalog-iceberg) Support loading custom catalog as backend in Gravitino Iceberg catalog #4680

wants to merge 1 commit into from

Conversation

theoryxu
Copy link
Contributor

What changes were proposed in this pull request?

Support loading custom catalog as backend in Gravitino Iceberg catalog

Why are the changes needed?

Fix: #4584

Does this PR introduce any user-facing change?

add a property key

How was this patch tested?

add UT
manual test

@theoryxu
Copy link
Contributor Author

In my case, I can reuse the JDBC catalog configurations for my custom catalog, but this approach doesn't cover other custom catalogs.

Now, we need to enumerate all configuration keys in IcebergCatalogPropertiesMetadata.

Should we accept all configurations, only those with certain prefixes, or wait until we encounter other cases?

@FANNG1 WDYT？

@FANNG1
Copy link
Contributor

FANNG1 commented Aug 26, 2024

In my case, I can reuse the JDBC catalog configurations for my custom catalog, but this approach doesn't cover other custom catalogs.

Now, we need to enumerate all configuration keys in IcebergCatalogPropertiesMetadata.

Should we accept all configurations, only those with certain prefixes, or wait until we encounter other cases?

@FANNG1 WDYT？

I prefer to delay supporting the custom catalog backend for the Gravitino Iceberg catalog until there are real requirements.

@theoryxu theoryxu self-assigned this Aug 26, 2024
@theoryxu theoryxu closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theoryxu theoryxu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Support loading custom catalog as backend in Gravitino Iceberg catalog
2 participants
@theoryxu @FANNG1