GROOVY-11572: STC: spread on non-iterable type

4_0_X backport

Author: eric-milles

src/main/java/org/codehaus/groovy/runtime/ScriptBytecodeAdapter.java

@@ -912,7 +912,7 @@ public static Object[] despreadList(Object[] args, Object[] spreads, int[] posit
             } else if (value.getClass().isArray()) {
                 ret.addAll(DefaultTypeTransformation.primitiveArrayToList(value));
             } else {
-                String error = "cannot spread the type " + value.getClass().getName() + " with value " + value;
+                String error = "Cannot spread the type " + value.getClass().getName() + " with value " + value;
                 if (value instanceof Map) {
                     error += ", did you mean to use the spread-map operator instead?";
                 }

src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java

@@ -5307,7 +5307,10 @@ protected ClassNode getType(final ASTNode node) {
         }
         if (node instanceof SpreadExpression) {
             type = getType(((SpreadExpression) node).getExpression());
-            return inferComponentType(type, null); // for list literal
+            type = inferComponentType(type, null); // for list literal
+            if (type == null) // GROOVY-11572: not an iterable
+                type = UNKNOWN_PARAMETER_TYPE;
+            return type;
         }
         if (node instanceof UnaryPlusExpression) {
             return getType(((UnaryPlusExpression) node).getExpression());

src/test/groovy/operator/SpreadListOperatorTest.groovy

@@ -94,14 +94,14 @@ class SpreadListOperatorTest extends GroovyTestCase {
             def items = [1, 2, 3, 4]
             items[*new Date()]
         '''
-        assert message.contains('cannot spread the type java.util.Date')
+        assert message.contains('Cannot spread the type java.util.Date')
 
         message = shouldFail IllegalArgumentException, '''
             def items = [1, 2, 3, 4]
             def map = [a: 1]
             items[*map]
         '''
-        assert message.contains('cannot spread the type java.util.LinkedHashMap')
+        assert message.contains('Cannot spread the type java.util.LinkedHashMap')
         assert message.contains('did you mean to use the spread-map operator instead?')
     }
 

src/test/groovy/transform/stc/ArraysAndCollectionsSTCTest.groovy

@@ -860,6 +860,15 @@ class ArraysAndCollectionsSTCTest extends StaticTypeCheckingTestCase {
         '''
     }
 
+    // GROOVY-11572
+    void testListExpressionWithSpreadOnNonIterable() {
+        assertScript '''import static groovy.test.GroovyAssert.*
+            shouldFail IllegalArgumentException, {
+                def list = [0,*1]
+            }
+        '''
+    }
+
     // GROOVY-6241
     void testAsImmutable() {
         assertScript '''

src/test/groovy/transform/stc/MethodCallsSTCTest.groovy

@@ -1250,6 +1250,14 @@ class MethodCallsSTCTest extends StaticTypeCheckingTestCase {
         'The spread operator cannot be used as argument of method or closure calls with static type checking because the number of arguments cannot be determined at compile time',
         'The spread operator cannot be used as argument of method or closure calls with static type checking because the number of arguments cannot be determined at compile time',
         'Cannot find matching method '
+
+        shouldFailWithMessages '''
+            def m(String... strings) {
+                strings?.join('')
+            }
+            def str = m(*1) // GROOVY-11572
+        ''',
+        'The spread operator cannot be used as argument of method or closure calls with static type checking because the number of arguments cannot be determined at compile time'
     }
 
     void testSpreadArgsForbiddenInStaticMethodCall() {